You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/10 07:48:40 UTC

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9881: [Feature-8252][doc] K8s and namespace manager docs and web page update

zhongjiajie commented on code in PR #9881:
URL: https://github.com/apache/dolphinscheduler/pull/9881#discussion_r868920732


##########
docs/docs/en/guide/security.md:
##########
@@ -149,3 +149,15 @@ worker.groups=default,test
 - Create a task node in the workflow definition, select the worker group and the environment corresponding to the worker group. When executing the task, the Worker will execute the environment first before executing the task.
 
 ![use-environment](/img/new_ui/dev/security/use-environment.png)
+
+## Namespace Management
+
+> Add or update  k8s cluster
+
+- First enter the configuration of the k8s cluster connection into the table t_ds_k8s in the db, which will be configured later by the web page.

Review Comment:
   ```suggestion
   - First enter the configuration of the k8s cluster connection into the table `t_ds_k8s` in the database, which will be configured later by the web page.
   ```



##########
docs/docs/en/guide/security.md:
##########
@@ -149,3 +149,15 @@ worker.groups=default,test
 - Create a task node in the workflow definition, select the worker group and the environment corresponding to the worker group. When executing the task, the Worker will execute the environment first before executing the task.
 
 ![use-environment](/img/new_ui/dev/security/use-environment.png)
+
+## Namespace Management
+
+> Add or update  k8s cluster

Review Comment:
   ```suggestion
   > Add or update k8s cluster
   ```



##########
docs/docs/zh/guide/security.md:
##########
@@ -148,3 +148,15 @@ worker.groups=default,test
 - 在工作流定义中创建任务节点选择 worker 分组和 worker 分组对应的环境,任务执行时 worker 会先执行环境在执行任务.
 
 ![use-environment](/img/new_ui/dev/security/use-environment.png)
+
+## 命名空间管理
+
+> 创建/更新 k8s集群
+
+- 先把k8s集群连接的配置录入db的表 t_ds_k8s,后续会通过页面配置.

Review Comment:
   ```suggestion
   - 先把k8s集群连接的配置录入 database 的表 `t_ds_k8s`,后续会通过页面配置.
   ```



##########
docs/docs/en/guide/security.md:
##########
@@ -149,3 +149,15 @@ worker.groups=default,test
 - Create a task node in the workflow definition, select the worker group and the environment corresponding to the worker group. When executing the task, the Worker will execute the environment first before executing the task.
 
 ![use-environment](/img/new_ui/dev/security/use-environment.png)
+
+## Namespace Management
+
+> Add or update  k8s cluster
+
+- First enter the configuration of the k8s cluster connection into the table t_ds_k8s in the db, which will be configured later by the web page.
+
+> Add or update  namespace

Review Comment:
   ```suggestion
   > Add or update namespace
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org