You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafodion.apache.org by li...@apache.org on 2018/08/17 14:05:27 UTC
[2/3] trafodion git commit: remove that unused code
remove that unused code
Project: http://git-wip-us.apache.org/repos/asf/trafodion/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafodion/commit/1011d9fb
Tree: http://git-wip-us.apache.org/repos/asf/trafodion/tree/1011d9fb
Diff: http://git-wip-us.apache.org/repos/asf/trafodion/diff/1011d9fb
Branch: refs/heads/master
Commit: 1011d9fb4f6eb9d83acd4989ac38f5fc443ebf22
Parents: cad4418
Author: Liu Ming <ov...@sina.com>
Authored: Sun Aug 12 02:17:16 2018 +0000
Committer: Liu Ming <ov...@sina.com>
Committed: Sun Aug 12 02:17:16 2018 +0000
----------------------------------------------------------------------
core/sql/optimizer/BindRI.cpp | 38 --------------------------------------
1 file changed, 38 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafodion/blob/1011d9fb/core/sql/optimizer/BindRI.cpp
----------------------------------------------------------------------
diff --git a/core/sql/optimizer/BindRI.cpp b/core/sql/optimizer/BindRI.cpp
index c2a1a31..4317aa1 100644
--- a/core/sql/optimizer/BindRI.cpp
+++ b/core/sql/optimizer/BindRI.cpp
@@ -409,44 +409,6 @@ void RefConstraint::getMatchOptionPredicateText(NAString &text,
text += ")";
}
-//helper function to check if the given column name is reserved hidden coloum
-//NOTE:
-// this function hardcode the special name string for SALT, DIVSION columns
-// if the naming convension of SALT/DIVISION column is changed,
-// this function MUST be changed as well
-static NABoolean isHiddenColumn(const char *colname)
-{
- int len = strlen(colname);
- if(strcmp(colname , "_SALT_") ==0)
- return TRUE;
- //check for DIVISION column
- //pattern _DIVISION_%d_
- //must longer than 12
- if(len >= 12) {
- //must end with _
- if(colname[len-1] == '_')
- {
- //if begin with _DIVISION_?
- if(strncmp(colname,"_DIVISION_",10) == 0)
- {
- //middle part are number
- int allDigit = 1;
- for(int i = 0; i< len-11; i++)
- {
- if(isdigit(colname[i+10]) == 0)
- {
- allDigit = 0;
- break; //not digit
- }
- }
- if(allDigit == 1)
- return TRUE;
- }
- }
- }
- return FALSE;
-}
-
// Writes a row-value-constructor consisting of fully qualified column names
// in Ansi (external) format
void RefConstraint::getPredicateText(NAString &text,