You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Thorsten Scherler <th...@wyona.com> on 2006/08/02 14:50:17 UTC

Problems with forrest.properties.xml (was: Re: svn commit: r424855 [3/3])

Hi all,

can somebody explain me what I am doing wrong?

...
> Added: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap
> URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap?rev=424855&view=auto
> ==============================================================================
> --- forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap (added)
> +++ forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap Sun Jul 23 16:26:19 2006
> @@ -0,0 +1,65 @@
...
> +      <map:match pattern="*.svn-sh.xml">
> +        <map:generate src="cocoon:/{1}.svn-revison.xml"/>
> +        <map:transform src="resources/stylesheets/svn-log.xsl">
> +          <map:parameter value="{lm:project.svn.url}" name="url"/>
> +          <!-- 
> +            If I use the following then I get:
> +            Unable to get attribute value for projectInfo.svn.ext
> +            -->
> +          <!--<map:parameter value="{project:projectInfo.svn.ext}" name="test"/>-->
> +        </map:transform>
> +        <map:serialize type="text"/>
> +      </map:match>
> +    </map:pipeline>
> +  </map:pipelines>
> +</map:sitemap>
> \ No newline at end of file

As soon as I want to use {project:projectInfo.svn.ext} then I get an
exception. However I defined (in the same commit):


> Modified:
> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml
> URL:
> http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml?rev=424855&r1=424854&r2=424855&view=diff
> ==============================================================================
> ---
> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml (original)
> +++
> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml Sun Jul 23 16:26:19 2006
> @@ -31,4 +31,6 @@
>    <!-- Indicate if the committers list should be included. Values are
> true
>         or false. -->
>    <property name="projectInfo.changes.includeCommitterList"
> value="false"/>
> +  
> +  <property name="projectInfo.svn.ext" value=".svn.xml"/>
>  </properties> 

I do not understand why {projectInfo.changes.includeCommitterList} is
working and not {project:projectInfo.svn.ext}.

Does somebody has a tip?

TIA

salu2
-- 
Thorsten Scherler
COO Spain
Wyona Inc.  -  Open Source Content Management  -  Apache Lenya
http://www.wyona.com                   http://lenya.apache.org
thorsten.scherler@wyona.com                thorsten@apache.org

Re: Problems with forrest.properties.xml

Posted by Cyriaque Dupoirieux <Cy...@pcotech.fr>.
le 02/08/2006 22:56 Thorsten Scherler a écrit :
> El mié, 02-08-2006 a las 17:18 +0200, Cyriaque Dupoirieux escribió:
>   
>> le 02/08/2006 14:50 Thorsten Scherler a écrit :
>>     
>>> Hi all,
>>>
>>> can somebody explain me what I am doing wrong?
>>>       
> ...
>   
>>> I do not understand why {projectInfo.changes.includeCommitterList} is
>>> working and not {project:projectInfo.svn.ext}.
>>>
>>> Does somebody has a tip?
>>>   
>>>       
>> The only difference I can see is that 
>> projectInfo.changes.includeCommitterList is aslo defined in the 
>> default.plugin.properties.xml
>>
>> Cyriaque,
>>     
>>> TIA
>>>       
>
> Wow, Cyriaque, thank you very much. Well spotted.
>
> I only defined it for the projectInfo (on a project base), but not in
> default (if no project base can be found). Meaning as long a project has
> this property it is working fine.
>
> As soon a project does not provide this property and it is not added to
> the default.plugin.properties.xml the input module is throwing an
> exception. I tested on a new seed and not the plugin that is why never
> have seen it working till now where I tried again it on the projectInfo
> plugin. 
>
> I added the property to the project forrest.properties.xml and it was
> working fine. As soon I removed it from there I got my error (after a
> restart). Then I added it to the default.plugin.properties.xml and it
> was working after a restart.
>
> Maybe we should change the module the way, that if a property can not
> found it should return "".
>
> wdyt?
>   
I don't like this because - in your case - you have forgotten to define 
a default value and then it does not work. The behaviour is clear.
If you return "", then it may work where as it shouldn't because you 
should have defined a specific default value.
(I don't know if I am clear enough, I am a little tired today ;-) )

Cyriaque,
> ... or is this the bug, Ross?
>
> Further I do not like that the properties cannot be changed in run time
> (I guess caching?). The biggest benefit from a xml based properties
> system is that you change the properties with a form and after reload
> you see the new properties.
>
> How can we change this or better ask should we change it?
>
> salu2
>

Re: Problems with forrest.properties.xml

Posted by Ross Gardler <rg...@apache.org>.
Thorsten Scherler wrote:
> El mié, 02-08-2006 a las 17:18 +0200, Cyriaque Dupoirieux escribió:
> 
>>le 02/08/2006 14:50 Thorsten Scherler a écrit :
>>
>>>Hi all,
>>>
>>>can somebody explain me what I am doing wrong?
> 
> ...
> 
>>>I do not understand why {projectInfo.changes.includeCommitterList} is
>>>working and not {project:projectInfo.svn.ext}.
>>>
>>>Does somebody has a tip?
>>>  
>>
>>The only difference I can see is that 
>>projectInfo.changes.includeCommitterList is aslo defined in the 
>>default.plugin.properties.xml
>>
>>Cyriaque,
>>
>>>TIA
> 
> 
> Wow, Cyriaque, thank you very much. Well spotted.
> 
> I only defined it for the projectInfo (on a project base), but not in
> default (if no project base can be found). Meaning as long a project has
> this property it is working fine.
> 
> As soon a project does not provide this property and it is not added to
> the default.plugin.properties.xml the input module is throwing an
> exception. I tested on a new seed and not the plugin that is why never
> have seen it working till now where I tried again it on the projectInfo
> plugin. 
> 
> I added the property to the project forrest.properties.xml and it was
> working fine. As soon I removed it from there I got my error (after a
> restart). Then I added it to the default.plugin.properties.xml and it
> was working after a restart.
> 
> Maybe we should change the module the way, that if a property can not
> found it should return "".
> 
> wdyt?
> 
> ... or is this the bug, Ross?

Let me see if I understand:

The error is only thrown if the property is not defined in either 
forrest.properties.xml or default.plugin.properties.xml

If it is defined in one of these then no error occurs.

Assuming that this is correct then no this is not a bug.

Should we make it return an empty string if the property is not set?

I would say no. The reason being that default.forrest.properties.xml is 
intended (at least by me) to be self documenting. If we leave a property 
out then we lose that documentation.

> Further I do not like that the properties cannot be changed in run time
> (I guess caching?). The biggest benefit from a xml based properties
> system is that you change the properties with a form and after reload
> you see the new properties.

Agreed - http://issues.apache.org/jira/browse/FOR-737

> How can we change this or better ask should we change it?

It's not quite as simple as caching the values. There are massive 
implications on performance so it should be configurable, have it turned 
on during development, turn it of in deployment or a static build.

Ross

Re: Problems with forrest.properties.xml

Posted by Thorsten Scherler <th...@apache.org>.
El mié, 02-08-2006 a las 17:18 +0200, Cyriaque Dupoirieux escribió:
> le 02/08/2006 14:50 Thorsten Scherler a écrit :
> > Hi all,
> >
> > can somebody explain me what I am doing wrong?
...
> >
> > I do not understand why {projectInfo.changes.includeCommitterList} is
> > working and not {project:projectInfo.svn.ext}.
> >
> > Does somebody has a tip?
> >   
> The only difference I can see is that 
> projectInfo.changes.includeCommitterList is aslo defined in the 
> default.plugin.properties.xml
> 
> Cyriaque,
> > TIA

Wow, Cyriaque, thank you very much. Well spotted.

I only defined it for the projectInfo (on a project base), but not in
default (if no project base can be found). Meaning as long a project has
this property it is working fine.

As soon a project does not provide this property and it is not added to
the default.plugin.properties.xml the input module is throwing an
exception. I tested on a new seed and not the plugin that is why never
have seen it working till now where I tried again it on the projectInfo
plugin. 

I added the property to the project forrest.properties.xml and it was
working fine. As soon I removed it from there I got my error (after a
restart). Then I added it to the default.plugin.properties.xml and it
was working after a restart.

Maybe we should change the module the way, that if a property can not
found it should return "".

wdyt?

... or is this the bug, Ross?

Further I do not like that the properties cannot be changed in run time
(I guess caching?). The biggest benefit from a xml based properties
system is that you change the properties with a form and after reload
you see the new properties.

How can we change this or better ask should we change it?

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)

Re: Problems with forrest.properties.xml

Posted by Ross Gardler <rg...@apache.org>.
Cyriaque Dupoirieux wrote:
> le 02/08/2006 14:50 Thorsten Scherler a écrit :
> 

...

>> I do not understand why {projectInfo.changes.includeCommitterList} is
>> working and not {project:projectInfo.svn.ext}.
>>
>> Does somebody has a tip?
>>   
> 
> The only difference I can see is that 
> projectInfo.changes.includeCommitterList is aslo defined in the 
> default.plugin.properties.xml

That shouldn't affect it, but it is worth a try. If it does affect 
things please file a bug.

I can't think of any pointers, sorry.

Ross

Re: Problems with forrest.properties.xml

Posted by Cyriaque Dupoirieux <Cy...@pcotech.fr>.
le 02/08/2006 14:50 Thorsten Scherler a écrit :
> Hi all,
>
> can somebody explain me what I am doing wrong?
>
> ...
>   
>> Added: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap
>> URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap?rev=424855&view=auto
>> ==============================================================================
>> --- forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap (added)
>> +++ forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap Sun Jul 23 16:26:19 2006
>> @@ -0,0 +1,65 @@
>>     
> ...
>   
>> +      <map:match pattern="*.svn-sh.xml">
>> +        <map:generate src="cocoon:/{1}.svn-revison.xml"/>
>> +        <map:transform src="resources/stylesheets/svn-log.xsl">
>> +          <map:parameter value="{lm:project.svn.url}" name="url"/>
>> +          <!-- 
>> +            If I use the following then I get:
>> +            Unable to get attribute value for projectInfo.svn.ext
>> +            -->
>> +          <!--<map:parameter value="{project:projectInfo.svn.ext}" name="test"/>-->
>> +        </map:transform>
>> +        <map:serialize type="text"/>
>> +      </map:match>
>> +    </map:pipeline>
>> +  </map:pipelines>
>> +</map:sitemap>
>> \ No newline at end of file
>>     
>
> As soon as I want to use {project:projectInfo.svn.ext} then I get an
> exception. However I defined (in the same commit):
>
>
>   
>> Modified:
>> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml
>> URL:
>> http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml?rev=424855&r1=424854&r2=424855&view=diff
>> ==============================================================================
>> ---
>> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml (original)
>> +++
>> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml Sun Jul 23 16:26:19 2006
>> @@ -31,4 +31,6 @@
>>    <!-- Indicate if the committers list should be included. Values are
>> true
>>         or false. -->
>>    <property name="projectInfo.changes.includeCommitterList"
>> value="false"/>
>> +  
>> +  <property name="projectInfo.svn.ext" value=".svn.xml"/>
>>  </properties> 
>>     
>
> I do not understand why {projectInfo.changes.includeCommitterList} is
> working and not {project:projectInfo.svn.ext}.
>
> Does somebody has a tip?
>   
The only difference I can see is that 
projectInfo.changes.includeCommitterList is aslo defined in the 
default.plugin.properties.xml

Cyriaque,
> TIA
>
> salu2
>