[GitHub] [beam] rohdesamuel commented on a change in pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

[GitBox <gi...@apache.org>]

rohdesamuel commented on a change in pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature
URL: https://github.com/apache/beam/pull/11227#discussion_r398175950
 
 

 ##########
 File path: sdks/python/apache_beam/runners/interactive/interactive_runner_test.py
 ##########
 @@ -150,9 +151,10 @@ def process(self, element):
     ]
     self.assertEqual(actual_reified, expected_reified)
 
+  @unittest.skipIf(
+      sys.version_info < (3, 6),
+      'InteractiveRunner has a minimum Python version of 3.5.3.')
 
 Review comment:
   Yeah, sounds good. Testing it on 3.5.4 led to some elements being in non-deterministic order, so I fixed up the Dataframe equality logic to also do a sort. Though interestingly enough this passes on later version of Python. This is probably because the dict ordering respects insertion ordering on later version, 3.6+ if I'm not mistaken.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services