You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 01:12:35 UTC

[I] [BUG] PulsarLogCollectClient.initClient0 registers repeated JVM shutdown hook [shenyu]

Aias00 opened a new issue, #6768:
URL: https://github.com/apache/shenyu/issues/6768

   - severity: Medium
   - files: `shenyu-plugin/shenyu-plugin-logging/shenyu-plugin-logging-pulsar/.../PulsarLogCollectClient.java:66`
   - description: `initClient0()` calls `Runtime.getRuntime().addShutdownHook(new Thread(this::close))`. The base class `AbstractLogConsumeClient.initClient()` already manages shutdown hook lifecycle. On re-init, `initClient()` calls `close()` but the Pulsar-specific hook is an anonymous `Thread` never tracked/removed. Each config refresh leaks one shutdown hook.
   - impact: Shutdown hook accumulation; at JVM shutdown multiple hooks call `close0()` concurrently.
   - suggested_fix: Remove the line — base class already handles shutdown hook lifecycle.
   - confidence: High
   - related_existing: none — FUNC-F2 is the same bug pattern in RocketMQ (different module/file).
   
   ---
   _Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/06-medium-tiers.md`](docs/scan2-2026-08-02/06-medium-tiers.md)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [BUG] PulsarLogCollectClient.initClient0 registers repeated JVM shutdown hook [shenyu]

Posted by "dengliming (via GitHub)" <gi...@apache.org>.
dengliming closed issue #6768: [BUG] PulsarLogCollectClient.initClient0 registers repeated JVM shutdown hook
URL: https://github.com/apache/shenyu/issues/6768


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [BUG] PulsarLogCollectClient.initClient0 registers repeated JVM shutdown hook [shenyu]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6768:
URL: https://github.com/apache/shenyu/issues/6768#issuecomment-5161316621

   👋 Hello @Aias00
   
   A new issue has been opened by @Aias00:
   - **Title**: [BUG] PulsarLogCollectClient.initClient0 registers repeated JVM shutdown hook
   - **Link**: https://github.com/apache/shenyu/issues/6768
   
   Please review when you have time. Thank you! 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org