You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2011/06/29 14:35:28 UTC
[jira] [Created] (BOOKKEEPER-28) Create useful startup scripts for
bookkeeper and hedwig
Create useful startup scripts for bookkeeper and hedwig
-------------------------------------------------------
Key: BOOKKEEPER-28
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-28
Project: Bookkeeper
Issue Type: Bug
Reporter: Ivan Kelly
Assignee: Ivan Kelly
hedwig's current startup script is messy. bookkeeper doesn't even have one. They should be created before initial release
bookkeeper-server/bin/bookkeeper
hedwig-server/bin/hedwig
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-28) Create useful startup scripts for
bookkeeper and hedwig
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-28:
---------------------------------
Attachment: BOOKKEEPER-28.diff
1.
I've added documentation now and removed the documentation for hw.bash. A lot of the documentation referred to a benchmark application which doesn't exist in the source tree, so I removed it.
2.
hw.bash does a whole load of things. It downloads zk & bk. This will be unnecessary once zk 3.4.0 is released, which our 3.4.0 release is predicated on. It sets up java. I think we should assume that people who want to run bookkeeper/hedwig already have java. It sets up yourkit, but assumes a hardcoded location. It's easier just to run <yourkit>/bin/yjp.sh -attach. It has a custom command for changing logging levels. The scripts I attached allow you to specify a custom log4j.properties at runtime. Lastly, it sets up ssh keys, sudo, limits etc. This is downright dangerous to allow a script to do.
3. I've removed most of the pom.xml changes as they refer to the packaging. I'll open another JIRA for them. The one thing I have removed is the automatic generation of giant jars with all dependencies. With the scripts these are not required to run bookkeeper or hedwig. For redistribution we the packaging jira I just mentioned will package the dependencies in a way that the scripts can pick them up.
> Create useful startup scripts for bookkeeper and hedwig
> -------------------------------------------------------
>
> Key: BOOKKEEPER-28
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-28
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 3.4.0
>
> Attachments: BOOKKEEPER-28.diff, BOOKKEEPER-28.diff, BOOKKEEPER-28.diff
>
>
> hedwig's current startup script is messy. bookkeeper doesn't even have one. They should be created before initial release
> bookkeeper-server/bin/bookkeeper
> hedwig-server/bin/hedwig
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-28) Create useful startup scripts for
bookkeeper and hedwig
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-28:
---------------------------------
Attachment: BOOKKEEPER-28.diff
Removed the old scripts directory.
> Create useful startup scripts for bookkeeper and hedwig
> -------------------------------------------------------
>
> Key: BOOKKEEPER-28
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-28
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 3.4.0
>
> Attachments: BOOKKEEPER-28.diff, BOOKKEEPER-28.diff
>
>
> hedwig's current startup script is messy. bookkeeper doesn't even have one. They should be created before initial release
> bookkeeper-server/bin/bookkeeper
> hedwig-server/bin/hedwig
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-28) Create useful startup scripts for
bookkeeper and hedwig
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-28:
---------------------------------
Attachment: BOOKKEEPER-28.diff
Applies on top of BOOKKEEPER-27 . I've added two scripts. mvn package must be run before running the script. Once the jars have been created the scripts should work out of the box. Calling the script on it's own will give you some doc.
Also, I've added some conf for generating packages in this patch, as the scripts need to work for a svn checkout and a download of a release package.
./bookkeeper-benchmark/target/bookkeeper-benchmark-3.4.0-SNAPSHOT-release.tar.gz
./bookkeeper-server/target/bookkeeper-server-3.4.0-SNAPSHOT-release.tar.gz
./hedwig-client/target/hedwig-client-3.4.0-SNAPSHOT-release.tar.gz
./hedwig-protocol/target/hedwig-protocol-3.4.0-SNAPSHOT-release.tar.gz
./hedwig-server/target/hedwig-server-3.4.0-SNAPSHOT-release.tar.gz
./target/bookkeeper-3.4.0-SNAPSHOT-release.tar.gz
Are now generated on mvn package. These should run as standalone packages. They should also build, though they will require dependent components to be in a maven repo which is not the case yet.
> Create useful startup scripts for bookkeeper and hedwig
> -------------------------------------------------------
>
> Key: BOOKKEEPER-28
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-28
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 3.4.0
>
> Attachments: BOOKKEEPER-28.diff
>
>
> hedwig's current startup script is messy. bookkeeper doesn't even have one. They should be created before initial release
> bookkeeper-server/bin/bookkeeper
> hedwig-server/bin/hedwig
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-28) Create useful startup scripts
for bookkeeper and hedwig
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085344#comment-13085344 ]
Flavio Junqueira commented on BOOKKEEPER-28:
--------------------------------------------
+1, looks good to me. I was wondering if someone with more experience on Hedwig can have a look at the scripts being removed to make sure it is ok, Utkarsh?
> Create useful startup scripts for bookkeeper and hedwig
> -------------------------------------------------------
>
> Key: BOOKKEEPER-28
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-28
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 3.4.0
>
> Attachments: BOOKKEEPER-28.diff, BOOKKEEPER-28.diff, BOOKKEEPER-28.diff
>
>
> hedwig's current startup script is messy. bookkeeper doesn't even have one. They should be created before initial release
> bookkeeper-server/bin/bookkeeper
> hedwig-server/bin/hedwig
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-28) Create useful startup scripts for
bookkeeper and hedwig
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-28:
---------------------------------
Fix Version/s: 3.4.0
> Create useful startup scripts for bookkeeper and hedwig
> -------------------------------------------------------
>
> Key: BOOKKEEPER-28
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-28
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 3.4.0
>
>
> hedwig's current startup script is messy. bookkeeper doesn't even have one. They should be created before initial release
> bookkeeper-server/bin/bookkeeper
> hedwig-server/bin/hedwig
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-28) Create useful startup scripts
for bookkeeper and hedwig
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073273#comment-13073273 ]
Flavio Junqueira commented on BOOKKEEPER-28:
--------------------------------------------
Ivan, Three comments:
# Should we consider adding instructions on how to use the scripts to the documentation?
# You're removing the current Hedwig scripts, but the ones you're adding do not seem to have all the functionality of the ones you're removing. Could explain why you think this is ok?
# Could you give a little more detail on what the changes to pom.xml are supposed to do?
> Create useful startup scripts for bookkeeper and hedwig
> -------------------------------------------------------
>
> Key: BOOKKEEPER-28
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-28
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 3.4.0
>
> Attachments: BOOKKEEPER-28.diff, BOOKKEEPER-28.diff
>
>
> hedwig's current startup script is messy. bookkeeper doesn't even have one. They should be created before initial release
> bookkeeper-server/bin/bookkeeper
> hedwig-server/bin/hedwig
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira