[jira] [Commented] (DAEMON-399) apxStrUnQuoteInplaceA removes needed quotes

["Gary Gregory (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DAEMON-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813387#comment-16813387 ] 

Gary Gregory commented on DAEMON-399:
-------------------------------------

Hi [~spjoe],

It would be best if you could offer your change via a PR on GitHub.

Thank you!
Gary

> apxStrUnQuoteInplaceA removes needed quotes
> -------------------------------------------
>
>                 Key: DAEMON-399
>                 URL: https://issues.apache.org/jira/browse/DAEMON-399
>             Project: Commons Daemon
>          Issue Type: Bug
>          Components: Procrun
>    Affects Versions: 1.1.0
>            Reporter: Camillo Dell'mour
>            Priority: Minor
>
> When trying to pass the following argument to the jvm
> {code:java}
> -Xlog:gc:file="d:\logs\gc.log"::filecount=5,filesize=20000
> {code}
> the method apxStrUnQuoteInplaceA removes " from it and the resulting command looks like this:
> {code:java}
> -Xlog:gc:file=d:\logs\gc.log::filecount=5,filesize=2000
> {code}
> Which is an invalid jvm argument.
> Workaround for version 1.1.0 is to add a space into the log filename.
> IMHO the proper fix would be not too use apxStrUnQuoteInplaceA at all.
> Another possible fix would be to replace utils.c:571 with
> {code}
> else if (*p == ' ' || *p == ':') {
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)