[GitHub] [spark] maryannxue commented on a change in pull request #27752: [SPARK-30999][SQL] Don't cancel a QueryStageExec which failed before call doMaterialize

[GitBox <gi...@apache.org>]

maryannxue commented on a change in pull request #27752: [SPARK-30999][SQL] Don't cancel a QueryStageExec which failed before call doMaterialize 
URL: https://github.com/apache/spark/pull/27752#discussion_r386455665
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
 ##########
 @@ -176,7 +179,9 @@ case class AdaptiveSparkPlanExec(
                 }
               }(AdaptiveSparkPlanExec.executionContext)
             } catch {
-              case e: Throwable => events.offer(StageFailure(stage, e))
+              case e: Throwable =>
+                earlyFailedStage = Some(stage.id)
 
 Review comment:
   Can we call `cleanUpAndThrowException` here instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org