You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Daniel Estévez <no...@github.com> on 2018/05/29 19:28:39 UTC

[jclouds/jclouds] Checks network availability before working with created networks (#1214)

This affected (at least) [AzureComputeImageExtensionLiveTest](https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/compute/extensions/AzureComputeImageExtensionLiveTest.java) running in some regions. (worked in North/West Europe but failed consistently in CanadaEast)

This check will add some stability when running in different regions

(Unrelated> Is there a policy on ordering the imports?)
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1214

-- Commit Summary --

  * Checks network availability before working with recently created networks

-- File Changes --

    M providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/config/AzurePredicatesModule.java (108)
    M providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/strategy/CreateResourcesThenCreateNodes.java (32)
    M providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/compute/strategy/CreateResourcesThenCreateNodesTest.java (17)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1214.patch
https://github.com/jclouds/jclouds/pull/1214.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1214

Re: [jclouds/jclouds] Checks network availability before working with created networks (#1214)

Posted by Ignasi Barrera <no...@github.com>.
nacx approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1214#pullrequestreview-124156894

Re: [jclouds/jclouds] Checks network availability before working with created networks (#1214)

Posted by Ignasi Barrera <no...@github.com>.
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/3171e4c7) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/d8257ae4). Thanks @danielestevez!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1214#issuecomment-400202881

Re: [jclouds/jclouds] Checks network availability before working with created networks (#1214)

Posted by Ignasi Barrera <no...@github.com>.
Closed #1214.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1214#event-1700614179