You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/12/19 03:44:11 UTC
Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64701/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Joseph Wu, and Michael Park.
Repository: mesos
Description
-------
After upgrading Visual Studio to 15.5.2, warning C4530 started being
emitted for practically every file. Since we use the STL (which uses
exceptions), apparently we need to compile with `/EHsc`. This sets the
exception-handling model to catch C++ exceptions, and to assume that
functions declared as `extern "C"` never throw a C++ exception.
Diffs
-----
cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
Diff: https://reviews.apache.org/r/64701/diff/1/
Testing
-------
Built on Windows, warning is gone (and gone in 3rdparty builds too).
Thanks,
Andrew Schwartzmeyer
Re: Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`.
Posted by Eric Mumau via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64701/#review194190
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Mumau
On Dec. 19, 2017, 3:44 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64701/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 3:44 a.m.)
>
>
> Review request for mesos, Akash Gupta, Joseph Wu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After upgrading Visual Studio to 15.5.2, warning C4530 started being
> emitted for practically every file. Since we use the STL (which uses
> exceptions), apparently we need to compile with `/EHsc`. This sets the
> exception-handling model to catch C++ exceptions, and to assume that
> functions declared as `extern "C"` never throw a C++ exception.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
>
>
> Diff: https://reviews.apache.org/r/64701/diff/2/
>
>
> Testing
> -------
>
> Built on Windows, warning is gone (and gone in 3rdparty builds too).
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64701/#review194124
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['64701']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64701
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64701/logs/mesos-tests-build-cmake-stdout.log):
```
D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(75): warning C4267: '=': conversion from 'size_t' to 'unsigned long', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(271): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(333): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(216): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(242): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(274): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\common\protobuf_utils.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\files\files.cpp(704): warning C4267: 'argument': conversion from 'size_t' to 'off_t', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\master.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\quota_handler.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(6223): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(6325): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(6890): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\weights_handler.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(9012): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\allocator\sorter\drf\sorter.cpp(589): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(10853): warning C4244: 'return': conversion from '::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) ->
D:\DCOS\mesos\mesos\include\csi/spec.hpp(21): fatal error C1083: Cannot open include file: 'csi/csi.grpc.pb.h': No such file or directory (compiling source file D:\DCOS\mesos\mesos\src\slave\task_status_update_manager.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\include\csi/spec.hpp(21): fatal error C1083: Cannot open include file: 'csi/csi.grpc.pb.h': No such file or directory (compiling source file D:\DCOS\mesos\mesos\src\slave\slave.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
132 Warning(s)
2 Error(s)
Time Elapsed 00:02:46.17
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64701/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "cmTC_8386b.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_8386b.dir\Debug\cmTC_8386b.tlog\".
InitializeBuildStatus:
Creating "cmTC_8386b.dir\Debug\cmTC_8386b.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_8386b.dir\Debug\" /Fd"cmTC_8386b.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_8386b.dir\Debug\" /Fd"cmTC_8386b.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_8386b.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_8386b.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_8386b.lib" /MACHINE:X64 /machine:x64 cmTC_8386b.dir\Debug\src.obj
cmTC_8386b.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_8386b.exe
FinalizeBuildStatus:
Deleting file "cmTC_8386b.dir\Debug\cmTC_8386b.tlog\unsuccessfulbuild".
Touching "cmTC_8386b.dir\Debug\cmTC_8386b.tlog\cmTC_8386b.lastbuildstate".
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_8386b.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:00.97
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64701/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_549e0.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_549e0.dir\Debug\cmTC_549e0.tlog\".
InitializeBuildStatus:
Creating "cmTC_549e0.dir\Debug\cmTC_549e0.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_549e0.dir\Debug\" /Fd"cmTC_549e0.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_549e0.dir\Debug\" /Fd"cmTC_549e0.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_549e0.vcxproj]
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_549e0.vcxproj" (default targets) -- FAILED.
Build FAILED.
"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_549e0.vcxproj" (default target) (1) ->
(ClCompile target) ->
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_549e0.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:00.56
```
- Mesos Reviewbot Windows
On Dec. 19, 2017, 3:44 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64701/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 3:44 a.m.)
>
>
> Review request for mesos, Akash Gupta, Joseph Wu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After upgrading Visual Studio to 15.5.2, warning C4530 started being
> emitted for practically every file. Since we use the STL (which uses
> exceptions), apparently we need to compile with `/EHsc`. This sets the
> exception-handling model to catch C++ exceptions, and to assume that
> functions declared as `extern "C"` never throw a C++ exception.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
>
>
> Diff: https://reviews.apache.org/r/64701/diff/1/
>
>
> Testing
> -------
>
> Built on Windows, warning is gone (and gone in 3rdparty builds too).
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64701/#review194173
-----------------------------------------------------------
PASS: Mesos patch 64701 was successfully built and tested.
Reviews applied: `['64701']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64701
- Mesos Reviewbot Windows
On Dec. 19, 2017, 3:44 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64701/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 3:44 a.m.)
>
>
> Review request for mesos, Akash Gupta, Joseph Wu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After upgrading Visual Studio to 15.5.2, warning C4530 started being
> emitted for practically every file. Since we use the STL (which uses
> exceptions), apparently we need to compile with `/EHsc`. This sets the
> exception-handling model to catch C++ exceptions, and to assume that
> functions declared as `extern "C"` never throw a C++ exception.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
>
>
> Diff: https://reviews.apache.org/r/64701/diff/2/
>
>
> Testing
> -------
>
> Built on Windows, warning is gone (and gone in 3rdparty builds too).
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>