You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2011/04/12 17:52:01 UTC

Re: svn commit: r1091470 - in /subversion/trunk/subversion: libsvn_wc/questions.c tests/cmdline/stat_tests.py

On 04/12/2011 11:34 AM, philip@apache.org wrote:
> Author: philip
> Date: Tue Apr 12 15:34:31 2011
> New Revision: 1091470
> 
> URL: http://svn.apache.org/viewvc?rev=1091470&view=rev
> Log:
> Start making timestamp repair work in WCNG; revert now works but
> not cleanup.  Issue 3773.

Excellent!

And yet, bummer -- you stole my commit.  Well, this is what I get for not
marked 3773 STARTED and assigning it to myself.

   $ svn revert -R .
   Reverted 'subversion/libsvn_wc/questions.c'
   $

:-)

> * subversion/libsvn_wc/questions.c
>   (svn_wc__internal_file_modified_p): Repair timestamps if locked.

Please make the docstring for this function point out this new behavior so
that callers can depend on / expect it.

(Also, as you saw, Bert points out that the post-commit processing might be
doing this work twice now.  You'll want to look into that.)

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand