You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by cpfeiffer <gi...@git.apache.org> on 2014/08/18 16:25:21 UTC
[GitHub] ant-ivyde pull request: Fix for the user-selected configurations n...
GitHub user cpfeiffer opened a pull request:
https://github.com/apache/ant-ivyde/pull/1
Fix for the user-selected configurations not being checked in the viewer
When you have an ivy.xml that extends another module and that other
module defines some configurations, it occurred that calling
settingsSetupTab.init(conf.isSettingsProjectSpecific(),
conf.getIvySettingsSetup());
would cause the configurations being set again, because the
ModifyListener of ivyUserDirEditor would fire and cause
reinitialization.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cpfeiffer/ant-ivyde master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant-ivyde/pull/1.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1
----
commit 79e3dd4c238f6438e53baf0ab6c1f5688b961d91
Author: Carsten Pfeiffer <ca...@gebit.de>
Date: 2014-08-18T14:20:46Z
Fix for the user-selected configurations not being checked in the viewer
When you have an ivy.xml that extends another module and that other
module defines some configurations, it occurred that calling
settingsSetupTab.init(conf.isSettingsProjectSpecific(),
conf.getIvySettingsSetup());
would cause the configurations being set again, because the
ModifyListener of ivyUserDirEditor would fire and cause
reinitialization.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivyde pull request: Fix for the user-selected configurations n...
Posted by cpfeiffer <gi...@git.apache.org>.
Github user cpfeiffer commented on the pull request:
https://github.com/apache/ant-ivyde/pull/1#issuecomment-54116292
Ping.... shall I rather file a bugreport at issues.apache.org or should this pull request be sufficient?
This pull request fixes the IvyDE classpath container properties dialog not showing the configurations to resolve. The available configurations are display fine, but they are all unchecked if
- the ivy.xml extends another module and
- that module defines some own configurations
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivyde pull request: Fix for the user-selected configurations n...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/ant-ivyde/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org