[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3067: ARTEMIS-2701 Improving DLQ/check over previously removed records

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #3067: ARTEMIS-2701 Improving DLQ/check over previously removed records
URL: https://github.com/apache/activemq-artemis/pull/3067#discussion_r404266832
 
 

 ##########
 File path: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ##########
 @@ -1048,6 +1048,12 @@ public AMQSession getSession(SessionId sessionId) {
 
    public void removeDestination(ActiveMQDestination dest) throws Exception {
       if (dest.isQueue()) {
+
+         if (!dest.isTemporary()) {
+            // this should not really happen,
+            // so I'm not creating a Logger for this
+            logger.warn("OpenWire client sending a queue remove towards " + dest.getPhysicalName());
 
 Review comment:
   I dont get this change,  why shouldnt this happen?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services