You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/24 06:19:04 UTC
[jira] [Commented] (SAMZA-1307) Fix ZkKeyBuilder null checks for
pathPrefix
[ https://issues.apache.org/jira/browse/SAMZA-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022367#comment-16022367 ]
ASF GitHub Bot commented on SAMZA-1307:
---------------------------------------
GitHub user navina opened a pull request:
https://github.com/apache/samza/pull/202
SAMZA-1307 - Fix ZkKeyBuilder null checks for pathPrefix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/navina/samza SAMZA-1307
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/202.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #202
----
commit 923d1f163d25e83fcead323e7b1107872bf161ba
Author: Navina Ramesh <na...@apache.org>
Date: 2017-05-24T06:10:32Z
SAMZA-1307 - Fix ZkKeyBuilder null checks for pathPrefix
----
> Fix ZkKeyBuilder null checks for pathPrefix
> --------------------------------------------
>
> Key: SAMZA-1307
> URL: https://issues.apache.org/jira/browse/SAMZA-1307
> Project: Samza
> Issue Type: Bug
> Reporter: Navina Ramesh
> Assignee: Navina Ramesh
> Fix For: 0.13.0
>
>
> 1. {{pathPrefix}} is currently trimmed after {{Strings.isNullOrEmpty}}. This will allow strings with whitespace as a valid pathPrefix.
> 2. getJobModelPathPrefix has incorrect number of arguments in the format string
> 3. {{pathPrefixCannotBeNullOrEmpty}} in TestZkKeyBuilder skips checks after first exception is asserted.
> This JIRA is to address the above issues.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)