You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "HonahX (via GitHub)" <gi...@apache.org> on 2024/02/04 23:05:38 UTC
[I] Implement Centralized Management of Table Properties [iceberg-python]
HonahX opened a new issue, #365:
URL: https://github.com/apache/iceberg-python/issues/365
### Feature Request / Improvement
With the release of version 0.6.0, pyiceberg is set to expand its capabilities in handling a greater variety of table properties, encompassing both read and write operations.
It would be beneficial to have a place to manage the names and default values of all table properties. Similar to Apache Iceberg Java's [TableProperties](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/TableProperties.java) and [PropertyUtil](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/util/PropertyUtil.java) classes.
We can create a new file named `properties.py` under `pyiceberg.table` to hold properties' name and default, and another file named `property_util.py` under `pyiceberg.utils` to parse properties into `int`, `bool`, or `Optional[T]`.
This will ensure consistent parsing of properties across the codebase and simplify future updates or changes in property names and defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Implement Centralized Management of Table Properties [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed issue #365: Implement Centralized Management of Table Properties
URL: https://github.com/apache/iceberg-python/issues/365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Implement Centralized Management of Table Properties [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #365:
URL: https://github.com/apache/iceberg-python/issues/365#issuecomment-1928022429
I think this is a great idea @HonahX. I try to avoid creating a lot of new files, since imports in Python are slow. What do you think of adding a class `TableProperties` to `table/__init__.py`. This way we can call it `TableProperties.MAX_PARQUET_DICTIONARY_SIZE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Implement Centralized Management of Table Properties [iceberg-python]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on issue #365:
URL: https://github.com/apache/iceberg-python/issues/365#issuecomment-1928773118
@Fokko Sounds good. My initial thought was to use a new file because table/__init__.py already has a substantial amount of content, and it's likely to grow as we develop write support. However, considering the importance of import speed, integrating it into `table/__init__.py` seems like the more efficient approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Implement Centralized Management of Table Properties [iceberg-python]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on issue #365:
URL: https://github.com/apache/iceberg-python/issues/365#issuecomment-1928871173
I can take this if no one has started it :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org