You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by li...@apache.org on 2022/09/29 02:27:49 UTC
[rocketmq] branch develop updated: style(common):Enable checkstyle for test code (#5215)
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new b82531c43 style(common):Enable checkstyle for test code (#5215)
b82531c43 is described below
commit b82531c432546d615b1db5a80bcf5b3f35f114ba
Author: Nowinkey <no...@tom.com>
AuthorDate: Thu Sep 29 10:27:42 2022 +0800
style(common):Enable checkstyle for test code (#5215)
---
common/pom.xml | 24 ++++++++
.../org/apache/rocketmq/common/MixAllTest.java | 16 ------
.../rocketmq/common/RegisterBrokerBodyTest.java | 2 -
.../common/message/MessageDecoderTest.java | 2 +-
.../rocketmq/common/protocol/ClusterInfoTest.java | 5 +-
.../rocketmq/common/protocol/GroupListTest.java | 8 +--
.../common/protocol/NamespaceUtilTest.java | 6 +-
.../protocol/QueryConsumeTimeSpanBodyTest.java | 16 +++---
.../protocol/body/ConsumerRunningInfoTest.java | 6 +-
.../MessageRequestModeSerializeWrapperTest.java | 2 +-
.../body/QueryConsumeQueueResponseBodyTest.java | 3 +-
.../body/SubscriptionGroupWrapperTest.java | 2 +-
.../protocol/topic/OffsetMovedEventTest.java | 66 +++++++++++-----------
.../common/sysflag/CompressionFlagTest.java | 6 +-
.../rocketmq/common/topic/TopicValidatorTest.java | 1 -
.../common/utils/ConcurrentHashMapUtilsTest.java | 2 +-
.../rocketmq/common/utils/IOTinyUtilsTest.java | 14 ++++-
17 files changed, 99 insertions(+), 82 deletions(-)
diff --git a/common/pom.xml b/common/pom.xml
index 196b7fa2d..fac02c785 100644
--- a/common/pom.xml
+++ b/common/pom.xml
@@ -66,4 +66,28 @@
<artifactId>commons-codec</artifactId>
</dependency>
</dependencies>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${maven-checkstyle-plugin.version}</version>
+ <executions>
+ <execution>
+ <id>validate</id>
+ <phase>validate</phase>
+ <configuration>
+ <configLocation>${project.parent.basedir}/style/rmq_checkstyle.xml</configLocation>
+ <inputEncoding>UTF-8</inputEncoding>
+ <consoleOutput>true</consoleOutput>
+ <failsOnError>true</failsOnError>
+ <includeTestSourceDirectory>true</includeTestSourceDirectory>
+ </configuration>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
</project>
diff --git a/common/src/test/java/org/apache/rocketmq/common/MixAllTest.java b/common/src/test/java/org/apache/rocketmq/common/MixAllTest.java
index 457b9b5fb..efb42085f 100644
--- a/common/src/test/java/org/apache/rocketmq/common/MixAllTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/MixAllTest.java
@@ -67,22 +67,6 @@ public class MixAllTest {
file.delete();
}
- @Test
- public void testFile2String_WithChinese() throws IOException {
- String fileName = System.getProperty("java.io.tmpdir") + File.separator + "MixAllTest" + System.currentTimeMillis();
- File file = new File(fileName);
- if (file.exists()) {
- file.delete();
- }
- file.createNewFile();
- PrintWriter out = new PrintWriter(fileName, "UTF-8");
- out.write("TestForMixAll_中文");
- out.close();
- String string = MixAll.file2String(fileName);
- assertThat(string).isEqualTo("TestForMixAll_中文");
- file.delete();
- }
-
@Test
public void testString2File() throws IOException {
String fileName = System.getProperty("java.io.tmpdir") + File.separator + "MixAllTest" + System.currentTimeMillis();
diff --git a/common/src/test/java/org/apache/rocketmq/common/RegisterBrokerBodyTest.java b/common/src/test/java/org/apache/rocketmq/common/RegisterBrokerBodyTest.java
index 73703c02d..9001fc16c 100644
--- a/common/src/test/java/org/apache/rocketmq/common/RegisterBrokerBodyTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/RegisterBrokerBodyTest.java
@@ -42,8 +42,6 @@ public class RegisterBrokerBodyTest {
byte[] compareEncode = registerBrokerBody.encode(true);
byte[] encode2 = registerBrokerBody.encode(false);
- System.out.println(compareEncode.length);
- System.out.println(encode2.length);
RegisterBrokerBody decodeRegisterBrokerBody = RegisterBrokerBody.decode(compareEncode, true);
assertEquals(registerBrokerBody.getTopicConfigSerializeWrapper().getTopicConfigTable().size(), decodeRegisterBrokerBody.getTopicConfigSerializeWrapper().getTopicConfigTable().size());
diff --git a/common/src/test/java/org/apache/rocketmq/common/message/MessageDecoderTest.java b/common/src/test/java/org/apache/rocketmq/common/message/MessageDecoderTest.java
index 46469e7f8..2cd54685b 100644
--- a/common/src/test/java/org/apache/rocketmq/common/message/MessageDecoderTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/message/MessageDecoderTest.java
@@ -383,7 +383,7 @@ public class MessageDecoderTest {
}
@Test
- public void testMessageId() throws Exception{
+ public void testMessageId() throws Exception {
// ipv4 messageId test
MessageExt msgExt = new MessageExt();
msgExt.setStoreHost(new InetSocketAddress("127.0.0.1", 9103));
diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/ClusterInfoTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/ClusterInfoTest.java
index bfdd87215..a67df5072 100644
--- a/common/src/test/java/org/apache/rocketmq/common/protocol/ClusterInfoTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/protocol/ClusterInfoTest.java
@@ -22,7 +22,10 @@ import org.apache.rocketmq.common.protocol.body.ClusterInfo;
import org.apache.rocketmq.common.protocol.route.BrokerData;
import org.apache.rocketmq.remoting.protocol.RemotingSerializable;
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertArrayEquals;
import org.junit.Test;
diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/GroupListTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/GroupListTest.java
index 854ff05dd..f5f05a044 100644
--- a/common/src/test/java/org/apache/rocketmq/common/protocol/GroupListTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/protocol/GroupListTest.java
@@ -32,10 +32,10 @@ public class GroupListTest {
@Test
public void testSetGet() throws Exception {
- HashSet<String> fisrtUniqueSet=createUniqueNewSet();
- HashSet<String> secondUniqueSet=createUniqueNewSet();
+ HashSet<String> fisrtUniqueSet = createUniqueNewSet();
+ HashSet<String> secondUniqueSet = createUniqueNewSet();
assertThat(fisrtUniqueSet).isNotEqualTo(secondUniqueSet);
- GroupList gl=new GroupList();
+ GroupList gl = new GroupList();
gl.setGroupList(fisrtUniqueSet);
assertThat(gl.getGroupList()).isEqualTo(fisrtUniqueSet);
assertThat(gl.getGroupList()).isNotEqualTo(secondUniqueSet);
@@ -45,7 +45,7 @@ public class GroupListTest {
}
private HashSet<String> createUniqueNewSet() {
- HashSet<String> groups=new HashSet<String>();
+ HashSet<String> groups = new HashSet<String>();
groups.add(UUID.randomUUID().toString());
return groups;
}
diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/NamespaceUtilTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/NamespaceUtilTest.java
index 7e470d949..4ace70abe 100644
--- a/common/src/test/java/org/apache/rocketmq/common/protocol/NamespaceUtilTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/protocol/NamespaceUtilTest.java
@@ -22,7 +22,7 @@ import org.junit.Assert;
import org.junit.Test;
/**
- * @author MQDevelopers
+ * MQDevelopers
*/
public class NamespaceUtilTest {
@@ -75,14 +75,14 @@ public class NamespaceUtilTest {
Assert.assertEquals(dlqTopicWithNamespace, DLQ_TOPIC_WITH_NAMESPACE);
String dlqTopicWithNamespaceAgain = NamespaceUtil.wrapNamespace(INSTANCE_ID, dlqTopicWithNamespace);
Assert.assertEquals(dlqTopicWithNamespaceAgain, dlqTopicWithNamespace);
- Assert.assertEquals(dlqTopicWithNamespaceAgain, DLQ_TOPIC_WITH_NAMESPACE );
+ Assert.assertEquals(dlqTopicWithNamespaceAgain, DLQ_TOPIC_WITH_NAMESPACE);
//test system topic
String systemTopic = NamespaceUtil.wrapNamespace(INSTANCE_ID, SYSTEM_TOPIC);
Assert.assertEquals(systemTopic, SYSTEM_TOPIC);
}
@Test
- public void testGetNamespaceFromResource(){
+ public void testGetNamespaceFromResource() {
String namespaceExpectBlank = NamespaceUtil.getNamespaceFromResource(TOPIC);
Assert.assertEquals(namespaceExpectBlank, NamespaceUtil.STRING_BLANK);
String namespace = NamespaceUtil.getNamespaceFromResource(TOPIC_WITH_NAMESPACE);
diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/QueryConsumeTimeSpanBodyTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/QueryConsumeTimeSpanBodyTest.java
index 76844d91c..022f1b6e3 100644
--- a/common/src/test/java/org/apache/rocketmq/common/protocol/QueryConsumeTimeSpanBodyTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/protocol/QueryConsumeTimeSpanBodyTest.java
@@ -51,19 +51,19 @@ public class QueryConsumeTimeSpanBodyTest {
QueryConsumeTimeSpanBody qctsb = new QueryConsumeTimeSpanBody();
List<QueueTimeSpan> queueTimeSpans = new ArrayList<QueueTimeSpan>();
QueueTimeSpan queueTimeSpan = new QueueTimeSpan();
- queueTimeSpan.setMinTimeStamp(1550825710000l);
- queueTimeSpan.setMaxTimeStamp(1550825790000l);
- queueTimeSpan.setConsumeTimeStamp(1550825760000l);
- queueTimeSpan.setDelayTime(5000l);
+ queueTimeSpan.setMinTimeStamp(1550825710000L);
+ queueTimeSpan.setMaxTimeStamp(1550825790000L);
+ queueTimeSpan.setConsumeTimeStamp(1550825760000L);
+ queueTimeSpan.setDelayTime(5000L);
MessageQueue messageQueue = new MessageQueue("topicName", "brokerName", 1);
queueTimeSpan.setMessageQueue(messageQueue);
queueTimeSpans.add(queueTimeSpan);
qctsb.setConsumeTimeSpanSet(queueTimeSpans);
String json = RemotingSerializable.toJson(qctsb, true);
QueryConsumeTimeSpanBody fromJson = RemotingSerializable.fromJson(json, QueryConsumeTimeSpanBody.class);
- assertThat(fromJson.getConsumeTimeSpanSet().get(0).getMaxTimeStamp()).isEqualTo(1550825790000l);
- assertThat(fromJson.getConsumeTimeSpanSet().get(0).getMinTimeStamp()).isEqualTo(1550825710000l);
- assertThat(fromJson.getConsumeTimeSpanSet().get(0).getDelayTime()).isEqualTo(5000l);
+ assertThat(fromJson.getConsumeTimeSpanSet().get(0).getMaxTimeStamp()).isEqualTo(1550825790000L);
+ assertThat(fromJson.getConsumeTimeSpanSet().get(0).getMinTimeStamp()).isEqualTo(1550825710000L);
+ assertThat(fromJson.getConsumeTimeSpanSet().get(0).getDelayTime()).isEqualTo(5000L);
assertThat(fromJson.getConsumeTimeSpanSet().get(0).getMessageQueue()).isEqualTo(messageQueue);
}
@@ -105,7 +105,7 @@ public class QueryConsumeTimeSpanBodyTest {
queueTimeSpan.setMinTimeStamp(System.currentTimeMillis());
queueTimeSpan.setMaxTimeStamp(UtilAll.computeNextHourTimeMillis());
queueTimeSpan.setConsumeTimeStamp(UtilAll.computeNextMinutesTimeMillis());
- queueTimeSpan.setDelayTime(5000l);
+ queueTimeSpan.setDelayTime(5000L);
MessageQueue messageQueue = new MessageQueue(UUID.randomUUID().toString(), UUID.randomUUID().toString(), new Random().nextInt());
queueTimeSpan.setMessageQueue(messageQueue);
queueTimeSpans.add(queueTimeSpan);
diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfoTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfoTest.java
index b37189383..98d02853c 100644
--- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfoTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfoTest.java
@@ -86,20 +86,20 @@ public class ConsumerRunningInfoTest {
}
@Test
- public void testAnalyzeRebalance(){
+ public void testAnalyzeRebalance() {
boolean result = ConsumerRunningInfo.analyzeRebalance(criTable);
assertThat(result).isTrue();
}
@Test
- public void testAnalyzeProcessQueue(){
+ public void testAnalyzeProcessQueue() {
String result = ConsumerRunningInfo.analyzeProcessQueue("client_id", consumerRunningInfo);
assertThat(result).isEmpty();
}
@Test
- public void testAnalyzeSubscription(){
+ public void testAnalyzeSubscription() {
boolean result = ConsumerRunningInfo.analyzeSubscription(criTable);
assertThat(result).isTrue();
}
diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapperTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapperTest.java
index bea2f5fdc..a3b16587d 100644
--- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapperTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapperTest.java
@@ -27,7 +27,7 @@ import static org.assertj.core.api.Assertions.assertThat;
public class MessageRequestModeSerializeWrapperTest {
@Test
- public void testFromJson(){
+ public void testFromJson() {
MessageRequestModeSerializeWrapper messageRequestModeSerializeWrapper = new MessageRequestModeSerializeWrapper();
ConcurrentHashMap<String, ConcurrentHashMap<String, SetMessageRequestModeRequestBody>>
messageRequestModeMap = new ConcurrentHashMap<String, ConcurrentHashMap<String, SetMessageRequestModeRequestBody>>();
diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryConsumeQueueResponseBodyTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryConsumeQueueResponseBodyTest.java
index fad86f71f..c4699705e 100644
--- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryConsumeQueueResponseBodyTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryConsumeQueueResponseBodyTest.java
@@ -29,7 +29,7 @@ import static org.assertj.core.api.Assertions.assertThat;
public class QueryConsumeQueueResponseBodyTest {
@Test
- public void test(){
+ public void test() {
QueryConsumeQueueResponseBody body = new QueryConsumeQueueResponseBody();
SubscriptionData subscriptionData = new SubscriptionData();
@@ -51,7 +51,6 @@ public class QueryConsumeQueueResponseBodyTest {
String json = RemotingSerializable.toJson(body, true);
QueryConsumeQueueResponseBody fromJson = RemotingSerializable.fromJson(json, QueryConsumeQueueResponseBody.class);
- System.out.println(json);
//test ConsumeQueue
ConsumeQueueData jsonData = fromJson.getQueueData().get(0);
assertThat(jsonData.getMsg()).isEqualTo("this is default msg");
diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapperTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapperTest.java
index ffd7f6102..009c80d9f 100644
--- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapperTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapperTest.java
@@ -27,7 +27,7 @@ import static org.assertj.core.api.Assertions.assertThat;
public class SubscriptionGroupWrapperTest {
@Test
- public void testFromJson(){
+ public void testFromJson() {
SubscriptionGroupWrapper subscriptionGroupWrapper = new SubscriptionGroupWrapper();
ConcurrentHashMap<String, SubscriptionGroupConfig> subscriptions = new ConcurrentHashMap<String, SubscriptionGroupConfig>();
SubscriptionGroupConfig subscriptionGroupConfig = new SubscriptionGroupConfig();
diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/topic/OffsetMovedEventTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/topic/OffsetMovedEventTest.java
index c22c2d62a..b9a2ca650 100644
--- a/common/src/test/java/org/apache/rocketmq/common/protocol/topic/OffsetMovedEventTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/protocol/topic/OffsetMovedEventTest.java
@@ -25,44 +25,44 @@ import org.junit.Test;
public class OffsetMovedEventTest {
- @Test
- public void testFromJson() throws Exception {
- OffsetMovedEvent event = mockOffsetMovedEvent();
+ @Test
+ public void testFromJson() throws Exception {
+ OffsetMovedEvent event = mockOffsetMovedEvent();
- String json = event.toJson();
- OffsetMovedEvent fromJson = RemotingSerializable.fromJson(json, OffsetMovedEvent.class);
+ String json = event.toJson();
+ OffsetMovedEvent fromJson = RemotingSerializable.fromJson(json, OffsetMovedEvent.class);
- assertEquals(event, fromJson);
- }
+ assertEquals(event, fromJson);
+ }
- @Test
- public void testFromBytes() throws Exception {
- OffsetMovedEvent event = mockOffsetMovedEvent();
+ @Test
+ public void testFromBytes() throws Exception {
+ OffsetMovedEvent event = mockOffsetMovedEvent();
- byte[] encodeData = event.encode();
- OffsetMovedEvent decodeData = RemotingSerializable.decode(encodeData, OffsetMovedEvent.class);
+ byte[] encodeData = event.encode();
+ OffsetMovedEvent decodeData = RemotingSerializable.decode(encodeData, OffsetMovedEvent.class);
- assertEquals(event, decodeData);
- }
+ assertEquals(event, decodeData);
+ }
- private void assertEquals(OffsetMovedEvent srcData, OffsetMovedEvent decodeData) {
- assertThat(decodeData.getConsumerGroup()).isEqualTo(srcData.getConsumerGroup());
- assertThat(decodeData.getMessageQueue().getTopic())
- .isEqualTo(srcData.getMessageQueue().getTopic());
- assertThat(decodeData.getMessageQueue().getBrokerName())
- .isEqualTo(srcData.getMessageQueue().getBrokerName());
- assertThat(decodeData.getMessageQueue().getQueueId())
- .isEqualTo(srcData.getMessageQueue().getQueueId());
- assertThat(decodeData.getOffsetRequest()).isEqualTo(srcData.getOffsetRequest());
- assertThat(decodeData.getOffsetNew()).isEqualTo(srcData.getOffsetNew());
- }
+ private void assertEquals(OffsetMovedEvent srcData, OffsetMovedEvent decodeData) {
+ assertThat(decodeData.getConsumerGroup()).isEqualTo(srcData.getConsumerGroup());
+ assertThat(decodeData.getMessageQueue().getTopic())
+ .isEqualTo(srcData.getMessageQueue().getTopic());
+ assertThat(decodeData.getMessageQueue().getBrokerName())
+ .isEqualTo(srcData.getMessageQueue().getBrokerName());
+ assertThat(decodeData.getMessageQueue().getQueueId())
+ .isEqualTo(srcData.getMessageQueue().getQueueId());
+ assertThat(decodeData.getOffsetRequest()).isEqualTo(srcData.getOffsetRequest());
+ assertThat(decodeData.getOffsetNew()).isEqualTo(srcData.getOffsetNew());
+ }
- private OffsetMovedEvent mockOffsetMovedEvent() {
- OffsetMovedEvent event = new OffsetMovedEvent();
- event.setConsumerGroup("test-group");
- event.setMessageQueue(new MessageQueue("test-topic", "test-broker", 0));
- event.setOffsetRequest(3000L);
- event.setOffsetNew(1000L);
- return event;
- }
+ private OffsetMovedEvent mockOffsetMovedEvent() {
+ OffsetMovedEvent event = new OffsetMovedEvent();
+ event.setConsumerGroup("test-group");
+ event.setMessageQueue(new MessageQueue("test-topic", "test-broker", 0));
+ event.setOffsetRequest(3000L);
+ event.setOffsetNew(1000L);
+ return event;
+ }
}
diff --git a/common/src/test/java/org/apache/rocketmq/common/sysflag/CompressionFlagTest.java b/common/src/test/java/org/apache/rocketmq/common/sysflag/CompressionFlagTest.java
index 63906c321..8590d5695 100644
--- a/common/src/test/java/org/apache/rocketmq/common/sysflag/CompressionFlagTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/sysflag/CompressionFlagTest.java
@@ -34,12 +34,12 @@ public class CompressionFlagTest {
flag |= MessageSysFlag.COMPRESSION_LZ4_TYPE;
assertThat(MessageSysFlag.getCompressionType(flag)).isEqualTo(CompressionType.LZ4);
- flag &= (~MessageSysFlag.COMPRESSION_TYPE_COMPARATOR);
+ flag &= ~MessageSysFlag.COMPRESSION_TYPE_COMPARATOR;
flag |= MessageSysFlag.COMPRESSION_ZSTD_TYPE;
assertThat(MessageSysFlag.getCompressionType(flag)).isEqualTo(CompressionType.ZSTD);
- flag &= (~MessageSysFlag.COMPRESSION_TYPE_COMPARATOR);
+ flag &= ~MessageSysFlag.COMPRESSION_TYPE_COMPARATOR;
flag |= MessageSysFlag.COMPRESSION_ZLIB_TYPE;
assertThat(MessageSysFlag.getCompressionType(flag)).isEqualTo(CompressionType.ZLIB);
}
@@ -48,7 +48,7 @@ public class CompressionFlagTest {
public void testCompressionFlagNotMatch() {
int flag = 0;
flag |= MessageSysFlag.COMPRESSED_FLAG;
- flag |= (0x4 << 8);
+ flag |= 0x4 << 8;
MessageSysFlag.getCompressionType(flag);
}
diff --git a/common/src/test/java/org/apache/rocketmq/common/topic/TopicValidatorTest.java b/common/src/test/java/org/apache/rocketmq/common/topic/TopicValidatorTest.java
index bb49417b0..148a62b75 100644
--- a/common/src/test/java/org/apache/rocketmq/common/topic/TopicValidatorTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/topic/TopicValidatorTest.java
@@ -17,7 +17,6 @@
package org.apache.rocketmq.common.topic;
import org.apache.rocketmq.common.protocol.ResponseCode;
-import org.apache.rocketmq.common.topic.TopicValidator;
import org.apache.rocketmq.remoting.protocol.RemotingCommand;
import org.junit.Test;
diff --git a/common/src/test/java/org/apache/rocketmq/common/utils/ConcurrentHashMapUtilsTest.java b/common/src/test/java/org/apache/rocketmq/common/utils/ConcurrentHashMapUtilsTest.java
index 89a4b0cda..8e32fc93a 100644
--- a/common/src/test/java/org/apache/rocketmq/common/utils/ConcurrentHashMapUtilsTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/utils/ConcurrentHashMapUtilsTest.java
@@ -20,7 +20,7 @@ package org.apache.rocketmq.common.utils;
import java.util.concurrent.ConcurrentHashMap;
import org.junit.Test;
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
public class ConcurrentHashMapUtilsTest {
diff --git a/common/src/test/java/org/apache/rocketmq/common/utils/IOTinyUtilsTest.java b/common/src/test/java/org/apache/rocketmq/common/utils/IOTinyUtilsTest.java
index 117faf5b1..79bf9429b 100644
--- a/common/src/test/java/org/apache/rocketmq/common/utils/IOTinyUtilsTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/utils/IOTinyUtilsTest.java
@@ -20,13 +20,23 @@ package org.apache.rocketmq.common.utils;
import org.apache.rocketmq.common.UtilAll;
import org.apache.rocketmq.remoting.common.RemotingHelper;
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertEquals;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
-import java.io.*;
+import java.io.File;
+import java.io.Reader;
+import java.io.Writer;
+import java.io.StringReader;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.ByteArrayInputStream;
+import java.io.CharArrayReader;
+import java.io.CharArrayWriter;
+import java.io.BufferedReader;
import java.lang.reflect.Method;
import java.util.List;