Re: Review Request 25266: Simulator build support need to extends for RPM build

[Rohit Yadav <bh...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25266/#review55784
-----------------------------------------------------------


LGTM, we'll wait for other reviewers to comment before we land this on master. This may be seen as a new feature? In which case, please discuss on dev ML and ask David for his advice on getting this in before 4.5 is cut.

- Rohit Yadav


On Sept. 19, 2014, 7:17 p.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25266/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 7:17 p.m.)
> 
> 
> Review request for cloudstack, Frank Zhang and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-7469
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7469
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently there is no option to build rpm with simulator,  as part this patch modified package.sh file to accept simulator
> 
> also updated cloud.spec file to build both oss and nooss simulator buids
> 
> 
> To build noredist and simulator, you need to use below package command
> ./package.sh --pack noredist --s simulator
> 
> default package with simulato, need to call  ./package.sh
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 7306d1f 
>   packaging/centos63/package.sh 6a2d168 
> 
> Diff: https://reviews.apache.org/r/25266/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> File Attachments
> ----------------
> 
> 0001-Simulator-build-support-for-RPM-builds.patch
>   https://reviews.apache.org/media/uploaded/files/2014/09/19/2537284e-f1de-419a-b5b6-66b8ddfcac84__0001-Simulator-build-support-for-RPM-builds.patch
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>