You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/01/08 03:30:44 UTC
[GitHub] [incubator-livy] codecov-io edited a comment on issue #268:
[LIVY-735][RSC] Fix rpc channel closed when multi clients connect to one
driver
codecov-io edited a comment on issue #268: [LIVY-735][RSC] Fix rpc channel closed when multi clients connect to one driver
URL: https://github.com/apache/incubator-livy/pull/268#issuecomment-567787664
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/268?src=pr&el=h1) Report
> Merging [#268](https://codecov.io/gh/apache/incubator-livy/pull/268?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/25542e4e78b39a3c9b9426a70a92ca7c183daea3?src=pr&el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/incubator-livy/pull/268?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #268 +/- ##
============================================
+ Coverage 68.18% 68.31% +0.12%
- Complexity 945 953 +8
============================================
Files 102 102
Lines 5899 5920 +21
Branches 896 897 +1
============================================
+ Hits 4022 4044 +22
+ Misses 1303 1301 -2
- Partials 574 575 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/268?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/268/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `81.66% <100%> (+1.75%)` | `46 <0> (+1)` | :arrow_up: |
| [rsc/src/main/java/org/apache/livy/rsc/rpc/Rpc.java](https://codecov.io/gh/apache/incubator-livy/pull/268/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjLmphdmE=) | `72.01% <59.4%> (-7.28%)` | `30 <19> (+18)` | |
| [...in/java/org/apache/livy/rsc/rpc/RpcDispatcher.java](https://codecov.io/gh/apache/incubator-livy/pull/268/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjRGlzcGF0Y2hlci5qYXZh) | `84.21% <90%> (+25.02%)` | `8 <6> (-11)` | :arrow_down: |
| [...in/java/org/apache/livy/rsc/driver/JobWrapper.java](https://codecov.io/gh/apache/incubator-livy/pull/268/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvSm9iV3JhcHBlci5qYXZh) | `82.85% <0%> (-5.72%)` | `8% <0%> (-1%)` | |
| [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/268/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `52.94% <0%> (-2.95%)` | `7% <0%> (ø)` | |
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/268/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `33.33% <0%> (+0.45%)` | `11% <0%> (ø)` | :arrow_down: |
| [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/268/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `75% <0%> (+1.25%)` | `40% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/268?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/268?src=pr&el=footer). Last update [25542e4...07afe95](https://codecov.io/gh/apache/incubator-livy/pull/268?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services