You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/17 03:37:48 UTC

[GitHub] [spark] bozhang2820 commented on a change in pull request #35462: [SPARK-31709][SQL][FOLLOWUP] Treat table location as absolute when the first letter of its path is slash in create/alter table

bozhang2820 commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r808648712



##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -53,15 +53,11 @@ import org.apache.spark.sql.types._
 import org.apache.spark.sql.v2.avro.AvroScan
 import org.apache.spark.util.Utils
 
-abstract class AvroSuite
+abstract class AvroSuiteBase

Review comment:
       After running the test in `CommonFileDataSourceSuite`, `org.apache.hadoop.fs.Path.getFileSystem()` in other tests in the same suite will fail the check in `FakeFileSystemRequiringDSOption`, since they share the same `SparkContext`. 
   
   That's why I split the suites that extends `CommonFileDataSourceSuite` into separate ones in this change.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org