[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #188: JCRVLT-575: handle symlinks in homeDir path

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #188:
URL: https://github.com/apache/jackrabbit-filevault/pull/188#discussion_r769768009



##########
File path: vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSInstallStateCache.java
##########
@@ -53,10 +58,14 @@
     private Map<Path, PackageId> pathIdMapping = new ConcurrentHashMap<>();
 
     private final Path homeDir;
-    
+
     public FSInstallStateCache(Path homeDir) throws IOException {
         this.homeDir = homeDir;
-        Files.createDirectories(homeDir);
+        log.debug("checking for presence of {} - exists {} - isDirectory {}", homeDir, Files.exists(homeDir), Files.isDirectory(homeDir));
+        if (Files.notExists(homeDir)) {

Review comment:
       What happens if the path `homeDir` is a file and not a directory?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org