You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Keta Patel <pa...@us.ibm.com> on 2016/03/07 17:59:10 UTC
Review Request 44457: AMBARI-15310: Host Service Summary Page does not
display long service names well
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310
Repository: ambari
Description
-------
In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
Also, note the indentation of the last button for Clients does not align well with the buttons above it.
Diffs
-----
ambari-web/app/styles/application.less 755dff2
ambari-web/app/templates/main/host/details/host_component.hbs 60031de
ambari-web/app/templates/main/host/summary.hbs 17a0b69
Diff: https://reviews.apache.org/r/44457/diff/
Testing
-------
FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
TESTS:
No tests are written for these changes as the fix involves updates in the stylesheet.
Thanks,
Keta Patel
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 7, 2016, 10:18 p.m., Di Li wrote:
> > ambari-web/app/templates/main/host/details/host_component.hbs, line 30
> > <https://reviews.apache.org/r/44457/diff/1/?file=1283159#file1283159line30>
> >
> > How is the service name displayed when the component name is extra long, in relation to the new divs added ?
> >
> > The service name should be visible so that user can navigate back to the corresponding service.
> >
> > What about fixing the width of the component name and trancate it with ... when it reaches the limite.
> >
> > For example, ExtraLongZookeeperComponentName would be dispalyed as
> >
> > ExtraLongZook.../Zookeeper
> >
> > The ExtraLongZookeeperComponentName is still displayed on zookeeper's dashboard where user can hover over to reveal the host name, yes ?
>
> Keta Patel wrote:
> Hello Di,
> I have attached a screenshot "Extra Long Service Names with Fix.tiff" on the Jira which shows how extra long service names look with the current fix.
> Yes, you are right about the entire service name being displayed on the dashboard's navigation menu on the left side.
> I am looking into how we could use "..." or flyouts for this issue.
> Thanks!
>
> Keta Patel wrote:
> Hello Di,
> I have updated the logic in the patch to use fixed number of characters in the Service Name (14 characters). It displays first 11 characters followed by ellipses "..." for Service Names longer than 14 characters. Length of 14 characters is decided keeping in mind of "Ambari Metrics" since it is the longest service name in trunk.
> I have also added tooltip (using Ember's "bindattr" with "title", as I found this being used in other places of the code as well) to display the entire Service Name for all components.
>
> I have attached a screenshot "Service names with ellipses and tooltip.tiff" to show how long service names would look like with the updated fix in patch-3
> (Note: This image was taken while testing where I had used 13 characters limit only)
>
> Please let me know if I could make further improvements.
> Thanks!
>
> Di Li wrote:
> Hello Keta,
>
> That's very close. Can both component name and service name be set to a fixed number of chars and with flyout ? The real estate on host page is limited and need to save room for the widgets, buttons, etc.
Hello Di,
I have updated the patch with similar changes for Component names. I have taken 19 characters as the max length (from "App Timeline Server"). For longer component names, only the first 16 characters are displayed followed by ellipses "...".
A tooltip displaying the entire component name is also added in a <span> surrounding the name.
Let me know if more changes are required.
Thanks!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122388
-----------------------------------------------------------
On March 8, 2016, 7:26 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 7:26 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 7, 2016, 10:18 p.m., Di Li wrote:
> > ambari-web/app/templates/main/host/details/host_component.hbs, line 30
> > <https://reviews.apache.org/r/44457/diff/1/?file=1283159#file1283159line30>
> >
> > How is the service name displayed when the component name is extra long, in relation to the new divs added ?
> >
> > The service name should be visible so that user can navigate back to the corresponding service.
> >
> > What about fixing the width of the component name and trancate it with ... when it reaches the limite.
> >
> > For example, ExtraLongZookeeperComponentName would be dispalyed as
> >
> > ExtraLongZook.../Zookeeper
> >
> > The ExtraLongZookeeperComponentName is still displayed on zookeeper's dashboard where user can hover over to reveal the host name, yes ?
Hello Di,
I have attached a screenshot "Extra Long Service Names with Fix.tiff" on the Jira which shows how extra long service names look with the current fix.
Yes, you are right about the entire service name being displayed on the dashboard's navigation menu on the left side.
I am looking into how we could use "..." or flyouts for this issue.
Thanks!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122388
-----------------------------------------------------------
On March 7, 2016, 9:57 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 9:57 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 7, 2016, 10:18 p.m., Di Li wrote:
> > ambari-web/app/templates/main/host/details/host_component.hbs, line 30
> > <https://reviews.apache.org/r/44457/diff/1/?file=1283159#file1283159line30>
> >
> > How is the service name displayed when the component name is extra long, in relation to the new divs added ?
> >
> > The service name should be visible so that user can navigate back to the corresponding service.
> >
> > What about fixing the width of the component name and trancate it with ... when it reaches the limite.
> >
> > For example, ExtraLongZookeeperComponentName would be dispalyed as
> >
> > ExtraLongZook.../Zookeeper
> >
> > The ExtraLongZookeeperComponentName is still displayed on zookeeper's dashboard where user can hover over to reveal the host name, yes ?
>
> Keta Patel wrote:
> Hello Di,
> I have attached a screenshot "Extra Long Service Names with Fix.tiff" on the Jira which shows how extra long service names look with the current fix.
> Yes, you are right about the entire service name being displayed on the dashboard's navigation menu on the left side.
> I am looking into how we could use "..." or flyouts for this issue.
> Thanks!
Hello Di,
I have updated the logic in the patch to use fixed number of characters in the Service Name (14 characters). It displays first 11 characters followed by ellipses "..." for Service Names longer than 14 characters. Length of 14 characters is decided keeping in mind of "Ambari Metrics" since it is the longest service name in trunk.
I have also added tooltip (using Ember's "bindattr" with "title", as I found this being used in other places of the code as well) to display the entire Service Name for all components.
I have attached a screenshot "Service names with ellipses and tooltip.tiff" to show how long service names would look like with the updated fix in patch-3
(Note: This image was taken while testing where I had used 13 characters limit only)
Please let me know if I could make further improvements.
Thanks!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122388
-----------------------------------------------------------
On March 8, 2016, 7:26 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 7:26 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Di Li <di...@ca.ibm.com>.
> On March 7, 2016, 10:18 p.m., Di Li wrote:
> > ambari-web/app/templates/main/host/details/host_component.hbs, line 30
> > <https://reviews.apache.org/r/44457/diff/1/?file=1283159#file1283159line30>
> >
> > How is the service name displayed when the component name is extra long, in relation to the new divs added ?
> >
> > The service name should be visible so that user can navigate back to the corresponding service.
> >
> > What about fixing the width of the component name and trancate it with ... when it reaches the limite.
> >
> > For example, ExtraLongZookeeperComponentName would be dispalyed as
> >
> > ExtraLongZook.../Zookeeper
> >
> > The ExtraLongZookeeperComponentName is still displayed on zookeeper's dashboard where user can hover over to reveal the host name, yes ?
>
> Keta Patel wrote:
> Hello Di,
> I have attached a screenshot "Extra Long Service Names with Fix.tiff" on the Jira which shows how extra long service names look with the current fix.
> Yes, you are right about the entire service name being displayed on the dashboard's navigation menu on the left side.
> I am looking into how we could use "..." or flyouts for this issue.
> Thanks!
>
> Keta Patel wrote:
> Hello Di,
> I have updated the logic in the patch to use fixed number of characters in the Service Name (14 characters). It displays first 11 characters followed by ellipses "..." for Service Names longer than 14 characters. Length of 14 characters is decided keeping in mind of "Ambari Metrics" since it is the longest service name in trunk.
> I have also added tooltip (using Ember's "bindattr" with "title", as I found this being used in other places of the code as well) to display the entire Service Name for all components.
>
> I have attached a screenshot "Service names with ellipses and tooltip.tiff" to show how long service names would look like with the updated fix in patch-3
> (Note: This image was taken while testing where I had used 13 characters limit only)
>
> Please let me know if I could make further improvements.
> Thanks!
Hello Keta,
That's very close. Can both component name and service name be set to a fixed number of chars and with flyout ? The real estate on host page is limited and need to save room for the widgets, buttons, etc.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122388
-----------------------------------------------------------
On March 8, 2016, 7:26 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 7:26 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122388
-----------------------------------------------------------
ambari-web/app/templates/main/host/details/host_component.hbs (line 30)
<https://reviews.apache.org/r/44457/#comment184359>
How is the service name displayed when the component name is extra long, in relation to the new divs added ?
The service name should be visible so that user can navigate back to the corresponding service.
What about fixing the width of the component name and trancate it with ... when it reaches the limite.
For example, ExtraLongZookeeperComponentName would be dispalyed as
ExtraLongZook.../Zookeeper
The ExtraLongZookeeperComponentName is still displayed on zookeeper's dashboard where user can hover over to reveal the host name, yes ?
- Di Li
On March 7, 2016, 9:57 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 9:57 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 7, 2016, 10:03 p.m., Alejandro Fernandez wrote:
> > ambari-web/app/templates/main/host/summary.hbs, line 71
> > <https://reviews.apache.org/r/44457/diff/1/?file=1283160#file1283160line71>
> >
> > In the image for "Updated Fix (Mar-07).tiff" the component name of "ZOOKEEPER SERVER" is missing.
Hello Alexandr,
I was testing the length for long component names and I updated the "Zookeeper" text with ".........................." as you can see in the line below "Zookeeper Server".
There was also a space added following component names in the original code, which I removed (you can see how the dots stop right at the right border of the <div> block). This space was originally added to separate the name from the icons appearing after it. Since we are providing <div> blocks to each of the elements, I have added padding in the medkit-icon-block to adjust this spacing.
Thanks!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122386
-----------------------------------------------------------
On March 7, 2016, 9:57 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 9:57 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122386
-----------------------------------------------------------
ambari-web/app/templates/main/host/summary.hbs (line 71)
<https://reviews.apache.org/r/44457/#comment184355>
In the image for "Updated Fix (Mar-07).tiff" the component name of "ZOOKEEPER SERVER" is missing.
- Alejandro Fernandez
On March 7, 2016, 9:57 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 9:57 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 7, 2016, 10:24 p.m., Di Li wrote:
> > ambari-web/app/templates/main/host/details/host_component.hbs, line 40
> > <https://reviews.apache.org/r/44457/diff/1/?file=1283159#file1283159line40>
> >
> > In additional to a fixed width (number of chars) field, it'd also be much more flexible to use a flyout. User simply mouses over the component name and the flyout appears with the fullname. User mouses away from the component name, the flyout disappears.
Hello Di,
I am looking into this issue of using flyout.
Thanks!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122390
-----------------------------------------------------------
On March 7, 2016, 9:57 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 9:57 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122390
-----------------------------------------------------------
ambari-web/app/templates/main/host/details/host_component.hbs (line 40)
<https://reviews.apache.org/r/44457/#comment184361>
In additional to a fixed width (number of chars) field, it'd also be much more flexible to use a flyout. User simply mouses over the component name and the flyout appears with the fullname. User mouses away from the component name, the flyout disappears.
- Di Li
On March 7, 2016, 9:57 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 9:57 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 10, 2016, 7:01 p.m., Di Li wrote:
> > File Attachment: AMBARI-15310 (patch-4) - AMBARI-15310_Mar09.patch
> > <https://reviews.apache.org/r/44457/#fcomment92>
> >
> > Could you please add unit tests for the methods you added, if possible, to demo the text shortening behavior that you implemented?
Hello Di,
Thank you for this comment. I have added the tests in the patch "AMBARI-15310_Mar10.patch" (patch-5).
The following is the ambari-web test result for the Original trunk:
24564 tests complete (41 seconds)
145 tests pending
The following is the ambari-web test result with the patch (9 new tests).
24573 tests complete (27 seconds)
145 tests pending
Please let me know if further changes are required.
Thanks!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122960
-----------------------------------------------------------
On March 11, 2016, 8:08 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 8:08 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
> AMBARI-15310 (patch-5)
> https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122960
-----------------------------------------------------------
File Attachment: AMBARI-15310 (patch-4) - AMBARI-15310_Mar09.patch
<https://reviews.apache.org//r/44457/#fcomment91>
Could you please add unit tests for the methods you added, if possible, to demo the text shortening behavior that you implemented?
- Di Li
On March 10, 2016, 12:08 a.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 12:08 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
-----------------------------------------------------------
(Updated March 15, 2016, 4:07 p.m.)
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310
Repository: ambari
Description
-------
In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
Also, note the indentation of the last button for Clients does not align well with the buttons above it.
Diffs (updated)
-----
ambari-web/app/models/host_component.js a325113
ambari-web/app/styles/application.less 755dff2
ambari-web/app/templates/main/host/details/host_component.hbs 60031de
ambari-web/app/templates/main/host/summary.hbs 11b4861
ambari-web/test/models/host_component_test.js 202f5c5
Diff: https://reviews.apache.org/r/44457/diff/
Testing
-------
FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
TESTS:
No tests are written for these changes as the fix involves updates in the stylesheet.
However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
The following is the result of running ambari-web tests:
24565 tests complete (28 seconds)
145 tests pending
File Attachments
----------------
AMBARI-15310 (patch-2)
https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
AMBARI-15310 (patch-3)
https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
AMBARI-15310 (patch-4)
https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
AMBARI-15310 (patch-5)
https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
Thanks,
Keta Patel
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Di Li <di...@ca.ibm.com>.
> On March 14, 2016, 5:47 p.m., Di Li wrote:
> > Ship It!
>
> Keta Patel wrote:
> Thank you Di!
can you reattach the latest build via the "Update Diff" option? Your AMBARI-15310_Mar10.patch is not up to download via review board.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review123464
-----------------------------------------------------------
On March 11, 2016, 8:08 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 8:08 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
> AMBARI-15310 (patch-5)
> https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 14, 2016, 5:47 p.m., Di Li wrote:
> > Ship It!
>
> Keta Patel wrote:
> Thank you Di!
>
> Di Li wrote:
> can you reattach the latest build via the "Update Diff" option? Your AMBARI-15310_Mar10.patch is not up to download via review board.
Hello Di,
I have attached the latest patch in "Update Diff".
Thank you!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review123464
-----------------------------------------------------------
On March 15, 2016, 4:07 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 4:07 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/models/host_component.js a325113
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 11b4861
> ambari-web/test/models/host_component_test.js 202f5c5
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
> AMBARI-15310 (patch-5)
> https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 14, 2016, 5:47 p.m., Di Li wrote:
> > Ship It!
Thank you Di!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review123464
-----------------------------------------------------------
On March 11, 2016, 8:08 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 8:08 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
> AMBARI-15310 (patch-5)
> https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review123464
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On March 11, 2016, 8:08 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 8:08 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
> AMBARI-15310 (patch-5)
> https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
-----------------------------------------------------------
(Updated March 11, 2016, 8:08 p.m.)
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310
Repository: ambari
Description
-------
In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
Also, note the indentation of the last button for Clients does not align well with the buttons above it.
Diffs
-----
ambari-web/app/styles/application.less 755dff2
ambari-web/app/templates/main/host/details/host_component.hbs 60031de
ambari-web/app/templates/main/host/summary.hbs 17a0b69
Diff: https://reviews.apache.org/r/44457/diff/
Testing
-------
FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
TESTS:
No tests are written for these changes as the fix involves updates in the stylesheet.
However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
The following is the result of running ambari-web tests:
24565 tests complete (28 seconds)
145 tests pending
File Attachments (updated)
----------------
AMBARI-15310 (patch-2)
https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
AMBARI-15310 (patch-3)
https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
AMBARI-15310 (patch-4)
https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
AMBARI-15310 (patch-5)
https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
Thanks,
Keta Patel
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
-----------------------------------------------------------
(Updated March 10, 2016, 12:08 a.m.)
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310
Repository: ambari
Description
-------
In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
Also, note the indentation of the last button for Clients does not align well with the buttons above it.
Diffs
-----
ambari-web/app/styles/application.less 755dff2
ambari-web/app/templates/main/host/details/host_component.hbs 60031de
ambari-web/app/templates/main/host/summary.hbs 17a0b69
Diff: https://reviews.apache.org/r/44457/diff/
Testing
-------
FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
TESTS:
No tests are written for these changes as the fix involves updates in the stylesheet.
However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
The following is the result of running ambari-web tests:
24565 tests complete (28 seconds)
145 tests pending
File Attachments (updated)
----------------
AMBARI-15310 (patch-2)
https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
AMBARI-15310 (patch-3)
https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
AMBARI-15310 (patch-4)
https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
Thanks,
Keta Patel
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
-----------------------------------------------------------
(Updated March 8, 2016, 7:26 p.m.)
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310
Repository: ambari
Description
-------
In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
Also, note the indentation of the last button for Clients does not align well with the buttons above it.
Diffs
-----
ambari-web/app/styles/application.less 755dff2
ambari-web/app/templates/main/host/details/host_component.hbs 60031de
ambari-web/app/templates/main/host/summary.hbs 17a0b69
Diff: https://reviews.apache.org/r/44457/diff/
Testing
-------
FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
TESTS:
No tests are written for these changes as the fix involves updates in the stylesheet.
However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
The following is the result of running ambari-web tests:
24565 tests complete (28 seconds)
145 tests pending
File Attachments (updated)
----------------
AMBARI-15310 (patch-2)
https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
AMBARI-15310 (patch-3)
https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
Thanks,
Keta Patel
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
-----------------------------------------------------------
(Updated March 7, 2016, 9:57 p.m.)
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310
Repository: ambari
Description
-------
In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
Also, note the indentation of the last button for Clients does not align well with the buttons above it.
Diffs
-----
ambari-web/app/styles/application.less 755dff2
ambari-web/app/templates/main/host/details/host_component.hbs 60031de
ambari-web/app/templates/main/host/summary.hbs 17a0b69
Diff: https://reviews.apache.org/r/44457/diff/
Testing (updated)
-------
FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
TESTS:
No tests are written for these changes as the fix involves updates in the stylesheet.
However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
The following is the result of running ambari-web tests:
24565 tests complete (28 seconds)
145 tests pending
File Attachments (updated)
----------------
AMBARI-15310 (patch-2)
https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
Thanks,
Keta Patel
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 7, 2016, 7:49 p.m., Alexandr Antonenko wrote:
> > Ship It!
Hello Alexandr,
I have updated the patch with some more minor changes that I found while zooming in.
Kindly please have a look at the final updated patch labeled "AMBARI-15310 (patch-2)".
Thank you!
Keta
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122361
-----------------------------------------------------------
On March 7, 2016, 9:57 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 9:57 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122361
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On March 7, 2016, 4:59 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 4:59 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
>
>
> Thanks,
>
> Keta Patel
>
>