You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Jan van der Lugt (JIRA)" <ji...@apache.org> on 2012/08/28 19:14:08 UTC

[jira] [Created] (AVRO-1143) avrogencpp generates $Undefined$ for some union types

Jan van der Lugt created AVRO-1143:
--------------------------------------

             Summary: avrogencpp generates $Undefined$ for some union types
                 Key: AVRO-1143
                 URL: https://issues.apache.org/jira/browse/AVRO-1143
             Project: Avro
          Issue Type: Bug
          Components: c++
    Affects Versions: 1.7.1
            Reporter: Jan van der Lugt


When converting the attached file to a C++ header, a vector of type $Undefined$ is generated. I believe this is because there is no check for AVRO_UNION in CodeGen::cppTypeOf().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AVRO-1143) avrogencpp generates $Undefined$ for some union types

Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvalluvan M. G. updated AVRO-1143:
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.7.2
           Status: Resolved  (was: Patch Available)

Committed revision 1382397.

Thank you Jan van der Lugt for verifying the fix.
                
> avrogencpp generates $Undefined$ for some union types
> -----------------------------------------------------
>
>                 Key: AVRO-1143
>                 URL: https://issues.apache.org/jira/browse/AVRO-1143
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.1
>            Reporter: Jan van der Lugt
>            Assignee: Thiruvalluvan M. G.
>             Fix For: 1.7.2
>
>         Attachments: AVRO-1143.patch, gm_avro_graph.avpr
>
>
> When converting the attached file to a C++ header, a vector of type $Undefined$ is generated. I believe this is because there is no check for AVRO_UNION in CodeGen::cppTypeOf().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AVRO-1143) avrogencpp generates $Undefined$ for some union types

Posted by "Jan van der Lugt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450984#comment-13450984 ] 

Jan van der Lugt commented on AVRO-1143:
----------------------------------------

No problem. It seems to work for my example, thanks a lot!
                
> avrogencpp generates $Undefined$ for some union types
> -----------------------------------------------------
>
>                 Key: AVRO-1143
>                 URL: https://issues.apache.org/jira/browse/AVRO-1143
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.1
>            Reporter: Jan van der Lugt
>            Assignee: Thiruvalluvan M. G.
>         Attachments: AVRO-1143.patch, gm_avro_graph.avpr
>
>
> When converting the attached file to a C++ header, a vector of type $Undefined$ is generated. I believe this is because there is no check for AVRO_UNION in CodeGen::cppTypeOf().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AVRO-1143) avrogencpp generates $Undefined$ for some union types

Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvalluvan M. G. updated AVRO-1143:
--------------------------------------

    Assignee: Thiruvalluvan M. G.
      Status: Patch Available  (was: Open)
    
> avrogencpp generates $Undefined$ for some union types
> -----------------------------------------------------
>
>                 Key: AVRO-1143
>                 URL: https://issues.apache.org/jira/browse/AVRO-1143
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.1
>            Reporter: Jan van der Lugt
>            Assignee: Thiruvalluvan M. G.
>         Attachments: AVRO-1143.patch, gm_avro_graph.avpr
>
>
> When converting the attached file to a C++ header, a vector of type $Undefined$ is generated. I believe this is because there is no check for AVRO_UNION in CodeGen::cppTypeOf().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AVRO-1143) avrogencpp generates $Undefined$ for some union types

Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446102#comment-13446102 ] 

Scott Carey commented on AVRO-1143:
-----------------------------------

Thiru, any idea on the best way forward here?
                
> avrogencpp generates $Undefined$ for some union types
> -----------------------------------------------------
>
>                 Key: AVRO-1143
>                 URL: https://issues.apache.org/jira/browse/AVRO-1143
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.1
>            Reporter: Jan van der Lugt
>         Attachments: gm_avro_graph.avpr
>
>
> When converting the attached file to a C++ header, a vector of type $Undefined$ is generated. I believe this is because there is no check for AVRO_UNION in CodeGen::cppTypeOf().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AVRO-1143) avrogencpp generates $Undefined$ for some union types

Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvalluvan M. G. updated AVRO-1143:
--------------------------------------

    Attachment: AVRO-1143.patch

Good catch. Attached patch has a modified test that catches the problem and the fix for the problem.

I'm sorry I couldn't resolve the issue earlier.
                
> avrogencpp generates $Undefined$ for some union types
> -----------------------------------------------------
>
>                 Key: AVRO-1143
>                 URL: https://issues.apache.org/jira/browse/AVRO-1143
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.1
>            Reporter: Jan van der Lugt
>         Attachments: AVRO-1143.patch, gm_avro_graph.avpr
>
>
> When converting the attached file to a C++ header, a vector of type $Undefined$ is generated. I believe this is because there is no check for AVRO_UNION in CodeGen::cppTypeOf().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AVRO-1143) avrogencpp generates $Undefined$ for some union types

Posted by "Jan van der Lugt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan van der Lugt updated AVRO-1143:
-----------------------------------

    Attachment: gm_avro_graph.avpr
    
> avrogencpp generates $Undefined$ for some union types
> -----------------------------------------------------
>
>                 Key: AVRO-1143
>                 URL: https://issues.apache.org/jira/browse/AVRO-1143
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.1
>            Reporter: Jan van der Lugt
>         Attachments: gm_avro_graph.avpr
>
>
> When converting the attached file to a C++ header, a vector of type $Undefined$ is generated. I believe this is because there is no check for AVRO_UNION in CodeGen::cppTypeOf().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira