You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2023/05/13 03:05:33 UTC
[GitHub] [yunikorn-core] zhuqi-lucas opened a new pull request, #546: [YUNIKORN-1737] Originator flag for AllocationAskDAOInfo don't assign for construct in getAllocationAskDAO.
zhuqi-lucas opened a new pull request, #546:
URL: https://github.com/apache/yunikorn-core/pull/546
### What is this PR for?
We have Originator flag in the AllocationAskDAOInfo for restAPI.
But we don't assign the value for getAllocationAskDAO.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1737
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #546: [YUNIKORN-1737] Originator flag for AllocationAskDAOInfo don't assign for construct in getAllocationAskDAO.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #546:
URL: https://github.com/apache/yunikorn-core/pull/546#issuecomment-1546508682
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#546](https://app.codecov.io/gh/apache/yunikorn-core/pull/546?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (da227df) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/836948e3f5b276a33d42b7d587547224dc56c296?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (836948e) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #546 +/- ##
=======================================
Coverage 74.96% 74.96%
=======================================
Files 70 70
Lines 11366 11367 +1
=======================================
+ Hits 8520 8521 +1
Misses 2545 2545
Partials 301 301
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/webservice/handlers.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `80.15% <100.00%> (+0.02%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] 0yukali0 merged pull request #546: [YUNIKORN-1737] Originator flag for AllocationAskDAOInfo don't assign for construct in getAllocationAskDAO.
Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 merged PR #546:
URL: https://github.com/apache/yunikorn-core/pull/546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org