You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/14 17:22:14 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28528: [SPARK-31711][CORE] Register the executor source with the metrics system when running in local mode.

dongjoon-hyun commented on a change in pull request #28528:
URL: https://github.com/apache/spark/pull/28528#discussion_r425306152



##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -803,6 +803,13 @@ package object config {
       .booleanConf
       .createWithDefault(true)
 
+  private[spark] val METRICS_EXECUTOR_SOURCE_ENABLED =
+    ConfigBuilder("spark.metrics.executorSource.enabled")

Review comment:
       Hi, @LucaCanali .
   This is a completely orthogonal topic from the PR title, `Register the executor source with the metrics system when running in local mode`. Could you make a separate PR for this first?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org