You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by jkff <gi...@git.apache.org> on 2017/07/19 19:16:10 UTC

[GitHub] beam pull request #3598: [BEAM-2640, BEAM-2641] Introduces TextIO.read().wit...

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/3598

    [BEAM-2640, BEAM-2641] Introduces TextIO.read().withHintMatchesManyFiles()

    In that case it expands to TextIO.readAll(). Implementing this when the filepattern is a ValueProvider nudged me to also implement BEAM-2640 - Create.ofProvider(ValueProvider).
    
    Links:
    https://issues.apache.org/jira/browse/BEAM-2640
    https://issues.apache.org/jira/browse/BEAM-2641
    
    R: @reuvenlax 
    CC: @sammcveety 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam textio-readall

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3598
    
----
commit d26416d142808d8279c40cd57a659e103b296f3f
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-07-19T18:50:58Z

    [BEAM-2640] Introduces Create.ofProvider(ValueProvider)
    
    I also converted DatastoreV1 to use this overload, and, as an
    exercise, added a withQuery(ValueProvider) overload to JdbcIO.

commit 872f0df5c227385bc95a42ecc02934a4082565ba
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-07-19T18:51:33Z

    [BEAM-2641] Introduces TextIO.read().withHintMatchesManyFiles()
    
    In that case it expands to TextIO.readAll().

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #3598: [BEAM-2640, BEAM-2641] Introduces TextIO.read().wit...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3598


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---