You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2013/03/22 03:52:24 UTC
Review Request: Temporarily disabling baremetal functionality in CS 4.1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10071/
-----------------------------------------------------------
Review request for cloudstack, Kelven Yang and Frank Zhang.
Description
-------
Temporarily disabling baremetal functionality in CS 4.1
This addresses bug CS-1773.
Diffs
-----
client/tomcatconf/componentContext.xml.in ff7376e
client/tomcatconf/nonossComponentContext.xml.in 35e1b28
server/src/com/cloud/configuration/Config.java 17fe62b
Diff: https://reviews.apache.org/r/10071/diff/
Testing
-------
Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
Thanks,
Venkata Siva Vijayendra Bhamidipati
Re: Review Request: Temporarily disabling baremetal functionality in CS 4.1
Posted by Animesh Chaturvedi <An...@citrix.com>.
> On March 24, 2013, 6:08 p.m., Chip Childers wrote:
> > This patch still doesn't apply cleanly. Now sure what's going on. Please test with a fresh copy of the 4.1 branch to ensure that it's a clean patch.
> >
> > git am ~/patches/10071.patch
> > Applying: CS-1773: Disable baremetal functionality
> > error: patch failed: server/src/com/cloud/configuration/Config.java:359
> > error: server/src/com/cloud/configuration/Config.java: patch does not apply
> > Patch failed at 0001 CS-1773: Disable baremetal functionality
Min applied the patch, closing the review
- Animesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10071/#review18329
-----------------------------------------------------------
On March 22, 2013, 11:55 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10071/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 11:55 p.m.)
>
>
> Review request for cloudstack, Kelven Yang and Frank Zhang.
>
>
> Description
> -------
>
> Temporarily disabling baremetal functionality in CS 4.1
>
>
> This addresses bug CS-1773.
>
>
> Diffs
> -----
>
> client/pom.xml 38ba405
> client/tomcatconf/componentContext.xml.in ff7376e
> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
> plugins/pom.xml 02459b4
> server/src/com/cloud/configuration/Config.java 17fe62b
> setup/db/db/schema-40to410.sql 754bfb6
>
> Diff: https://reviews.apache.org/r/10071/diff/
>
>
> Testing
> -------
>
> Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request: Temporarily disabling baremetal functionality in
CS 4.1
Posted by Chip Childers <ch...@sungard.com>.
On Mon, Mar 25, 2013 at 11:39:10AM -0700, Min Chen wrote:
> Hi Chip,
>
> FYI. I also cannot use "git am" to apply this patch, it can only be
> applied through "git apply", not sure why. Also, the patch downloaded from
> review board cannot be applied even through "git apply". Vijay gave me his
> patch last Friday, and I can apply that one using "git apply" and mvn
> build is successful. I have committed that patch to 4.1.
OK - Thanks Min!
>
> Thanks
> -min
>
> On 3/25/13 9:36 AM, "Chip Childers" <ch...@sungard.com> wrote:
>
> >On Mon, Mar 25, 2013 at 09:33:38AM -0700, Animesh Chaturvedi wrote:
> >>
> >>
> >> > -----Original Message-----
> >> > From: Chip Childers [mailto:chip.childers@sungard.com]
> >> > Sent: Monday, March 25, 2013 8:15 AM
> >> > To: Animesh Chaturvedi
> >> > Cc: dev@cloudstack.apache.org; Frank Zhang; Kelven Yang; cloudstack;
> >> > Vijayendra Bhamidipati
> >> > Subject: Re: Review Request: Temporarily disabling baremetal
> >>functionality in
> >> > CS 4.1
> >> >
> >> > On Mon, Mar 25, 2013 at 08:12:52AM -0700, Animesh Chaturvedi wrote:
> >> > > Vijay
> >> > >
> >> > > Can you check this again with a new workspace? Chip both Min and I
> >>had
> >> > verified on Friday that patch was applying before Vijay posted it. I
> >>will also try
> >> > again with fresh 4.1. Sorry for the inconvenience.
> >> >
> >> > I did a "git fetch origin; git checkout 4.1; git reset --hard
> >>origin/4.1" before "git
> >> > am ...". I don't quite get what the conflict is.
> >> >
> >> > Try the process above, including the git am using the patch available
> >>within
> >> > the review. Perhaps the posting process is mangling things?
> >> >
> >> [Animesh>] Sure Chip, we will try again and try to close it soon
> >
> >Animesh,
> >
> >If you can get a clean "git am", and the system builds, you can go ahead
> >and push the commit to origin/4.1. I'm not trying to get in the way of
> >getting the commits into the branch... just to confirm that things are
> >going in cleanly and that the build continues to work (and that only
> >appropriate changes are made).
> >
> >> >
> >> > >
> >> > > Thanks
> >> > > Animesh
> >> > >
> >> > > On Mar 24, 2013, at 11:08 AM, "Chip Childers"
> >> > <ch...@sungard.com> wrote:
> >> > >
> >> > > >
> >> > > > -----------------------------------------------------------
> >> > > > This is an automatically generated e-mail. To reply, visit:
> >> > > > https://reviews.apache.org/r/10071/#review18329
> >> > > > -----------------------------------------------------------
> >> > > >
> >> > > >
> >> > > > This patch still doesn't apply cleanly. Now sure what's going
> >>on. Please
> >> > test with a fresh copy of the 4.1 branch to ensure that it's a clean
> >>patch.
> >> > > >
> >> > > > git am ~/patches/10071.patch
> >> > > > Applying: CS-1773: Disable baremetal functionality
> >> > > > error: patch failed:
> >> > > > server/src/com/cloud/configuration/Config.java:359
> >> > > > error: server/src/com/cloud/configuration/Config.java: patch does
> >> > > > not apply Patch failed at 0001 CS-1773: Disable baremetal
> >> > > > functionality
> >> > > >
> >> > > > - Chip Childers
> >> > > >
> >> > > >
> >> > > > On March 22, 2013, 11:55 p.m., Venkata Siva Vijayendra Bhamidipati
> >> > wrote:
> >> > > >>
> >> > > >> -----------------------------------------------------------
> >> > > >> This is an automatically generated e-mail. To reply, visit:
> >> > > >> https://reviews.apache.org/r/10071/
> >> > > >> -----------------------------------------------------------
> >> > > >>
> >> > > >> (Updated March 22, 2013, 11:55 p.m.)
> >> > > >>
> >> > > >>
> >> > > >> Review request for cloudstack, Kelven Yang and Frank Zhang.
> >> > > >>
> >> > > >>
> >> > > >> Description
> >> > > >> -------
> >> > > >>
> >> > > >> Temporarily disabling baremetal functionality in CS 4.1
> >> > > >>
> >> > > >>
> >> > > >> This addresses bug CS-1773.
> >> > > >>
> >> > > >>
> >> > > >> Diffs
> >> > > >> -----
> >> > > >>
> >> > > >> client/pom.xml 38ba405
> >> > > >> client/tomcatconf/componentContext.xml.in ff7376e
> >> > > >> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
> >> > > >> plugins/pom.xml 02459b4
> >> > > >> server/src/com/cloud/configuration/Config.java 17fe62b
> >> > > >> setup/db/db/schema-40to410.sql 754bfb6
> >> > > >>
> >> > > >> Diff: https://reviews.apache.org/r/10071/diff/
> >> > > >>
> >> > > >>
> >> > > >> Testing
> >> > > >> -------
> >> > > >>
> >> > > >> Baremetal and Cisco UCS related APIs confirmed to not be exposed
> >>to
> >> > clients.
> >> > > >>
> >> > > >>
> >> > > >> Thanks,
> >> > > >>
> >> > > >> Venkata Siva Vijayendra Bhamidipati
> >> > > >
> >> > >
> >>
>
>
Re: Review Request: Temporarily disabling baremetal functionality
in CS 4.1
Posted by Min Chen <mi...@citrix.com>.
Hi Chip,
FYI. I also cannot use "git am" to apply this patch, it can only be
applied through "git apply", not sure why. Also, the patch downloaded from
review board cannot be applied even through "git apply". Vijay gave me his
patch last Friday, and I can apply that one using "git apply" and mvn
build is successful. I have committed that patch to 4.1.
Thanks
-min
On 3/25/13 9:36 AM, "Chip Childers" <ch...@sungard.com> wrote:
>On Mon, Mar 25, 2013 at 09:33:38AM -0700, Animesh Chaturvedi wrote:
>>
>>
>> > -----Original Message-----
>> > From: Chip Childers [mailto:chip.childers@sungard.com]
>> > Sent: Monday, March 25, 2013 8:15 AM
>> > To: Animesh Chaturvedi
>> > Cc: dev@cloudstack.apache.org; Frank Zhang; Kelven Yang; cloudstack;
>> > Vijayendra Bhamidipati
>> > Subject: Re: Review Request: Temporarily disabling baremetal
>>functionality in
>> > CS 4.1
>> >
>> > On Mon, Mar 25, 2013 at 08:12:52AM -0700, Animesh Chaturvedi wrote:
>> > > Vijay
>> > >
>> > > Can you check this again with a new workspace? Chip both Min and I
>>had
>> > verified on Friday that patch was applying before Vijay posted it. I
>>will also try
>> > again with fresh 4.1. Sorry for the inconvenience.
>> >
>> > I did a "git fetch origin; git checkout 4.1; git reset --hard
>>origin/4.1" before "git
>> > am ...". I don't quite get what the conflict is.
>> >
>> > Try the process above, including the git am using the patch available
>>within
>> > the review. Perhaps the posting process is mangling things?
>> >
>> [Animesh>] Sure Chip, we will try again and try to close it soon
>
>Animesh,
>
>If you can get a clean "git am", and the system builds, you can go ahead
>and push the commit to origin/4.1. I'm not trying to get in the way of
>getting the commits into the branch... just to confirm that things are
>going in cleanly and that the build continues to work (and that only
>appropriate changes are made).
>
>> >
>> > >
>> > > Thanks
>> > > Animesh
>> > >
>> > > On Mar 24, 2013, at 11:08 AM, "Chip Childers"
>> > <ch...@sungard.com> wrote:
>> > >
>> > > >
>> > > > -----------------------------------------------------------
>> > > > This is an automatically generated e-mail. To reply, visit:
>> > > > https://reviews.apache.org/r/10071/#review18329
>> > > > -----------------------------------------------------------
>> > > >
>> > > >
>> > > > This patch still doesn't apply cleanly. Now sure what's going
>>on. Please
>> > test with a fresh copy of the 4.1 branch to ensure that it's a clean
>>patch.
>> > > >
>> > > > git am ~/patches/10071.patch
>> > > > Applying: CS-1773: Disable baremetal functionality
>> > > > error: patch failed:
>> > > > server/src/com/cloud/configuration/Config.java:359
>> > > > error: server/src/com/cloud/configuration/Config.java: patch does
>> > > > not apply Patch failed at 0001 CS-1773: Disable baremetal
>> > > > functionality
>> > > >
>> > > > - Chip Childers
>> > > >
>> > > >
>> > > > On March 22, 2013, 11:55 p.m., Venkata Siva Vijayendra Bhamidipati
>> > wrote:
>> > > >>
>> > > >> -----------------------------------------------------------
>> > > >> This is an automatically generated e-mail. To reply, visit:
>> > > >> https://reviews.apache.org/r/10071/
>> > > >> -----------------------------------------------------------
>> > > >>
>> > > >> (Updated March 22, 2013, 11:55 p.m.)
>> > > >>
>> > > >>
>> > > >> Review request for cloudstack, Kelven Yang and Frank Zhang.
>> > > >>
>> > > >>
>> > > >> Description
>> > > >> -------
>> > > >>
>> > > >> Temporarily disabling baremetal functionality in CS 4.1
>> > > >>
>> > > >>
>> > > >> This addresses bug CS-1773.
>> > > >>
>> > > >>
>> > > >> Diffs
>> > > >> -----
>> > > >>
>> > > >> client/pom.xml 38ba405
>> > > >> client/tomcatconf/componentContext.xml.in ff7376e
>> > > >> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
>> > > >> plugins/pom.xml 02459b4
>> > > >> server/src/com/cloud/configuration/Config.java 17fe62b
>> > > >> setup/db/db/schema-40to410.sql 754bfb6
>> > > >>
>> > > >> Diff: https://reviews.apache.org/r/10071/diff/
>> > > >>
>> > > >>
>> > > >> Testing
>> > > >> -------
>> > > >>
>> > > >> Baremetal and Cisco UCS related APIs confirmed to not be exposed
>>to
>> > clients.
>> > > >>
>> > > >>
>> > > >> Thanks,
>> > > >>
>> > > >> Venkata Siva Vijayendra Bhamidipati
>> > > >
>> > >
>>
Re: Review Request: Temporarily disabling baremetal functionality in
CS 4.1
Posted by Chip Childers <ch...@sungard.com>.
On Mon, Mar 25, 2013 at 09:33:38AM -0700, Animesh Chaturvedi wrote:
>
>
> > -----Original Message-----
> > From: Chip Childers [mailto:chip.childers@sungard.com]
> > Sent: Monday, March 25, 2013 8:15 AM
> > To: Animesh Chaturvedi
> > Cc: dev@cloudstack.apache.org; Frank Zhang; Kelven Yang; cloudstack;
> > Vijayendra Bhamidipati
> > Subject: Re: Review Request: Temporarily disabling baremetal functionality in
> > CS 4.1
> >
> > On Mon, Mar 25, 2013 at 08:12:52AM -0700, Animesh Chaturvedi wrote:
> > > Vijay
> > >
> > > Can you check this again with a new workspace? Chip both Min and I had
> > verified on Friday that patch was applying before Vijay posted it. I will also try
> > again with fresh 4.1. Sorry for the inconvenience.
> >
> > I did a "git fetch origin; git checkout 4.1; git reset --hard origin/4.1" before "git
> > am ...". I don't quite get what the conflict is.
> >
> > Try the process above, including the git am using the patch available within
> > the review. Perhaps the posting process is mangling things?
> >
> [Animesh>] Sure Chip, we will try again and try to close it soon
Animesh,
If you can get a clean "git am", and the system builds, you can go ahead
and push the commit to origin/4.1. I'm not trying to get in the way of
getting the commits into the branch... just to confirm that things are
going in cleanly and that the build continues to work (and that only
appropriate changes are made).
> >
> > >
> > > Thanks
> > > Animesh
> > >
> > > On Mar 24, 2013, at 11:08 AM, "Chip Childers"
> > <ch...@sungard.com> wrote:
> > >
> > > >
> > > > -----------------------------------------------------------
> > > > This is an automatically generated e-mail. To reply, visit:
> > > > https://reviews.apache.org/r/10071/#review18329
> > > > -----------------------------------------------------------
> > > >
> > > >
> > > > This patch still doesn't apply cleanly. Now sure what's going on. Please
> > test with a fresh copy of the 4.1 branch to ensure that it's a clean patch.
> > > >
> > > > git am ~/patches/10071.patch
> > > > Applying: CS-1773: Disable baremetal functionality
> > > > error: patch failed:
> > > > server/src/com/cloud/configuration/Config.java:359
> > > > error: server/src/com/cloud/configuration/Config.java: patch does
> > > > not apply Patch failed at 0001 CS-1773: Disable baremetal
> > > > functionality
> > > >
> > > > - Chip Childers
> > > >
> > > >
> > > > On March 22, 2013, 11:55 p.m., Venkata Siva Vijayendra Bhamidipati
> > wrote:
> > > >>
> > > >> -----------------------------------------------------------
> > > >> This is an automatically generated e-mail. To reply, visit:
> > > >> https://reviews.apache.org/r/10071/
> > > >> -----------------------------------------------------------
> > > >>
> > > >> (Updated March 22, 2013, 11:55 p.m.)
> > > >>
> > > >>
> > > >> Review request for cloudstack, Kelven Yang and Frank Zhang.
> > > >>
> > > >>
> > > >> Description
> > > >> -------
> > > >>
> > > >> Temporarily disabling baremetal functionality in CS 4.1
> > > >>
> > > >>
> > > >> This addresses bug CS-1773.
> > > >>
> > > >>
> > > >> Diffs
> > > >> -----
> > > >>
> > > >> client/pom.xml 38ba405
> > > >> client/tomcatconf/componentContext.xml.in ff7376e
> > > >> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
> > > >> plugins/pom.xml 02459b4
> > > >> server/src/com/cloud/configuration/Config.java 17fe62b
> > > >> setup/db/db/schema-40to410.sql 754bfb6
> > > >>
> > > >> Diff: https://reviews.apache.org/r/10071/diff/
> > > >>
> > > >>
> > > >> Testing
> > > >> -------
> > > >>
> > > >> Baremetal and Cisco UCS related APIs confirmed to not be exposed to
> > clients.
> > > >>
> > > >>
> > > >> Thanks,
> > > >>
> > > >> Venkata Siva Vijayendra Bhamidipati
> > > >
> > >
>
RE: Review Request: Temporarily disabling baremetal functionality
in CS 4.1
Posted by Animesh Chaturvedi <an...@citrix.com>.
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Monday, March 25, 2013 8:15 AM
> To: Animesh Chaturvedi
> Cc: dev@cloudstack.apache.org; Frank Zhang; Kelven Yang; cloudstack;
> Vijayendra Bhamidipati
> Subject: Re: Review Request: Temporarily disabling baremetal functionality in
> CS 4.1
>
> On Mon, Mar 25, 2013 at 08:12:52AM -0700, Animesh Chaturvedi wrote:
> > Vijay
> >
> > Can you check this again with a new workspace? Chip both Min and I had
> verified on Friday that patch was applying before Vijay posted it. I will also try
> again with fresh 4.1. Sorry for the inconvenience.
>
> I did a "git fetch origin; git checkout 4.1; git reset --hard origin/4.1" before "git
> am ...". I don't quite get what the conflict is.
>
> Try the process above, including the git am using the patch available within
> the review. Perhaps the posting process is mangling things?
>
[Animesh>] Sure Chip, we will try again and try to close it soon
>
> >
> > Thanks
> > Animesh
> >
> > On Mar 24, 2013, at 11:08 AM, "Chip Childers"
> <ch...@sungard.com> wrote:
> >
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/10071/#review18329
> > > -----------------------------------------------------------
> > >
> > >
> > > This patch still doesn't apply cleanly. Now sure what's going on. Please
> test with a fresh copy of the 4.1 branch to ensure that it's a clean patch.
> > >
> > > git am ~/patches/10071.patch
> > > Applying: CS-1773: Disable baremetal functionality
> > > error: patch failed:
> > > server/src/com/cloud/configuration/Config.java:359
> > > error: server/src/com/cloud/configuration/Config.java: patch does
> > > not apply Patch failed at 0001 CS-1773: Disable baremetal
> > > functionality
> > >
> > > - Chip Childers
> > >
> > >
> > > On March 22, 2013, 11:55 p.m., Venkata Siva Vijayendra Bhamidipati
> wrote:
> > >>
> > >> -----------------------------------------------------------
> > >> This is an automatically generated e-mail. To reply, visit:
> > >> https://reviews.apache.org/r/10071/
> > >> -----------------------------------------------------------
> > >>
> > >> (Updated March 22, 2013, 11:55 p.m.)
> > >>
> > >>
> > >> Review request for cloudstack, Kelven Yang and Frank Zhang.
> > >>
> > >>
> > >> Description
> > >> -------
> > >>
> > >> Temporarily disabling baremetal functionality in CS 4.1
> > >>
> > >>
> > >> This addresses bug CS-1773.
> > >>
> > >>
> > >> Diffs
> > >> -----
> > >>
> > >> client/pom.xml 38ba405
> > >> client/tomcatconf/componentContext.xml.in ff7376e
> > >> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
> > >> plugins/pom.xml 02459b4
> > >> server/src/com/cloud/configuration/Config.java 17fe62b
> > >> setup/db/db/schema-40to410.sql 754bfb6
> > >>
> > >> Diff: https://reviews.apache.org/r/10071/diff/
> > >>
> > >>
> > >> Testing
> > >> -------
> > >>
> > >> Baremetal and Cisco UCS related APIs confirmed to not be exposed to
> clients.
> > >>
> > >>
> > >> Thanks,
> > >>
> > >> Venkata Siva Vijayendra Bhamidipati
> > >
> >
Re: Review Request: Temporarily disabling baremetal functionality in
CS 4.1
Posted by Chip Childers <ch...@sungard.com>.
On Mon, Mar 25, 2013 at 08:12:52AM -0700, Animesh Chaturvedi wrote:
> Vijay
>
> Can you check this again with a new workspace? Chip both Min and I had verified on Friday that patch was applying before Vijay posted it. I will also try again with fresh 4.1. Sorry for the inconvenience.
I did a "git fetch origin; git checkout 4.1; git reset --hard
origin/4.1" before "git am ...". I don't quite get what the conflict
is.
Try the process above, including the git am using the patch available
within the review. Perhaps the posting process is mangling things?
>
> Thanks
> Animesh
>
> On Mar 24, 2013, at 11:08 AM, "Chip Childers" <ch...@sungard.com> wrote:
>
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/10071/#review18329
> > -----------------------------------------------------------
> >
> >
> > This patch still doesn't apply cleanly. Now sure what's going on. Please test with a fresh copy of the 4.1 branch to ensure that it's a clean patch.
> >
> > git am ~/patches/10071.patch
> > Applying: CS-1773: Disable baremetal functionality
> > error: patch failed: server/src/com/cloud/configuration/Config.java:359
> > error: server/src/com/cloud/configuration/Config.java: patch does not apply
> > Patch failed at 0001 CS-1773: Disable baremetal functionality
> >
> > - Chip Childers
> >
> >
> > On March 22, 2013, 11:55 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/10071/
> >> -----------------------------------------------------------
> >>
> >> (Updated March 22, 2013, 11:55 p.m.)
> >>
> >>
> >> Review request for cloudstack, Kelven Yang and Frank Zhang.
> >>
> >>
> >> Description
> >> -------
> >>
> >> Temporarily disabling baremetal functionality in CS 4.1
> >>
> >>
> >> This addresses bug CS-1773.
> >>
> >>
> >> Diffs
> >> -----
> >>
> >> client/pom.xml 38ba405
> >> client/tomcatconf/componentContext.xml.in ff7376e
> >> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
> >> plugins/pom.xml 02459b4
> >> server/src/com/cloud/configuration/Config.java 17fe62b
> >> setup/db/db/schema-40to410.sql 754bfb6
> >>
> >> Diff: https://reviews.apache.org/r/10071/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >> Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
> >>
> >>
> >> Thanks,
> >>
> >> Venkata Siva Vijayendra Bhamidipati
> >
>
Re: Review Request: Temporarily disabling baremetal functionality
in CS 4.1
Posted by Animesh Chaturvedi <an...@citrix.com>.
Vijay
Can you check this again with a new workspace? Chip both Min and I had verified on Friday that patch was applying before Vijay posted it. I will also try again with fresh 4.1. Sorry for the inconvenience.
Thanks
Animesh
On Mar 24, 2013, at 11:08 AM, "Chip Childers" <ch...@sungard.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10071/#review18329
> -----------------------------------------------------------
>
>
> This patch still doesn't apply cleanly. Now sure what's going on. Please test with a fresh copy of the 4.1 branch to ensure that it's a clean patch.
>
> git am ~/patches/10071.patch
> Applying: CS-1773: Disable baremetal functionality
> error: patch failed: server/src/com/cloud/configuration/Config.java:359
> error: server/src/com/cloud/configuration/Config.java: patch does not apply
> Patch failed at 0001 CS-1773: Disable baremetal functionality
>
> - Chip Childers
>
>
> On March 22, 2013, 11:55 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/10071/
>> -----------------------------------------------------------
>>
>> (Updated March 22, 2013, 11:55 p.m.)
>>
>>
>> Review request for cloudstack, Kelven Yang and Frank Zhang.
>>
>>
>> Description
>> -------
>>
>> Temporarily disabling baremetal functionality in CS 4.1
>>
>>
>> This addresses bug CS-1773.
>>
>>
>> Diffs
>> -----
>>
>> client/pom.xml 38ba405
>> client/tomcatconf/componentContext.xml.in ff7376e
>> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
>> plugins/pom.xml 02459b4
>> server/src/com/cloud/configuration/Config.java 17fe62b
>> setup/db/db/schema-40to410.sql 754bfb6
>>
>> Diff: https://reviews.apache.org/r/10071/diff/
>>
>>
>> Testing
>> -------
>>
>> Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
>>
>>
>> Thanks,
>>
>> Venkata Siva Vijayendra Bhamidipati
>
Re: Review Request: Temporarily disabling baremetal functionality in CS 4.1
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10071/#review18329
-----------------------------------------------------------
This patch still doesn't apply cleanly. Now sure what's going on. Please test with a fresh copy of the 4.1 branch to ensure that it's a clean patch.
git am ~/patches/10071.patch
Applying: CS-1773: Disable baremetal functionality
error: patch failed: server/src/com/cloud/configuration/Config.java:359
error: server/src/com/cloud/configuration/Config.java: patch does not apply
Patch failed at 0001 CS-1773: Disable baremetal functionality
- Chip Childers
On March 22, 2013, 11:55 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10071/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 11:55 p.m.)
>
>
> Review request for cloudstack, Kelven Yang and Frank Zhang.
>
>
> Description
> -------
>
> Temporarily disabling baremetal functionality in CS 4.1
>
>
> This addresses bug CS-1773.
>
>
> Diffs
> -----
>
> client/pom.xml 38ba405
> client/tomcatconf/componentContext.xml.in ff7376e
> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
> plugins/pom.xml 02459b4
> server/src/com/cloud/configuration/Config.java 17fe62b
> setup/db/db/schema-40to410.sql 754bfb6
>
> Diff: https://reviews.apache.org/r/10071/diff/
>
>
> Testing
> -------
>
> Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request: Temporarily disabling baremetal functionality in
CS 4.1
Posted by Chip Childers <ch...@sungard.com>.
On Fri, Mar 22, 2013 at 05:35:56PM -0700, Angeline Shen wrote:
> Chip, Vijay:
>
> Let me know When the build is ready, I can help test if baremetal feature has been deactivated from UI.
The patch doesn't apply cleanly.
>
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Friday, March 22, 2013 5:04 PM
> To: <de...@cloudstack.apache.org>; Vijayendra Bhamidipati
> Cc: Frank Zhang; Kelven Yang; cloudstack
> Subject: Re: Review Request: Temporarily disabling baremetal functionality in CS 4.1
>
> Can *you* check it first please? Does it apply cleanly? Does it compile?
>
> On Mar 22, 2013, at 7:55 PM, Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> wrote:
>
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/10071/
> > -----------------------------------------------------------
> >
> > (Updated March 22, 2013, 11:55 p.m.)
> >
> >
> > Review request for cloudstack, Kelven Yang and Frank Zhang.
> >
> >
> > Changes
> > -------
> >
> > Hi Chip!
> >
> > Reuploading a consolidated patch with the sql changes as well, plus another change in the plugins/pom.xml file - this is on top of the 4.1 branch - generated using git format-patch.. can you please check and let me if it applies? Thanks!
> >
> > Regards,
> > Vijay
> >
> >
> > Description
> > -------
> >
> > Temporarily disabling baremetal functionality in CS 4.1
> >
> >
> > This addresses bug CS-1773.
> >
> >
> > Diffs (updated)
> > -----
> >
> > client/pom.xml 38ba405
> > client/tomcatconf/componentContext.xml.in ff7376e
> > client/tomcatconf/nonossComponentContext.xml.in 35e1b28
> > plugins/pom.xml 02459b4
> > server/src/com/cloud/configuration/Config.java 17fe62b
> > setup/db/db/schema-40to410.sql 754bfb6
> >
> > Diff: https://reviews.apache.org/r/10071/diff/
> >
> >
> > Testing
> > -------
> >
> > Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
> >
> >
> > Thanks,
> >
> > Venkata Siva Vijayendra Bhamidipati
> >
>
RE: Review Request: Temporarily disabling baremetal functionality
in CS 4.1
Posted by Angeline Shen <An...@citrix.com>.
Chip, Vijay:
Let me know When the build is ready, I can help test if baremetal feature has been deactivated from UI.
-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com]
Sent: Friday, March 22, 2013 5:04 PM
To: <de...@cloudstack.apache.org>; Vijayendra Bhamidipati
Cc: Frank Zhang; Kelven Yang; cloudstack
Subject: Re: Review Request: Temporarily disabling baremetal functionality in CS 4.1
Can *you* check it first please? Does it apply cleanly? Does it compile?
On Mar 22, 2013, at 7:55 PM, Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10071/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 11:55 p.m.)
>
>
> Review request for cloudstack, Kelven Yang and Frank Zhang.
>
>
> Changes
> -------
>
> Hi Chip!
>
> Reuploading a consolidated patch with the sql changes as well, plus another change in the plugins/pom.xml file - this is on top of the 4.1 branch - generated using git format-patch.. can you please check and let me if it applies? Thanks!
>
> Regards,
> Vijay
>
>
> Description
> -------
>
> Temporarily disabling baremetal functionality in CS 4.1
>
>
> This addresses bug CS-1773.
>
>
> Diffs (updated)
> -----
>
> client/pom.xml 38ba405
> client/tomcatconf/componentContext.xml.in ff7376e
> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
> plugins/pom.xml 02459b4
> server/src/com/cloud/configuration/Config.java 17fe62b
> setup/db/db/schema-40to410.sql 754bfb6
>
> Diff: https://reviews.apache.org/r/10071/diff/
>
>
> Testing
> -------
>
> Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
RE: Review Request: Temporarily disabling baremetal functionality
in CS 4.1
Posted by Vijayendra Bhamidipati <vi...@citrix.com>.
Hi Chip,
Yes, it applies cleanly on top of 4.1, compiles, and I tested it out to ensure that the baremetal options/APIs aren't available post these changes. The previous patch I uploaded actually applied cleanly in my workspace, so I explicitly asked for whether the patch applied cleanly or not the second time around. Apologies for any misunderstanding.
Thanks,
Regards,
Vijay
________________________________________
From: Chip Childers [chip.childers@sungard.com]
Sent: Friday, March 22, 2013 5:04 PM
To: <de...@cloudstack.apache.org>; Vijayendra Bhamidipati
Cc: Frank Zhang; Kelven Yang; cloudstack
Subject: Re: Review Request: Temporarily disabling baremetal functionality in CS 4.1
Can *you* check it first please? Does it apply cleanly? Does it compile?
On Mar 22, 2013, at 7:55 PM, Venkata Siva Vijayendra Bhamidipati
<vi...@citrix.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10071/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 11:55 p.m.)
>
>
> Review request for cloudstack, Kelven Yang and Frank Zhang.
>
>
> Changes
> -------
>
> Hi Chip!
>
> Reuploading a consolidated patch with the sql changes as well, plus another change in the plugins/pom.xml file - this is on top of the 4.1 branch - generated using git format-patch.. can you please check and let me if it applies? Thanks!
>
> Regards,
> Vijay
>
>
> Description
> -------
>
> Temporarily disabling baremetal functionality in CS 4.1
>
>
> This addresses bug CS-1773.
>
>
> Diffs (updated)
> -----
>
> client/pom.xml 38ba405
> client/tomcatconf/componentContext.xml.in ff7376e
> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
> plugins/pom.xml 02459b4
> server/src/com/cloud/configuration/Config.java 17fe62b
> setup/db/db/schema-40to410.sql 754bfb6
>
> Diff: https://reviews.apache.org/r/10071/diff/
>
>
> Testing
> -------
>
> Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
Re: Review Request: Temporarily disabling baremetal functionality in
CS 4.1
Posted by Chip Childers <ch...@sungard.com>.
Can *you* check it first please? Does it apply cleanly? Does it compile?
On Mar 22, 2013, at 7:55 PM, Venkata Siva Vijayendra Bhamidipati
<vi...@citrix.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10071/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 11:55 p.m.)
>
>
> Review request for cloudstack, Kelven Yang and Frank Zhang.
>
>
> Changes
> -------
>
> Hi Chip!
>
> Reuploading a consolidated patch with the sql changes as well, plus another change in the plugins/pom.xml file - this is on top of the 4.1 branch - generated using git format-patch.. can you please check and let me if it applies? Thanks!
>
> Regards,
> Vijay
>
>
> Description
> -------
>
> Temporarily disabling baremetal functionality in CS 4.1
>
>
> This addresses bug CS-1773.
>
>
> Diffs (updated)
> -----
>
> client/pom.xml 38ba405
> client/tomcatconf/componentContext.xml.in ff7376e
> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
> plugins/pom.xml 02459b4
> server/src/com/cloud/configuration/Config.java 17fe62b
> setup/db/db/schema-40to410.sql 754bfb6
>
> Diff: https://reviews.apache.org/r/10071/diff/
>
>
> Testing
> -------
>
> Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
Re: Review Request: Temporarily disabling baremetal functionality in CS 4.1
Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10071/
-----------------------------------------------------------
(Updated March 22, 2013, 11:55 p.m.)
Review request for cloudstack, Kelven Yang and Frank Zhang.
Changes
-------
Hi Chip!
Reuploading a consolidated patch with the sql changes as well, plus another change in the plugins/pom.xml file - this is on top of the 4.1 branch - generated using git format-patch.. can you please check and let me if it applies? Thanks!
Regards,
Vijay
Description
-------
Temporarily disabling baremetal functionality in CS 4.1
This addresses bug CS-1773.
Diffs (updated)
-----
client/pom.xml 38ba405
client/tomcatconf/componentContext.xml.in ff7376e
client/tomcatconf/nonossComponentContext.xml.in 35e1b28
plugins/pom.xml 02459b4
server/src/com/cloud/configuration/Config.java 17fe62b
setup/db/db/schema-40to410.sql 754bfb6
Diff: https://reviews.apache.org/r/10071/diff/
Testing
-------
Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
Thanks,
Venkata Siva Vijayendra Bhamidipati
Re: Review Request: Temporarily disabling baremetal functionality
in CS 4.1
Posted by Animesh Chaturvedi <an...@citrix.com>.
Vijay
Please fix and submit a new patch
Thanks
Animesh
On Mar 22, 2013, at 8:04 AM, "Chip Childers" <ch...@sungard.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10071/#review18264
> -----------------------------------------------------------
>
>
> This patch does not apply to 4.1 cleanly.
>
> error: patch failed: server/src/com/cloud/configuration/Config.java:359
> error: server/src/com/cloud/configuration/Config.java: patch does not apply
>
> - Chip Childers
>
>
> On March 22, 2013, 2:52 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/10071/
>> -----------------------------------------------------------
>>
>> (Updated March 22, 2013, 2:52 a.m.)
>>
>>
>> Review request for cloudstack, Kelven Yang and Frank Zhang.
>>
>>
>> Description
>> -------
>>
>> Temporarily disabling baremetal functionality in CS 4.1
>>
>>
>> This addresses bug CS-1773.
>>
>>
>> Diffs
>> -----
>>
>> client/tomcatconf/componentContext.xml.in ff7376e
>> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
>> server/src/com/cloud/configuration/Config.java 17fe62b
>>
>> Diff: https://reviews.apache.org/r/10071/diff/
>>
>>
>> Testing
>> -------
>>
>> Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
>>
>>
>> Thanks,
>>
>> Venkata Siva Vijayendra Bhamidipati
>
Re: Review Request: Temporarily disabling baremetal functionality in CS 4.1
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10071/#review18264
-----------------------------------------------------------
This patch does not apply to 4.1 cleanly.
error: patch failed: server/src/com/cloud/configuration/Config.java:359
error: server/src/com/cloud/configuration/Config.java: patch does not apply
- Chip Childers
On March 22, 2013, 2:52 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10071/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 2:52 a.m.)
>
>
> Review request for cloudstack, Kelven Yang and Frank Zhang.
>
>
> Description
> -------
>
> Temporarily disabling baremetal functionality in CS 4.1
>
>
> This addresses bug CS-1773.
>
>
> Diffs
> -----
>
> client/tomcatconf/componentContext.xml.in ff7376e
> client/tomcatconf/nonossComponentContext.xml.in 35e1b28
> server/src/com/cloud/configuration/Config.java 17fe62b
>
> Diff: https://reviews.apache.org/r/10071/diff/
>
>
> Testing
> -------
>
> Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>