[GitHub] [superset] ktmud commented on a change in pull request #13294: feat(explore): Postgres datatype conversion

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r582315320



##########
File path: superset/db_engine_specs/base.py
##########
@@ -41,7 +41,8 @@
 import sqlparse
 from flask import g
 from flask_babel import lazy_gettext as _
-from sqlalchemy import column, DateTime, select
+from sqlalchemy import column, DateTime, select, types
+from sqlalchemy.dialects.postgresql import DOUBLE_PRECISION

Review comment:
       Seems like an extraneous import

##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +48,28 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
     engine = ""
     engine_name = "PostgreSQL"
 
+    column_type_mappings = (

Review comment:
       Would it make sense to consolidate the structure of `db_column_types` and `column_type_mappings` as they are basically doing very similar things (one to convert db column type to generic types; one to convert to SQLA types)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org