You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Benjamin Hindman (Created) (JIRA)" <ji...@apache.org> on 2011/11/15 20:26:52 UTC
[jira] [Created] (MESOS-85) Need to update semantics of MESOS_HOME
Need to update semantics of MESOS_HOME
--------------------------------------
Key: MESOS-85
URL: https://issues.apache.org/jira/browse/MESOS-85
Project: Mesos
Issue Type: Improvement
Components: build, master, slave, test
Reporter: Benjamin Hindman
Priority: Blocker
Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-85) Need to update semantics of
MESOS_HOME
Posted by "Charles Reiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199222#comment-13199222 ]
Charles Reiss commented on MESOS-85:
------------------------------------
After the auttools patches, most uses of MESOS_HOME are gone.
A survey of the source reveals some remaining ones:
- deploy/*.sh uses it;
- configuration default documentation (presumably for --help) says MESOS_HOME is used for several options.
* it is actually used for default logfile location, config file location, work dir location
- mesos-launcher and ExecutorLauncher pass it and use it for locating executors under some circumstances
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Blocker
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-85) Need to update semantics of
MESOS_HOME
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236760#comment-13236760 ]
jiraposter@reviews.apache.org commented on MESOS-85:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/
-----------------------------------------------------------
(Updated 2012-03-23 16:36:06.443788)
Review request for mesos and Benjamin Hindman.
Summary
-------
Removes most remaining uses of MESOS_HOME from the tree.
Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
This addresses bug MESOS-85.
https://issues.apache.org/jira/browse/MESOS-85
Diffs (updated)
-----
src/common/logging.cpp 9e346f2
src/configurator/configurator.hpp a3a104f
src/configurator/configurator.cpp 2666e50
src/deploy/mesos-daemon 2e75d04
src/deploy/mesos-env.sh 9f93a41
src/launcher/launcher.hpp 221094f
src/launcher/launcher.cpp 98a4847
src/launcher/main.cpp 5c55ace
src/local/main.cpp d4b68a9
src/master/main.cpp a8fadc9
src/mesos/main.cpp bbdb981
src/sched/sched.cpp 16770a1
src/slave/lxc_isolation_module.cpp 8c25dd4
src/slave/main.cpp ac780c4
src/slave/process_based_isolation_module.cpp e0f3ee8
src/slave/slave.cpp 9332caa
src/slave/webui.cpp 9f45442
src/tests/configurator_tests.cpp 662e01f
src/tests/external_tests.cpp 21fa705
Diff: https://reviews.apache.org/r/4434/diff
Testing
-------
make check
Thanks,
Charles
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Critical
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-85) Need to update semantics of
MESOS_HOME
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236325#comment-13236325 ]
jiraposter@reviews.apache.org commented on MESOS-85:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/#review6247
-----------------------------------------------------------
I do want to get this committed, but when I was looking a little closer there are a few cleanups to make first.
src/common/logging.cpp
<https://reviews.apache.org/r/4434/#comment13503>
This all becomes:
return conf.get("log_dir", "");
Also, is it okay to return an empty log dir!?
src/configurator/configurator.hpp
<https://reviews.apache.org/r/4434/#comment13579>
As long as you're in this file, please kill these white spaces.
src/configurator/configurator.hpp
<https://reviews.apache.org/r/4434/#comment13580>
And here.
src/launcher/launcher.cpp
<https://reviews.apache.org/r/4434/#comment13504>
s/frameworksHome/configuration option 'frameworks_home'
src/launcher/launcher.cpp
<https://reviews.apache.org/r/4434/#comment13581>
Not your bug, but the '\' should not be necessary. Please kill them. Also, s/MESOS_FRAMEWORKS_HOME/the configuration option 'frameworks_home'.
src/slave/slave.cpp
<https://reviews.apache.org/r/4434/#comment13582>
This all becomes:
string workDir = conf.get("work_dir", "work");
src/slave/webui.cpp
<https://reviews.apache.org/r/4434/#comment13506>
Same as above.
src/tests/configurator_tests.cpp
<https://reviews.apache.org/r/4434/#comment13584>
Kill whitespace.
src/tests/configurator_tests.cpp
<https://reviews.apache.org/r/4434/#comment13509>
Remove extra spaces.
- Benjamin
On 2012-03-21 19:02:07, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4434/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-21 19:02:07)
bq.
bq.
bq. Review request for mesos and Benjamin Hindman.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Removes most remaining uses of MESOS_HOME from the tree.
bq.
bq. Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
bq.
bq. After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
bq.
bq.
bq. This addresses bug MESOS-85.
bq. https://issues.apache.org/jira/browse/MESOS-85
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/tests/external_tests.cpp 21fa705
bq. src/slave/slave.cpp 9332caa
bq. src/slave/webui.cpp 9f45442
bq. src/tests/configurator_tests.cpp 662e01f
bq. src/sched/sched.cpp 16770a1
bq. src/slave/lxc_isolation_module.cpp 8c25dd4
bq. src/slave/main.cpp ac780c4
bq. src/slave/process_based_isolation_module.cpp e0f3ee8
bq. src/master/main.cpp a8fadc9
bq. src/mesos/main.cpp bbdb981
bq. src/launcher/main.cpp 5c55ace
bq. src/local/main.cpp d4b68a9
bq. src/launcher/launcher.cpp 98a4847
bq. src/launcher/launcher.hpp 221094f
bq. src/deploy/mesos-env.sh 9f93a41
bq. src/deploy/mesos-daemon 2e75d04
bq. src/configurator/configurator.hpp a3a104f
bq. src/configurator/configurator.cpp 2666e50
bq. src/common/logging.cpp 9e346f2
bq.
bq. Diff: https://reviews.apache.org/r/4434/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Critical
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-85) Need to update semantics of
MESOS_HOME
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234870#comment-13234870 ]
jiraposter@reviews.apache.org commented on MESOS-85:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Summary
-------
Removes most remaining uses of MESOS_HOME from the tree.
Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
This addresses bug MESOS-85.
https://issues.apache.org/jira/browse/MESOS-85
Diffs
-----
src/tests/external_tests.cpp 21fa705
src/slave/slave.cpp 9332caa
src/slave/webui.cpp 9f45442
src/tests/configurator_tests.cpp 662e01f
src/sched/sched.cpp 16770a1
src/slave/lxc_isolation_module.cpp 8c25dd4
src/slave/main.cpp ac780c4
src/slave/process_based_isolation_module.cpp e0f3ee8
src/master/main.cpp a8fadc9
src/mesos/main.cpp bbdb981
src/launcher/main.cpp 5c55ace
src/local/main.cpp d4b68a9
src/launcher/launcher.cpp 98a4847
src/launcher/launcher.hpp 221094f
src/deploy/mesos-env.sh 9f93a41
src/deploy/mesos-daemon 2e75d04
src/configurator/configurator.hpp a3a104f
src/configurator/configurator.cpp 2666e50
src/common/logging.cpp 9e346f2
Diff: https://reviews.apache.org/r/4434/diff
Testing
-------
make check
Thanks,
Charles
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Blocker
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-85) Need to update semantics of
MESOS_HOME
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235892#comment-13235892 ]
jiraposter@reviews.apache.org commented on MESOS-85:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/#review6246
-----------------------------------------------------------
Ship it!
This is brilliant! Thanks Charles!
- Benjamin
On 2012-03-21 19:02:07, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4434/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-21 19:02:07)
bq.
bq.
bq. Review request for mesos and Benjamin Hindman.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Removes most remaining uses of MESOS_HOME from the tree.
bq.
bq. Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
bq.
bq. After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
bq.
bq.
bq. This addresses bug MESOS-85.
bq. https://issues.apache.org/jira/browse/MESOS-85
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/tests/external_tests.cpp 21fa705
bq. src/slave/slave.cpp 9332caa
bq. src/slave/webui.cpp 9f45442
bq. src/tests/configurator_tests.cpp 662e01f
bq. src/sched/sched.cpp 16770a1
bq. src/slave/lxc_isolation_module.cpp 8c25dd4
bq. src/slave/main.cpp ac780c4
bq. src/slave/process_based_isolation_module.cpp e0f3ee8
bq. src/master/main.cpp a8fadc9
bq. src/mesos/main.cpp bbdb981
bq. src/launcher/main.cpp 5c55ace
bq. src/local/main.cpp d4b68a9
bq. src/launcher/launcher.cpp 98a4847
bq. src/launcher/launcher.hpp 221094f
bq. src/deploy/mesos-env.sh 9f93a41
bq. src/deploy/mesos-daemon 2e75d04
bq. src/configurator/configurator.hpp a3a104f
bq. src/configurator/configurator.cpp 2666e50
bq. src/common/logging.cpp 9e346f2
bq.
bq. Diff: https://reviews.apache.org/r/4434/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Critical
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-85) Need to update semantics of
MESOS_HOME
Posted by "Charles Reiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155464#comment-13155464 ]
Charles Reiss commented on MESOS-85:
------------------------------------
To get our pending autotools patch, I've done work (in the autotools github branch as of this writing) towards this, including:
- adding a configuration option for the location mesos-launcher and the webui files, defaulting to (hardcoded at compile-time) install locations. In the current version, the default install locations are $(prefix)/libexec/mesos for mesos-launcher and $(prefix)/share/mesos for the WebUI scripts.
- modifying the test harness to set MESOS_SOURCE_DIR and MESOS_BUILD_DIR and having the external test scripts to use those environment variables instead of MESOS_HOME;
The biggest issue I see remaining is how we should handle running out of the build directory without MESOS_HOME. I don't think it's appropriate for an installed binary to look in the current work directory for installed files (assuming it's the build directory and that we staged files there), and I'm sure it's not appropriate to have an installed binary look in a hard-coded source directory before where files are installed (since this will cause mysterious use of an uninstalled Mesos by a production binary). And if we look in the installed locations first but "usually" find the uninstalled files, this might confuse developers who have modified their uninstalled files (e.g. to add features to the webui). We could tell anyone running out of the build directory to set some environment variable (such as MESOS_UNINSTALLED=1 or MESOS_BUILD_DIR=`pwd` or just MESOS_CONF set to point to a configuration file built from AC_OUTPUT), which would require minimum modifications to Mesos. Alternately, we could try to guess if we were running out of the installed locations from /proc/self/exe and/or argv[0], but I'm worried this will be fragile (and a bunch of extra code for non-Linux systems).
Other remaining issues are choosing sensible defaults for log_dir and work_dir that aren't based on MESOS_HOME.
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Blocker
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (MESOS-85) Need to update semantics
of MESOS_HOME
Posted by "Charles Reiss (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155464#comment-13155464 ]
Charles Reiss edited comment on MESOS-85 at 11/22/11 9:49 PM:
--------------------------------------------------------------
To get our pending autotools patch, I've done work (in the autotools github branch as of this writing) towards this, including:
- adding a configuration option for the location mesos-launcher and the webui files, defaulting to (hardcoded at compile-time) install locations. In the current version, the default install locations are $(prefix)/libexec/mesos for mesos-launcher and $(prefix)/share/mesos for the WebUI scripts.
- modifying the test harness to set MESOS_SOURCE_DIR and MESOS_BUILD_DIR and having the external test scripts to use those environment variables instead of MESOS_HOME;
The biggest issue I see remaining is how we should handle running out of the build directory without MESOS_HOME. I don't think it's appropriate for an installed binary to look in the current work directory for installed files (assuming it's the build directory and that we staged files there), and I'm sure it's not appropriate to have an installed binary look in a hard-coded source or build directory before looking where files are installed (since this will cause mysterious use of an uninstalled Mesos by a production binary). And if we look in the installed locations first but "usually" find the uninstalled files, this might confuse developers who have modified their uninstalled files (e.g. to add features to the webui). We could tell anyone running out of the build directory to set some environment variable (such as MESOS_UNINSTALLED=1 or MESOS_BUILD_DIR=`pwd` or just MESOS_CONF set to point to a configuration file built from AC_OUTPUT), which would require minimum modifications to Mesos. Alternately, we could try to guess if we were running out of the installed locations from /proc/self/exe and/or argv[0], but I'm worried this will be fragile (and a bunch of extra code for non-Linux systems).
Other remaining issues are choosing sensible defaults for log_dir and work_dir that aren't based on MESOS_HOME.
was (Author: woggle):
To get our pending autotools patch, I've done work (in the autotools github branch as of this writing) towards this, including:
- adding a configuration option for the location mesos-launcher and the webui files, defaulting to (hardcoded at compile-time) install locations. In the current version, the default install locations are $(prefix)/libexec/mesos for mesos-launcher and $(prefix)/share/mesos for the WebUI scripts.
- modifying the test harness to set MESOS_SOURCE_DIR and MESOS_BUILD_DIR and having the external test scripts to use those environment variables instead of MESOS_HOME;
The biggest issue I see remaining is how we should handle running out of the build directory without MESOS_HOME. I don't think it's appropriate for an installed binary to look in the current work directory for installed files (assuming it's the build directory and that we staged files there), and I'm sure it's not appropriate to have an installed binary look in a hard-coded source directory before where files are installed (since this will cause mysterious use of an uninstalled Mesos by a production binary). And if we look in the installed locations first but "usually" find the uninstalled files, this might confuse developers who have modified their uninstalled files (e.g. to add features to the webui). We could tell anyone running out of the build directory to set some environment variable (such as MESOS_UNINSTALLED=1 or MESOS_BUILD_DIR=`pwd` or just MESOS_CONF set to point to a configuration file built from AC_OUTPUT), which would require minimum modifications to Mesos. Alternately, we could try to guess if we were running out of the installed locations from /proc/self/exe and/or argv[0], but I'm worried this will be fragile (and a bunch of extra code for non-Linux systems).
Other remaining issues are choosing sensible defaults for log_dir and work_dir that aren't based on MESOS_HOME.
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Blocker
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MESOS-85) Need to update semantics of MESOS_HOME
Posted by "Charles Reiss (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Reiss reassigned MESOS-85:
----------------------------------
Assignee: Charles Reiss
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Blocker
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-85) Need to update semantics of
MESOS_HOME
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236377#comment-13236377 ]
jiraposter@reviews.apache.org commented on MESOS-85:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/
-----------------------------------------------------------
(Updated 2012-03-23 06:04:06.888041)
Review request for mesos and Benjamin Hindman.
Summary
-------
Removes most remaining uses of MESOS_HOME from the tree.
Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
This addresses bug MESOS-85.
https://issues.apache.org/jira/browse/MESOS-85
Diffs (updated)
-----
src/common/logging.cpp 9e346f2
src/configurator/configurator.hpp a3a104f
src/configurator/configurator.cpp 2666e50
src/deploy/mesos-daemon 2e75d04
src/deploy/mesos-env.sh 9f93a41
src/launcher/launcher.hpp 221094f
src/launcher/launcher.cpp 98a4847
src/launcher/main.cpp 5c55ace
src/local/main.cpp d4b68a9
src/master/main.cpp a8fadc9
src/mesos/main.cpp bbdb981
src/sched/sched.cpp 16770a1
src/slave/lxc_isolation_module.cpp 8c25dd4
src/slave/main.cpp ac780c4
src/slave/process_based_isolation_module.cpp e0f3ee8
src/slave/slave.cpp 9332caa
src/slave/webui.cpp 9f45442
src/tests/configurator_tests.cpp 662e01f
src/tests/external_tests.cpp 21fa705
Diff: https://reviews.apache.org/r/4434/diff
Testing
-------
make check
Thanks,
Charles
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Critical
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MESOS-85) Need to update semantics of MESOS_HOME
Posted by "Charles Reiss (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Reiss resolved MESOS-85.
--------------------------------
Resolution: Fixed
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Critical
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-85) Need to update semantics of
MESOS_HOME
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237642#comment-13237642 ]
jiraposter@reviews.apache.org commented on MESOS-85:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/#review6326
-----------------------------------------------------------
Ship it!
Thanks Charles, I'm committing this now.
- Benjamin
On 2012-03-23 16:36:06, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4434/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 16:36:06)
bq.
bq.
bq. Review request for mesos and Benjamin Hindman.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Removes most remaining uses of MESOS_HOME from the tree.
bq.
bq. Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
bq.
bq. After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
bq.
bq.
bq. This addresses bug MESOS-85.
bq. https://issues.apache.org/jira/browse/MESOS-85
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/common/logging.cpp 9e346f2
bq. src/configurator/configurator.hpp a3a104f
bq. src/configurator/configurator.cpp 2666e50
bq. src/deploy/mesos-daemon 2e75d04
bq. src/deploy/mesos-env.sh 9f93a41
bq. src/launcher/launcher.hpp 221094f
bq. src/launcher/launcher.cpp 98a4847
bq. src/launcher/main.cpp 5c55ace
bq. src/local/main.cpp d4b68a9
bq. src/master/main.cpp a8fadc9
bq. src/mesos/main.cpp bbdb981
bq. src/sched/sched.cpp 16770a1
bq. src/slave/lxc_isolation_module.cpp 8c25dd4
bq. src/slave/main.cpp ac780c4
bq. src/slave/process_based_isolation_module.cpp e0f3ee8
bq. src/slave/slave.cpp 9332caa
bq. src/slave/webui.cpp 9f45442
bq. src/tests/configurator_tests.cpp 662e01f
bq. src/tests/external_tests.cpp 21fa705
bq.
bq. Diff: https://reviews.apache.org/r/4434/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Critical
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MESOS-85) Need to update semantics of MESOS_HOME
Posted by "Charles Reiss (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Reiss updated MESOS-85:
-------------------------------
Priority: Critical (was: Blocker)
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Critical
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-85) Need to update semantics of
MESOS_HOME
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236378#comment-13236378 ]
jiraposter@reviews.apache.org commented on MESOS-85:
----------------------------------------------------
bq. On 2012-03-23 04:55:13, Benjamin Hindman wrote:
bq. > src/common/logging.cpp, lines 76-81
bq. > <https://reviews.apache.org/r/4434/diff/2/?file=94274#file94274line76>
bq. >
bq. > This all becomes:
bq. > return conf.get("log_dir", "");
bq. >
bq. > Also, is it okay to return an empty log dir!?
Yes; empty uses the glog default.
bq. On 2012-03-23 04:55:13, Benjamin Hindman wrote:
bq. > src/configurator/configurator.hpp, line 296
bq. > <https://reviews.apache.org/r/4434/diff/2/?file=94275#file94275line296>
bq. >
bq. > As long as you're in this file, please kill these white spaces.
Done.
bq. On 2012-03-23 04:55:13, Benjamin Hindman wrote:
bq. > src/configurator/configurator.hpp, line 302
bq. > <https://reviews.apache.org/r/4434/diff/2/?file=94275#file94275line302>
bq. >
bq. > And here.
Done. (And elsewhere.)
bq. On 2012-03-23 04:55:13, Benjamin Hindman wrote:
bq. > src/launcher/launcher.cpp, lines 223-225
bq. > <https://reviews.apache.org/r/4434/diff/2/?file=94280#file94280line223>
bq. >
bq. > Not your bug, but the '\' should not be necessary. Please kill them. Also, s/MESOS_FRAMEWORKS_HOME/the configuration option 'frameworks_home'.
Done and done.
bq. On 2012-03-23 04:55:13, Benjamin Hindman wrote:
bq. > src/slave/slave.cpp, lines 1449-1461
bq. > <https://reviews.apache.org/r/4434/diff/2/?file=94289#file94289line1449>
bq. >
bq. > This all becomes:
bq. > string workDir = conf.get("work_dir", "work");
Done.
bq. On 2012-03-23 04:55:13, Benjamin Hindman wrote:
bq. > src/slave/webui.cpp, lines 43-55
bq. > <https://reviews.apache.org/r/4434/diff/2/?file=94290#file94290line43>
bq. >
bq. > Same as above.
Done.
bq. On 2012-03-23 04:55:13, Benjamin Hindman wrote:
bq. > src/tests/configurator_tests.cpp, line 70
bq. > <https://reviews.apache.org/r/4434/diff/2/?file=94291#file94291line70>
bq. >
bq. > Kill whitespace.
Done.
bq. On 2012-03-23 04:55:13, Benjamin Hindman wrote:
bq. > src/tests/configurator_tests.cpp, line 262
bq. > <https://reviews.apache.org/r/4434/diff/2/?file=94291#file94291line262>
bq. >
bq. > Remove extra spaces.
Done.
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/#review6247
-----------------------------------------------------------
On 2012-03-23 06:04:06, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4434/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 06:04:06)
bq.
bq.
bq. Review request for mesos and Benjamin Hindman.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Removes most remaining uses of MESOS_HOME from the tree.
bq.
bq. Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
bq.
bq. After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
bq.
bq.
bq. This addresses bug MESOS-85.
bq. https://issues.apache.org/jira/browse/MESOS-85
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/common/logging.cpp 9e346f2
bq. src/configurator/configurator.hpp a3a104f
bq. src/configurator/configurator.cpp 2666e50
bq. src/deploy/mesos-daemon 2e75d04
bq. src/deploy/mesos-env.sh 9f93a41
bq. src/launcher/launcher.hpp 221094f
bq. src/launcher/launcher.cpp 98a4847
bq. src/launcher/main.cpp 5c55ace
bq. src/local/main.cpp d4b68a9
bq. src/master/main.cpp a8fadc9
bq. src/mesos/main.cpp bbdb981
bq. src/sched/sched.cpp 16770a1
bq. src/slave/lxc_isolation_module.cpp 8c25dd4
bq. src/slave/main.cpp ac780c4
bq. src/slave/process_based_isolation_module.cpp e0f3ee8
bq. src/slave/slave.cpp 9332caa
bq. src/slave/webui.cpp 9f45442
bq. src/tests/configurator_tests.cpp 662e01f
bq. src/tests/external_tests.cpp 21fa705
bq.
bq. Diff: https://reviews.apache.org/r/4434/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Critical
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-85) Need to update semantics of
MESOS_HOME
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236759#comment-13236759 ]
jiraposter@reviews.apache.org commented on MESOS-85:
----------------------------------------------------
bq. On 2012-03-23 04:55:13, Benjamin Hindman wrote:
bq. > src/launcher/launcher.cpp, line 215
bq. > <https://reviews.apache.org/r/4434/diff/2/?file=94280#file94280line215>
bq. >
bq. > s/frameworksHome/configuration option 'frameworks_home'
Done.
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/#review6247
-----------------------------------------------------------
On 2012-03-23 16:36:06, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4434/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 16:36:06)
bq.
bq.
bq. Review request for mesos and Benjamin Hindman.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Removes most remaining uses of MESOS_HOME from the tree.
bq.
bq. Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
bq.
bq. After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
bq.
bq.
bq. This addresses bug MESOS-85.
bq. https://issues.apache.org/jira/browse/MESOS-85
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/common/logging.cpp 9e346f2
bq. src/configurator/configurator.hpp a3a104f
bq. src/configurator/configurator.cpp 2666e50
bq. src/deploy/mesos-daemon 2e75d04
bq. src/deploy/mesos-env.sh 9f93a41
bq. src/launcher/launcher.hpp 221094f
bq. src/launcher/launcher.cpp 98a4847
bq. src/launcher/main.cpp 5c55ace
bq. src/local/main.cpp d4b68a9
bq. src/master/main.cpp a8fadc9
bq. src/mesos/main.cpp bbdb981
bq. src/sched/sched.cpp 16770a1
bq. src/slave/lxc_isolation_module.cpp 8c25dd4
bq. src/slave/main.cpp ac780c4
bq. src/slave/process_based_isolation_module.cpp e0f3ee8
bq. src/slave/slave.cpp 9332caa
bq. src/slave/webui.cpp 9f45442
bq. src/tests/configurator_tests.cpp 662e01f
bq. src/tests/external_tests.cpp 21fa705
bq.
bq. Diff: https://reviews.apache.org/r/4434/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Critical
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira