You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by Tom White <to...@gmail.com> on 2007/06/28 23:07:28 UTC
Examples and tests for aggregate library
I started looking at some of the aggregate code (in connection with
https://issues.apache.org/jira/browse/HADOOP-1231) and I noticed that
the abacus examples in contrib didn't make it to the main examples
when the abacus code was moved. Also, AggregatorTests in
org.apache.hadoop.mapred.lib.aggregate isn't actually a unit test -
how does it get run? I guess these things need remedying - shall I
open a Jira?
Tom
Re: Examples and tests for aggregate library
Posted by Tom White <to...@gmail.com>.
Runping,
> AggregatorTests is actually used by the unit test class
> TestAggregates.java which is in test/org/apache/hadoop/mapred.
> Not sure why I put TestAggregates in that dir though.
> I can move the code easily if it is desired to do so.
I missed TestAggregates. I think it belongs better with
AggregatorTests, so yes I would suggest it's moved to
org.apache.hadoop.mapred.lib.aggregate.
> As to the abacus example code, the code itself is a bit weird --- it is
> generated by Jython. I was not happy with it. And I did not have time to
> write a nicer example. Now that release 0.13 is out, I'll find some time to
> write an example.
The code in src/contrib/abacus/src/examples is generated with Jython?
It looks OK to me. Whatever, I've created a Jira issue to sort out the
examples (https://issues.apache.org/jira/browse/HADOOP-1547).
>
> If you open Jiras for those issues, I or somebody in my team will pick them
> up.
Thanks!
Tom
RE: Examples and tests for aggregate library
Posted by Runping Qi <ru...@yahoo-inc.com>.
Tom,
AggregatorTests is actually used by the unit test class
TestAggregates.java which is in test/org/apache/hadoop/mapred.
Not sure why I put TestAggregates in that dir though.
I can move the code easily if it is desired to do so.
As to the abacus example code, the code itself is a bit weird --- it is
generated by Jython. I was not happy with it. And I did not have time to
write a nicer example. Now that release 0.13 is out, I'll find some time to
write an example.
If you open Jiras for those issues, I or somebody in my team will pick them
up.
Runping
> -----Original Message-----
> From: Tom White [mailto:tom.e.white@gmail.com]
> Sent: Thursday, June 28, 2007 2:07 PM
> To: hadoop-dev@lucene.apache.org
> Subject: Examples and tests for aggregate library
>
> I started looking at some of the aggregate code (in connection with
> https://issues.apache.org/jira/browse/HADOOP-1231) and I noticed that
> the abacus examples in contrib didn't make it to the main examples
> when the abacus code was moved. Also, AggregatorTests in
> org.apache.hadoop.mapred.lib.aggregate isn't actually a unit test -
> how does it get run? I guess these things need remedying - shall I
> open a Jira?
>
> Tom