[jira] [Commented] (COMPRESS-214) better support for unix symlinks

["Stefan Bodewig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COMPRESS-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557988#comment-13557988 ] 

Stefan Bodewig commented on COMPRESS-214:
-----------------------------------------

Sorry, I'm a bit late, but a few comments:

I guess the symlinks are likely written using the same encoding that is used for filenames.  ZipFile already has support for that, it might be better to simply reuse that than default to UTF-8.  In fact it might be better to move the whole getUnixSymlink to ZipFile  For the ZipInputStreamCase a combination of ZipEncoding#decode and reading thwo full content of the entry should work as well.

Anyway, nice addition, thanks.
                
> better support for unix symlinks
> --------------------------------
>
>                 Key: COMPRESS-214
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-214
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Archivers
>            Reporter: Julius Davies
>            Assignee: Julius Davies
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: COMPRESS-214.patch, COMPRESS-214_unix_symlinks.zip
>
>
> The current API is a little awkward when dealing with symlinks (e.g., those created using Info-Zip's "zip -y").
> I propose the following three methods for ZipArchiveEntry:
> {noformat}
> public boolean isUnixSymlink()
> public String getUnixSymlink(ZipFile zf)
> public String getUnixSymlink(ZipFile zf, String pathCharset)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira