You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2023/01/10 00:34:43 UTC
[GitHub] [httpcomponents-client] MartinWitt opened a new pull request, #405: refactor: refactor bad smell InnerClassMayBeStatic
MartinWitt opened a new pull request, #405:
URL: https://github.com/apache/httpcomponents-client/pull/405
# Repairing Code Style Issues
<!-- laughing-train-refactor -->
## InnerClassMayBeStatic
Inner classes that do not reference their enclosing instances can be made static.
This prevents a common cause of memory leaks and uses less memory per instance of the class.
<!-- fingerprint:1991817202 -->
<!-- fingerprint:1327295172 -->
<!-- fingerprint:1334395164 -->
# Repairing Code Style Issues
* InnerClassMayBeStatic (3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #405: refactor: refactor bad smell InnerClassMayBeStatic
Posted by GitBox <gi...@apache.org>.
ok2c commented on PR #405:
URL: https://github.com/apache/httpcomponents-client/pull/405#issuecomment-1378427368
@MartinWitt This is a reasonable thing. However code style policies should be enforced through the style check [1] and not randomly. Would you be willing to adjust the style check definitions as well?
[1] https://github.com/apache/httpcomponents-stylecheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] MartinWitt commented on pull request #405: refactor: refactor bad smell InnerClassMayBeStatic
Posted by GitBox <gi...@apache.org>.
MartinWitt commented on PR #405:
URL: https://github.com/apache/httpcomponents-client/pull/405#issuecomment-1380264088
To my best knowledge, this rule isn't part of checkstyle, See https://checkstyle.sourceforge.io/config_coding.html. This bad smell was discovered by [Qodana ](https://www.jetbrains.com/qodana/) with the rule `InnerClassMayBeStatic`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c merged pull request #405: refactor: refactor bad smell InnerClassMayBeStatic
Posted by GitBox <gi...@apache.org>.
ok2c merged PR #405:
URL: https://github.com/apache/httpcomponents-client/pull/405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org