You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2014/08/15 09:29:18 UTC
[jira] [Commented] (ZOOKEEPER-2011) move legacy zookeeper jar to
dist-maven
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098289#comment-14098289 ]
Hadoop QA commented on ZOOKEEPER-2011:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12661989/ZOOKEEPER-2011-trunk.patch
against trunk revision 1617921.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2281//console
This message is automatically generated.
> move legacy zookeeper jar to dist-maven
> ---------------------------------------
>
> Key: ZOOKEEPER-2011
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2011
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Reporter: Qiang Tian
> Priority: Minor
> Attachments: ZOOKEEPER-2011-trunk.patch
>
>
> Since most users do not care about the source code, it would be better to put the fat jar to disk-maven dir.
> also see the README.txt:
> {quote}
> zookeeper-<version>.jar - legacy jar file which contains all classes
> and source files. Prior to version 3.3.0 this
> was the only jar file available. It has the
> benefit of having the source included (for
> debugging purposes) however is also larger as
> a result
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)