You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/03 04:50:28 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21919: Use ConcurrentHashMap to instead of sync in DistributedLockHolder
codecov-commenter commented on PR #21919:
URL: https://github.com/apache/shardingsphere/pull/21919#issuecomment-1301636757
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21919?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21919](https://codecov.io/gh/apache/shardingsphere/pull/21919?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49830f0) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6846f956b769c99e5ce790fb7c73ebd6a0fc5e11?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6846f95) will **increase** coverage by `0.00%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #21919 +/- ##
=========================================
Coverage 61.06% 61.07%
- Complexity 2458 2465 +7
=========================================
Files 4100 4100
Lines 56977 56973 -4
Branches 9632 9632
=========================================
+ Hits 34793 34795 +2
+ Misses 19262 19254 -8
- Partials 2922 2924 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/lock/creator/DistributedLockCreatorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/21919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcmVwb3NpdG9yeS9jbHVzdGVyL2xvY2svY3JlYXRvci9EaXN0cmlidXRlZExvY2tDcmVhdG9yRmFjdG9yeS5qYXZh) | `0.00% <ø> (ø)` | |
| [...ory/cluster/lock/holder/DistributedLockHolder.java](https://codecov.io/gh/apache/shardingsphere/pull/21919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcmVwb3NpdG9yeS9jbHVzdGVyL2xvY2svaG9sZGVyL0Rpc3RyaWJ1dGVkTG9ja0hvbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...de/repository/cluster/consul/ConsulRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/21919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci9jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcmVwb3NpdG9yeS9jbHVzdGVyL2NvbnN1bC9Db25zdWxSZXBvc2l0b3J5LmphdmE=) | `45.23% <ø> (ø)` | |
| [...ster/consul/lock/ConsulDistributedLockCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/21919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci9jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcmVwb3NpdG9yeS9jbHVzdGVyL2NvbnN1bC9sb2NrL0NvbnN1bERpc3RyaWJ1dGVkTG9ja0NyZWF0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...e/mode/repository/cluster/etcd/EtcdRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/21919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci9ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL3JlcG9zaXRvcnkvY2x1c3Rlci9ldGNkL0V0Y2RSZXBvc2l0b3J5LmphdmE=) | `63.38% <ø> (ø)` | |
| [.../cluster/etcd/lock/EtcdDistributedLockCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/21919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci9ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL3JlcG9zaXRvcnkvY2x1c3Rlci9ldGNkL2xvY2svRXRjZERpc3RyaWJ1dGVkTG9ja0NyZWF0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../cluster/zookeeper/CuratorZookeeperRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/21919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci96b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9yZXBvc2l0b3J5L2NsdXN0ZXIvem9va2VlcGVyL0N1cmF0b3Jab29rZWVwZXJSZXBvc2l0b3J5LmphdmE=) | `56.55% <ø> (ø)` | |
| [...r/lock/CuratorZooKeeperDistributedLockCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/21919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci96b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9yZXBvc2l0b3J5L2NsdXN0ZXIvem9va2VlcGVyL2xvY2svQ3VyYXRvclpvb0tlZXBlckRpc3RyaWJ1dGVkTG9ja0NyZWF0b3IuamF2YQ==) | `66.66% <ø> (ø)` | |
| [...ine/type/unicast/ShardingUnicastRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/21919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3R5cGUvdW5pY2FzdC9TaGFyZGluZ1VuaWNhc3RSb3V0aW5nRW5naW5lLmphdmE=) | `91.30% <60.00%> (-4.35%)` | :arrow_down: |
| [...er/distsql/rql/rule/SingleTableQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/21919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcnFsL3J1bGUvU2luZ2xlVGFibGVRdWVyeVJlc3VsdFNldC5qYXZh) | `78.57% <100.00%> (ø)` | |
| ... and [1 more](https://codecov.io/gh/apache/shardingsphere/pull/21919/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org