[GitHub] [nifi] mtien-apache commented on a diff in pull request #5671: NIFI-9514 NIFI-9515: Add UI support for Parameter Providers in Controller Services

[GitBox <gi...@apache.org>]

mtien-apache commented on code in PR #5671:
URL: https://github.com/apache/nifi/pull/5671#discussion_r967911475


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js:
##########
@@ -2674,6 +2731,11 @@
                     $('#parameter-context-id-setting').addClass('hidden');
                 }
 
+                // initially hide the provider setting
+                if (!$('#parameter-context-provider-setting').hasClass('hidden')) {
+                    $('#parameter-context-provider-setting').addClass('hidden');

Review Comment:
   Fixed.



##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js:
##########
@@ -1086,12 +1111,13 @@
         $('#parameter-context-dialog').modal('refreshButtons');
     };
 
-
     var hasParameterContextChanged = function (parameterContextEntity) {
-        var parameters = marshalParameters();
         var proposedParamContextName = $('#parameter-context-name').val();
         var proposedParamContextDesc = $('#parameter-context-description-field').val();
         var inheritedParameterContexts = marshalInheritedParameterContexts();
+        var componentDescription = nfCommon.isDefinedAndNotNull(_.get(parameterContextEntity, 'component.description'))
+            ? _.get(parameterContextEntity, 'component.description')
+            : '';

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org