You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Alanxtl (via GitHub)" <gi...@apache.org> on 2025/06/24 02:11:38 UTC
[PR] Fix: Fix ci fail [dubbo-go-samples]
Alanxtl opened a new pull request, #861:
URL: https://github.com/apache/dubbo-go-samples/pull/861
ci fails due to go-version conflict, the variable in ci file should be `go-version` instead of `golang`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix: Fix ci fail [dubbo-go-samples]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks merged PR #861:
URL: https://github.com/apache/dubbo-go-samples/pull/861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix: Fix ci fail [dubbo-go-samples]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #861:
URL: https://github.com/apache/dubbo-go-samples/pull/861#discussion_r2162828526
##########
.github/workflows/golangci-lint.yml:
##########
@@ -20,14 +20,18 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
- golang:
+ go-version:
- '1.23'
steps:
- - uses: actions/setup-go@v3
+ - uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go_version }}
Review Comment:
The matrix key was updated to 'go-version' but is still referenced as 'matrix.go_version'. Please update the reference to 'matrix.go-version' or change the key to 'go_version' to ensure consistency.
```suggestion
go-version: ${{ matrix.go-version }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org