You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by stevengill <gi...@git.apache.org> on 2016/02/22 21:33:40 UTC
[GitHub] cordova-osx pull request: CB-10668 Moved node_modules to root
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-osx/pull/33
CB-10668 Moved node_modules to root
* Added dependencies to `package.json`
* Added `bundledDependencies` to `package.json`
* Updated `prepare.js` to use `ios_CFBundleVersion` and `ios_CFBundleIdentifier` instead of `osx_` prefix because those don't exist in `cordova-common` yet
* Updated `create.js` to grab `node_modules` from root instead of `bin/node_modules`
* Deleted `bin/node_modules`
* Updated iOS references to OSX where applicable (API.js and prepare.js)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-osx master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-osx/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit 249f7dd2bcb3388f0d6679f037f5c5e9dc5e9daf
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-22T18:53:02Z
CB-10668 updated package.json, prepare.js and Api.js
commit 103deecb1e7295a9a96e24000591354023d30eee
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-22T18:53:26Z
CB-10668 removed bin/node_modules, updated create.js to use root
node_modules
commit 7a58a67bee7576155b5c369124c7bced51c82fec
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-22T19:55:25Z
CB-10668 added node_modules directory
commit 18df1bfcea10fd67f130de9d017e23f4cd1cc307
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-22T20:29:05Z
CB-10668 fixed failing tests, reverted shelljs to 0.5.3
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: CB-10668 Moved node_modules to root
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-osx/pull/33#issuecomment-187416637
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: CB-10668 Moved node_modules to root
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-osx/pull/33#issuecomment-187380673
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: CB-10668 Moved node_modules to root
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-osx/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org