You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by galexandrov <gi...@git.apache.org> on 2015/08/05 13:51:41 UTC
[GitHub] cordova-wp8 pull request: Move AutoLoadCommand execution in Framew...
GitHub user galexandrov opened a pull request:
https://github.com/apache/cordova-wp8/pull/87
Move AutoLoadCommand execution in FrameworkElement.Loaded event
- Add AutoLoadCommand execution in FrameworkElement.Loaded event and remove it from CordovaBrowser_LoadCompleted
- This change is done, because the auto-load plugins should be initialized once and before the CordovaBrowser page load complete event (as it works in iOS and Android). Via this change the OnInit method will be invoked only once and for example the splashscreen plugin will start immediately instead of waiting the page to load.
- Respect the CancelEventArgs.Cancel Property in page_BackKeyPress
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-wp8 galexandrov/cordova-wp8-autoloadcommands
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-wp8/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
----
commit 70c24e81f927d9be54f6dfa20ba552d619401cb0
Author: Georgi Alexandrov <ge...@telerik.com>
Date: 2015-08-05T08:42:04Z
Move AutoLoadCommand execution in FrameworkElement.Loaded event
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Move AutoLoadCommand execution in Framew...
Posted by galexandrov <gi...@git.apache.org>.
Github user galexandrov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/87#issuecomment-136988297
ping @purplecabbage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Move AutoLoadCommand execution in Framew...
Posted by galexandrov <gi...@git.apache.org>.
Github user galexandrov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/87#issuecomment-139878187
I'm not sure what do you mean by breaking the functionality in multiple page apps, but I checked how behave the plugin initialization in the other platforms for example in iOS the pluginInitialize function is invoked only once at start, so I was thinking that this is the correct behavior, because the implementation of the splashscreen for WP uses static variable in OnInit method to prevent the splashscreen to be shown second time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Move AutoLoadCommand execution in Framew...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/87#issuecomment-137091123
The plugins should be called for every page load, so while this is great the first time we break functionality in multi page apps.
I also worry that some plugins may depend on the js being ready and may currently be making calls to a DOM that wouldn't exist yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org