Re: [PATCH] Invoke 'store password' prompt for all commands requiring authentication

[Senthil Kumaran S <se...@collab.net>]

Hi,

Kannan R wrote:
> On Wednesday 07 October 2009 04:17 PM, Kannan wrote:
>> Stefan Sperling wrote:
> 
>>> Does this patch fix this case, too?
> 
> 
> [..]
> 
> /me digs from the list of yet-to-be-committed patches.

I ve attached a new patch which fixes this by calling
svn_ra_neon__maybe_store_auth_info() once, instead of the repeated calls as
cmpilato has pointed out. Kannan, can you confirm this solves the issue you
see? If so I shall commit the patch.

[[[
While working on a wc of a repo which needs authentication, 'store
password unencrypted' prompt is getting invoked only for those svn
commands that access the repo URL or that have an URL as argument
(eg. svn ls http://localhost/repo) and not for wc oriented commands
such as `svn ls' or `svn cat -r 5 test.c' which also require
authentication, which is solved here. This also fixes redundant
invokation of the function 'svn_ra_neon__maybe_store_auth_info' at
various places.

* subversion/libsvn_ra_neon/util.c
  (svn_ra_neon__request_create): Store auth credentials if we can.

* subversion/libsvn_ra_neon/session.c
  (svn_ra_neon__do_get_uuid): Remove redundant invocation.

* subversion/libsvn_ra_neon/commit.c
  (commit_close_edit): Remove redundant invocation.

* subversion/libsvn_ra_neon/fetch.c
  (svn_ra_neon__get_latest_revnum, reporter_finish_report): Remove
   redundant invocation.
]]]

Thank You.
-- 
Senthil Kumaran S
http://www.stylesen.org/

Re: [PATCH] Invoke 'store password' prompt for all commands requiring authentication

[Kannan R <ka...@collab.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 06 August 2010 06:22 PM, Senthil Kumaran S wrote:
> Hi,
>
> Kannan R wrote:
>> On Wednesday 07 October 2009 04:17 PM, Kannan wrote:
>>> Stefan Sperling wrote:
>>
>>>> Does this patch fix this case, too?
>>
>>
>> [..]
>>
>> /me digs from the list of yet-to-be-committed patches.
>
> I ve attached a new patch which fixes this by calling
> svn_ra_neon__maybe_store_auth_info() once, instead of the repeated calls as
> cmpilato has pointed out. Kannan, can you confirm this solves the issue you
> see? If so I shall commit the patch.
>
>
[..]

Yes, Senthil. This fixes the issue.


- -- 
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJMXA3EAAoJELQAaYkQr+e7glQIAK+kBECPTIAI6yo5WrKFZ9Ze
VhqW9k4yCXxEA0BPvGPFStX2sm3yCgH5llPYAxh+xQ1TAPpnWwQn1WloJDjT/nBv
tEGwWHNmtkhEjzoBc/7AgtCTLFYCMgY7BANVhFGfg2mHrb7tEAcF3lWq47o7pTpe
P8hNq/UGiosL077zVpHKeMyIaPizuwslZAYuy/CuKwfWxDIT3Umi63rXCNOm95dD
TT90Ge4NlvWe0LXZmvNWJp8GoDPuOgbr76qjdESUcken5Ipnn4rdfPEY+C94GUPP
3xwUJ/GHePalPiXOqfcNerZo+pqv8aFGhGpFoKZrhuDyddp6mdcPHGmAxNF5tso=
=rD9F
-----END PGP SIGNATURE-----