You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2015/02/02 16:09:49 UTC

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)

>is this change better?

Yes, it is better, but take into account that if the `isSoapPayload` returns false you are not updating the payload in the response, and the original input stream might be already read. I'd put the soap check inside the try/finally block to make sure the response always has a readable payload when exiting the method.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/128#issuecomment-72472553