DO NOT REPLY [Bug 22357] New: - isCancelled does not work as intended if ActionMapping does not have a form

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22357>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22357

isCancelled does not work as intended if ActionMapping does not have a form

           Summary: isCancelled does not work as intended if ActionMapping
                    does not have a form
           Product: Struts
           Version: 1.1 Final
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: Controller
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: patman_coda@yahoo.com


If the action mapping does not contain a form bean name, e.g.:

<action path="/this/action"
        type="action.class.name"/>

using isCancelled() in that action will always return false.  The code in 
org.apache.struts.action.RequestProcessor.processPopulate returns if the form 
is null before setting the Globals.CANCEL_KEY attribute.  

It seems to me that since a request parameter is used to detect the cancel 
button (the return request.getParameter(Constants.CANCEL_KEY) != null line), 
the setting of the request attribute should not depend on whether the action 
mapping uses a form.

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org