You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/11/21 03:08:47 UTC

[commons-configuration] branch master updated: Use final.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-configuration.git


The following commit(s) were added to refs/heads/master by this push:
     new aeaac81  Use final.
aeaac81 is described below

commit aeaac81808292ca7f7d16ce8dcb64cfee158c150
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 20 22:08:42 2020 -0500

    Use final.
---
 src/main/java/org/apache/commons/configuration2/io/FileLocator.java | 6 +++---
 .../configuration2/builder/TestFileBasedConfigurationBuilder.java   | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/main/java/org/apache/commons/configuration2/io/FileLocator.java b/src/main/java/org/apache/commons/configuration2/io/FileLocator.java
index 2257a97..7ad224e 100644
--- a/src/main/java/org/apache/commons/configuration2/io/FileLocator.java
+++ b/src/main/java/org/apache/commons/configuration2/io/FileLocator.java
@@ -208,7 +208,7 @@ public final class FileLocator
          * @param urlConnectionOptions the source URL connection options.
          * @return a reference to this builder for method chaining
          */
-        public FileLocatorBuilder urlConnectionOptions(URLConnectionOptions urlConnectionOptions) {
+        public FileLocatorBuilder urlConnectionOptions(final URLConnectionOptions urlConnectionOptions) {
             this.urlConnectionOptions = urlConnectionOptions;
             return this;
             
@@ -262,14 +262,14 @@ public final class FileLocator
      * @return a flag whether these objects are equal
      */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (this == obj) {
             return true;
         }
         if (!(obj instanceof FileLocator)) {
             return false;
         }
-        FileLocator other = (FileLocator) obj;
+        final FileLocator other = (FileLocator) obj;
         return Objects.equals(basePath, other.basePath) && Objects.equals(encoding, other.encoding)
             && Objects.equals(fileName, other.fileName) && Objects.equals(fileSystem, other.fileSystem)
             && Objects.equals(locationStrategy, other.locationStrategy) && Objects.equals(sourceURL, other.sourceURL)
diff --git a/src/test/java/org/apache/commons/configuration2/builder/TestFileBasedConfigurationBuilder.java b/src/test/java/org/apache/commons/configuration2/builder/TestFileBasedConfigurationBuilder.java
index 5257f2d..ed7f141 100644
--- a/src/test/java/org/apache/commons/configuration2/builder/TestFileBasedConfigurationBuilder.java
+++ b/src/test/java/org/apache/commons/configuration2/builder/TestFileBasedConfigurationBuilder.java
@@ -130,13 +130,13 @@ public class TestFileBasedConfigurationBuilder {
      */
     @Test
     public void testGetConfigurationLoadFromJarFile() throws ConfigurationException, IOException {
-        URL jarResourceUrl = getClass().getClassLoader().getResource("org/apache/commons/configuration2/test.jar");
+        final URL jarResourceUrl = getClass().getClassLoader().getResource("org/apache/commons/configuration2/test.jar");
         assertNotNull(jarResourceUrl);
         final Path testJar = Paths.get(folder.getRoot().getAbsolutePath(), "test.jar");
         try (final InputStream inputStream = jarResourceUrl.openStream()) {
             Files.copy(inputStream, testJar);
         }
-        URL url = new URL("jar:" + testJar.toUri() + "!/configuration.properties");
+        final URL url = new URL("jar:" + testJar.toUri() + "!/configuration.properties");
 
         //@formatter:off
         final FileBasedConfigurationBuilder<PropertiesConfiguration> builder =