You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2023/06/08 09:10:01 UTC

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1540: MINIFICPP-2082 Move RocksDB stats to RepositoryMetrics

lordgamez commented on code in PR #1540:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1540#discussion_r1222691788


##########
extensions/rocksdb-repos/RocksDbRepository.cpp:
##########
@@ -20,22 +20,30 @@ using namespace std::literals::chrono_literals;
 
 namespace org::apache::nifi::minifi::core::repository {
 
-void RocksDbRepository::printStats() {
+std::optional<RepositoryMetricsSource::RocksDbStats> RocksDbRepository::getRocksDbStats() const {

Review Comment:
   Updated in 0e772dd8719c74576dd9cf39be7fe395965afc96



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org