You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by DLotts <gi...@git.apache.org> on 2017/07/25 20:19:50 UTC
[GitHub] incubator-rya pull request #182: RYA-272 Geo refactoring and examples
GitHub user DLotts opened a pull request:
https://github.com/apache/incubator-rya/pull/182
RYA-272 Geo refactoring and examples
## Description
Refactored geo libraries into separate projects, added examples.
Geo libraries are optional and turned off by default because the GeoTools is has an incompatible license.
Further, geoWave and geoMesa depend on different versions of the GeoTools, so they must be in separate projects.
The new modules (projects) are
geo.common
geo.mongo
geo.geomesa
geo.geowave
These are modules of the project rya.geoindexing
### Tests
Existing tests and new examples.
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-272)
### Checklist
- [ ] Code Review
- [ ] Squash Commits
#### People To Reivew
@isper3at
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DLotts/incubator-rya geoExamples
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #182
----
commit cc32645120ae31516b14d55bc330eb080da67aab
Author: David Lotts <da...@parsons.com>
Date: 2017-06-14T21:50:11Z
geo examples commented out of the main examples and moved here.
commit c0a774044ddf434ebbaceae333310c7ba7512fac
Author: David Lotts <da...@parsons.com>
Date: 2017-07-03T21:21:50Z
WIP geo refactor, this has compile errors.
commit 4ecb7de186cc880c51389beb2b071070b4e7be81
Author: David Lotts <da...@parsons.com>
Date: 2017-07-19T21:39:32Z
WIP Refactored geo libraries into separate projects, new direct example that may not be running yet.
commit 4b05bf893048a074ef1a76bc584cc4957dc30333
Author: David Lotts <da...@parsons.com>
Date: 2017-07-25T20:00:19Z
refactoring geo folders, fixing examples.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r130933062
--- Diff: extras/rya.geoindexing/geo.common/pom.xml ---
@@ -0,0 +1,25 @@
+<?xml version='1.0'?>
+
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to
+ you under the Apache License, Version 2.0 (the "License"); you may not use
+ this file except in compliance with the License. You may obtain a copy of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.rya</groupId>
+ <artifactId>rya.geoindexing</artifactId>
+ <version>3.2.11-incubating-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>rya.geoCommon</artifactId>
--- End diff --
Please don't use camelcase in the artifactId. Either use rya.geocommon or rya.geo.common to keep with the current convention.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r130995765
--- Diff: extras/rya.geoindexing/geo.mongo/pom.xml ---
@@ -0,0 +1,29 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.rya</groupId>
+ <artifactId>rya.geoindexing</artifactId>
+ <version>3.2.11-incubating-SNAPSHOT</version>
+ </parent>
+ <artifactId>rya.geomongo</artifactId>
+ <name>Geo_indexing_for_mongo</name>
+ <description>Implementation of a geospatial indexing for mongo DB backed Rya</description>
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <geotools.version>16.0</geotools.version>
+ </properties>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.rya</groupId>
+ <artifactId>rya.geoCommon</artifactId>
+ <version>3.2.11-incubating-SNAPSHOT</version>
--- End diff --
This one line fixed all the old names.
find . -name \*.xml -exec sed -i 's/rya.geoCommon/geo.common/g' {} \; -ls
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r129997683
--- Diff: extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/GeoEnabledFilterFunctionOptimizer.java ---
@@ -98,18 +96,23 @@ public void setConf(final Configuration conf) {
init = false;
init();
}
-
+ /**
+ * Load instances of the selected indexers. This is tricky because some (geomesa vs geowave) have incompatible dependencies (geotools versions).
+ */
private synchronized void init() {
if (!init) {
- if (ConfigUtils.getUseMongo(conf)) {
- geoIndexer = new MongoGeoIndexer();
- geoIndexer.setConf(conf);
- freeTextIndexer = new MongoFreeTextIndexer();
- freeTextIndexer.setConf(conf);
- temporalIndexer = new MongoTemporalIndexer();
- temporalIndexer.setConf(conf);
+ if (ConfigUtils.getUseMongo(conf)) {
+ // create a new MongoGeoIndexer() without having it at compile time.
+ geoIndexer = instantiate(GeoIndexerType.MONGO_DB.getGeoIndexerClassString(), GeoIndexer.class);
+ geoIndexer.setConf(conf);
+ freeTextIndexer = new MongoFreeTextIndexer();
+ freeTextIndexer.setConf(conf);
+ temporalIndexer = new MongoTemporalIndexer();
+ temporalIndexer.setConf(conf);
} else {
- geoIndexer = new GeoMesaGeoIndexer();
+ //geoIndexer = new GeoMesaGeoIndexer();
--- End diff --
can you remove the commented out code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r129452144
--- Diff: extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/GeoIndexerType.java ---
@@ -31,31 +28,49 @@
/**
* Geo Mesa based indexer.
*/
- GEO_MESA(GeoMesaGeoIndexer.class),
+ GEO_MESA("org.apache.rya.indexing.accumulo.geo.GeoMesaGeoIndexer"),
/**
* Geo Wave based indexer.
*/
- GEO_WAVE(GeoWaveGeoIndexer.class),
+ GEO_WAVE("org.apache.rya.indexing.accumulo.geo.GeoWaveGeoIndexer"),
/**
* MongoDB based indexer.
*/
- MONGO_DB(MongoGeoIndexer.class);
+ MONGO_DB("org.apache.rya.indexing.mongodb.geo.MongoGeoIndexer"),
+
+ MONGO_GEO_TEMPORAL("org.apache.rya.indexing.geotemporal.mongo.MongoGeoTemporalIndexer"),
+ MONGO_GEO_TEMPORAL_OPTIMIZER("org.apache.rya.indexing.geotemporal.GeoTemporalOptimizer");
--- End diff --
the MongoGeoTemporal indexer is not a geoindexer, at least not as far as this class should be concerned
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r135904569
--- Diff: pom.xml ---
@@ -137,6 +137,7 @@ under the License.
<jcip.version>1.0-1</jcip.version>
<findbugs.plugin.version>3.0.4</findbugs.plugin.version>
<kafka.version>0.10.0.1</kafka.version>
+ <jopt-simple.version>4.9</jopt-simple.version>
--- End diff --
Done. Good catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r135310253
--- Diff: extras/rya.geoindexing/pom.xml ---
@@ -62,6 +79,11 @@
<groupId>org.apache.rya</groupId>
<artifactId>rya.prospector</artifactId>
</dependency>
+ <dependency>
+ <groupId>net.sf.jopt-simple</groupId>
+ <artifactId>jopt-simple</artifactId>
--- End diff --
Ug, I just looked deeper. it is using Strings class. It was probably supposed to be from Java standard libs or maybe the google lib.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r135292067
--- Diff: extras/rya.geoindexing/pom.xml ---
@@ -62,6 +79,11 @@
<groupId>org.apache.rya</groupId>
<artifactId>rya.prospector</artifactId>
</dependency>
+ <dependency>
+ <groupId>net.sf.jopt-simple</groupId>
+ <artifactId>jopt-simple</artifactId>
--- End diff --
this can be a follow on task - @jdasch can you document in jira? @DLotts just fix the rat issue and we can merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/443/<h2>Build result: FAILURE</span></h2>[...truncated 3.21 MB...][INFO] ------------------------------------------------------------------------[INFO] Total time: 25:21 min[INFO] Finished at: 2017-08-24T19:24:17+00:00[INFO] Final Memory: 232M/2942M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project geo.common: Compilation failure: Compilation failure:[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/accumulo/geo/GeoTupleSet.java:[52,27] package joptsimple.internal does not exist[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexin
g/accumulo/geo/GeoTupleSet.java:[152,25] cannot find symbol[ERROR] symbol: variable Strings[ERROR] location: class org.apache.rya.indexing.accumulo.geo.GeoTupleSet[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn <goals> -rf :geo.commonchannel stoppedSetting status of beaff5dfd71a14346e7b72696180219009e29532 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/443/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r130736014
--- Diff: extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/accumulo/geo/OptionalConfigUtils.java ---
@@ -104,26 +116,26 @@ public static void setIndexers(final RdfCloudTripleStoreConfiguration conf) {
if (ConfigUtils.getUseMongo(conf)) {
if (getUseGeo(conf)) {
- if (geoIndexerType == null) {
+ if (geoIndexerType == GeoIndexerType.UNSPECIFIED) {
// Default to MongoGeoIndexer if not specified
- indexList.add(MongoGeoIndexer.class.getName());
+ indexList.add(GeoIndexerType.MONGO_DB.getGeoIndexerClassString()); //MongoGeoIndexer.class.getName());
--- End diff --
remove commented out code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/463/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/451/<h2>Build result: FAILURE</span></h2>[...truncated 3.60 MB...][INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 39:12 min[INFO] Finished at: 2017-08-24T22:57:43+00:00[INFO] Final Memory: 301M/3184M[INFO] ------------------------------------------------------------------------Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project geo.geowave: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.geoindexing/geo.geowave/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of th
e errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn <goals> -rf :geo.geowavechannel stoppedSetting status of 651767575de77fb1c7ca11237e3b420f9875ccf8 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/451/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/347/<h2>Build result: FAILURE</span></h2>[...truncated 6.48 MB...][INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 23:24 min[INFO] Finished at: 2017-08-03T17:59:32+00:00[INFO] Final Memory: 398M/2938M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project geo.geowave: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.geoindexing/geo.geowave/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the
full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn <goals> -rf :geo.geowavechannel stoppedSetting status of 7b752c5972388be9014b26c1e0c7e0b61ea5c6be to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/347/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r130736405
--- Diff: extras/rya.geoindexing/geo.mongo/src/main/java/org/apache/rya/indexing/geoExamples/RyaMongoGeoDirectExample.java ---
@@ -0,0 +1,242 @@
+package org.apache.rya.indexing.geoExamples;
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.util.List;
+
+import org.apache.commons.lang.Validate;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.log4j.Logger;
+import org.apache.rya.indexing.GeoRyaSailFactory;
+import org.apache.rya.indexing.accumulo.ConfigUtils;
+import org.apache.rya.indexing.accumulo.geo.OptionalConfigUtils;
+import org.apache.rya.indexing.mongodb.MongoIndexingConfiguration;
+import org.apache.rya.indexing.mongodb.MongoIndexingConfiguration.MongoDBIndexingConfigBuilder;
+import org.apache.rya.mongodb.MockMongoFactory;
+import org.apache.rya.mongodb.MongoConnectorFactory;
+import org.openrdf.model.vocabulary.RDFS;
+import org.openrdf.query.BindingSet;
+import org.openrdf.query.MalformedQueryException;
+import org.openrdf.query.QueryEvaluationException;
+import org.openrdf.query.QueryLanguage;
+import org.openrdf.query.QueryResultHandlerException;
+import org.openrdf.query.TupleQuery;
+import org.openrdf.query.TupleQueryResultHandler;
+import org.openrdf.query.TupleQueryResultHandlerException;
+import org.openrdf.query.Update;
+import org.openrdf.query.UpdateExecutionException;
+import org.openrdf.repository.RepositoryException;
+import org.openrdf.repository.sail.SailRepository;
+import org.openrdf.repository.sail.SailRepositoryConnection;
+import org.openrdf.sail.Sail;
+
+import com.mongodb.MongoClient;
+import com.mongodb.ServerAddress;
+
+public class RyaMongoGeoDirectExample {
+ private static final Logger log = Logger.getLogger(RyaMongoGeoDirectExample.class);
+
+ //
+ // Connection configuration parameters
+ //
+
+ private static final boolean PRINT_QUERIES = true;
+ private static final String MONGO_DB = "rya";
+ private static final String MONGO_COLL_PREFIX = "rya_";
+ private static final boolean USE_MOCK = true;
+ private static final boolean USE_INFER = true;
+ private static final String MONGO_INSTANCE_URL = "localhost";
+ private static final String MONGO_INSTANCE_PORT = "27017";
+
+ public static void main(String[] args) throws Exception {
+ Configuration conf = getConf();
+ conf.setBoolean(ConfigUtils.DISPLAY_QUERY_PLAN, PRINT_QUERIES);
+ conf.setBoolean(OptionalConfigUtils.USE_GEO, true); // Note also the use of "GeoRyaSailFactory" below.
+ conf.setStrings(OptionalConfigUtils.GEO_PREDICATES_LIST, "http://www.opengis.net/ont/geosparql#asWKT"); // Note also the use of "GeoRyaSailFactory" below.
+
+ SailRepository repository = null;
+ SailRepositoryConnection conn = null;
+ try {
+ log.info("Connecting to Indexing Sail Repository.");
+ Sail sail = GeoRyaSailFactory.getInstance(conf);
+ repository = new SailRepository(sail);
+ conn = repository.getConnection();
+
+ long start = System.currentTimeMillis();
+ testAddPointAndWithinSearch(conn); // uses geospatial features
+
+ log.info("TIME: " + (System.currentTimeMillis() - start) / 1000.);
+ } finally {
+ log.info("Shutting down");
+ closeQuietly(conn);
+ closeQuietly(repository);
+ if (mock != null) {
+ mock.shutdown();
+ }
+ MongoConnectorFactory.closeMongoClient();
+ }
+ }
+/**
+ * Try out some geospatial data and queries
+ * @param repository
+ */
+ private static void testAddPointAndWithinSearch(SailRepositoryConnection conn) throws Exception {
+
+ String update = "PREFIX geo: <http://www.opengis.net/ont/geosparql#> "//
+ + "INSERT DATA { " //
+ + " <urn:feature> a geo:Feature ; " //
+ + " geo:hasGeometry [ " //
+ + " a geo:Point ; " //
+ + " geo:asWKT \"Point(-77.03524 38.889468)\"^^geo:wktLiteral "//
+ + " ] . " //
+ + "}";
+
+ Update u = conn.prepareUpdate(QueryLanguage.SPARQL, update);
+ u.execute();
+
+ String queryString;
+ TupleQuery tupleQuery;
+ CountingResultHandler tupleHandler;
+
+ // ring containing point
+ queryString = "PREFIX geo: <http://www.opengis.net/ont/geosparql#> "//
+ + "PREFIX geof: <http://www.opengis.net/def/function/geosparql/> "//
+ + "SELECT ?feature ?point ?wkt " //
+ + "{" //
+ + " ?feature a geo:Feature . "//
+ + " ?feature geo:hasGeometry ?point . "//
+ + " ?point a geo:Point . "//
+ + " ?point geo:asWKT ?wkt . "//
+ + " FILTER(geof:sfWithin(?wkt, \"POLYGON((-78 39, -77 39, -77 38, -78 38, -78 39))\"^^geo:wktLiteral)) " //
+ + "}";//
+ tupleQuery = conn.prepareTupleQuery(QueryLanguage.SPARQL, queryString);
+
+ tupleHandler = new CountingResultHandler();
+ tupleQuery.evaluate(tupleHandler);
+ log.info("Result count -- ring containing point: " + tupleHandler.getCount());
+ Validate.isTrue(tupleHandler.getCount() >= 1); // may see points from during previous runs
+
+ // ring outside point
+ queryString = "PREFIX geo: <http://www.opengis.net/ont/geosparql#> "//
+ + "PREFIX geof: <http://www.opengis.net/def/function/geosparql/> "//
+ + "SELECT ?feature ?point ?wkt " //
+ + "{" //
+ + " ?feature a geo:Feature . "//
+ + " ?feature geo:hasGeometry ?point . "//
+ + " ?point a geo:Point . "//
+ + " ?point geo:asWKT ?wkt . "//
+ + " FILTER(geof:sfWithin(?wkt, \"POLYGON((-77 39, -76 39, -76 38, -77 38, -77 39))\"^^geo:wktLiteral)) " //
+ + "}";//
+ tupleQuery = conn.prepareTupleQuery(QueryLanguage.SPARQL, queryString);
+
+ tupleHandler = new CountingResultHandler();
+ tupleQuery.evaluate(tupleHandler);
+ log.info("Result count -- ring outside point: " + tupleHandler.getCount());
+ Validate.isTrue(tupleHandler.getCount() == 0);
+ }
+
+ private static void closeQuietly(SailRepository repository) {
+ if (repository != null) {
+ try {
+ repository.shutDown();
+ } catch (RepositoryException e) {
+ // quietly absorb this exception
+ }
+ }
+ }
+
+ private static void closeQuietly(SailRepositoryConnection conn) {
+ if (conn != null) {
+ try {
+ conn.close();
+ } catch (RepositoryException e) {
+ // quietly absorb this exception
+ }
+ }
+ }
+
+ private static MockMongoFactory mock = null;
+ private static Configuration getConf() throws IOException {
+
+ MongoDBIndexingConfigBuilder builder = MongoIndexingConfiguration.builder()
+ .setUseMockMongo(USE_MOCK).setUseInference(USE_INFER).setAuths("U");
+
+ if (USE_MOCK) {
+ mock = MockMongoFactory.newFactory();
+ MongoClient c = mock.newMongoClient();
+ ServerAddress address = c.getAddress();
+ String url = address.getHost();
+ String port = Integer.toString(address.getPort());
+ c.close();
+ builder.setMongoHost(url).setMongoPort(port);
+ } else {
+ // User name and password must be filled in:
+ builder = builder.setMongoUser("fill this in")
+ .setMongoPassword("fill this in")
+ .setMongoHost(MONGO_INSTANCE_URL)
+ .setMongoPort(MONGO_INSTANCE_PORT);
+ }
+
+ return builder.setMongoDBName(MONGO_DB)
+ .setMongoCollectionPrefix(MONGO_COLL_PREFIX)
+ .setUseMongoFreetextIndex(true)
+ .setMongoFreeTextPredicates(RDFS.LABEL.stringValue()).build();
+
+ }
+
+
+ private static class CountingResultHandler implements TupleQueryResultHandler {
+ private int count = 0;
+
+ public int getCount() {
+ return count;
+ }
+
+// public void resetCount() {
--- End diff --
commented out code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r129997867
--- Diff: extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/GeoIndexerType.java ---
@@ -31,31 +28,49 @@
/**
* Geo Mesa based indexer.
*/
- GEO_MESA(GeoMesaGeoIndexer.class),
+ GEO_MESA("org.apache.rya.indexing.accumulo.geo.GeoMesaGeoIndexer"),
/**
* Geo Wave based indexer.
*/
- GEO_WAVE(GeoWaveGeoIndexer.class),
+ GEO_WAVE("org.apache.rya.indexing.accumulo.geo.GeoWaveGeoIndexer"),
/**
* MongoDB based indexer.
*/
- MONGO_DB(MongoGeoIndexer.class);
+ MONGO_DB("org.apache.rya.indexing.mongodb.geo.MongoGeoIndexer"),
+
+ MONGO_GEO_TEMPORAL("org.apache.rya.indexing.geotemporal.mongo.MongoGeoTemporalIndexer"),
+ MONGO_GEO_TEMPORAL_OPTIMIZER("org.apache.rya.indexing.geotemporal.GeoTemporalOptimizer");
- private Class<? extends GeoIndexer> geoIndexerClass;
+ //private Class<? extends GeoIndexer> geoIndexerClass;
+ private String geoIndexerClassString;
/**
* Creates a new {@link GeoIndexerType}.
* @param geoIndexerClass the {@link GeoIndexer} {@link Class}.
* (not {@code null})
*/
- private GeoIndexerType(final Class<? extends GeoIndexer> geoIndexerClass) {
- this.geoIndexerClass = checkNotNull(geoIndexerClass);
+ private GeoIndexerType(final String geoIndexerClassString) {
+ this.geoIndexerClassString = checkNotNull(geoIndexerClassString);
}
/**
* @return the {@link GeoIndexer} {@link Class}. (not {@code null})
*/
- public Class<? extends GeoIndexer> getGeoIndexerClass() {
- return geoIndexerClass;
- }
+ public String getGeoIndexerClassString() {
+
+ return geoIndexerClassString;
+ }
+
+ /**
+ * @return True if the class exists on the classpath.
+ */
+ public boolean isOnClassPath() {
+ try {
+ Class.forName(geoIndexerClassString, false, this.getClass().getClassLoader());
--- End diff --
I agree. A factory seems like a better pattern, it seems like we could be doing something more elegant here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/328/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/276/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/278/<h2>Build result: ABORTED</span></h2>[...truncated 6.55 MB...][INFO] [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ rya.pcj.fluo.demo ---[INFO] Building jar: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.pcj.fluo/pcj.fluo.demo/target/rya.pcj.fluo.demo-3.2.11-incubating-SNAPSHOT.jar[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 14 iota=59[INFO] [INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ rya.pcj.fluo.demo ---[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 14 iota=59[INFO] [INFO] --- maven-source-plugin:2.4:jar-no-fork (attach-sources) @ rya.pcj.fluo.demo ---[INFO] Building jar: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-op
tionals-pull-requests/extras/rya.pcj.fluo/pcj.fluo.demo/target/rya.pcj.fluo.demo-3.2.11-incubating-SNAPSHOT-sources.jar[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 14 iota=59[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: Invalid object ID 14 iota=59[INFO] [INFO] --- maven-jar-plugin:2.5:test-jar (default) @ rya.pcj.fluo.demo ---[INFO] Building jar: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.pcj.fluo/pcj.fluo.demo/target/rya.pcj.fluo.demo-3.2.11-incubating-SNAPSHOT-tests.jar[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 14 iota=59[INFO] [INFO] --- maven-assembly-plugin:2.4.1:single (make-assembly) @ rya.pcj.fluo.demo ---Adding org.apache.maven.scm.provider.ScmProvidersvnBuild was abortedchannel stoppedSetting status of bc80340c5
5806317c2336dbde7032c8a476c235d to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/278/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r135870993
--- Diff: extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/GeoIndexerType.java ---
@@ -31,31 +28,49 @@
/**
* Geo Mesa based indexer.
*/
- GEO_MESA(GeoMesaGeoIndexer.class),
+ GEO_MESA("org.apache.rya.indexing.accumulo.geo.GeoMesaGeoIndexer"),
--- End diff --
Would recommend a JIRA for adding the Service Loader (or other solution) be referenced to this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/324/<h2>Build result: ABORTED</span></h2>[...truncated 6.65 MB...][INFO] [INFO] ------------------------------------------------------------------------[INFO] Building Apache Rya PCJ Fluo Demo 3.2.11-incubating-SNAPSHOT[INFO] ------------------------------------------------------------------------[INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ rya.pcj.fluo.demo ---[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 14 iota=59[INFO] [INFO] --- apache-rat-plugin:0.11:check (check-licenses) @ rya.pcj.fluo.demo ---[INFO] 51 implicit excludes (use -debug for more details).[INFO] Exclude: **/resources/META-INF/services/**[INFO] 4 resources included (use -debug for more details)[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 ge
nerated: 0 approved: 4 licence.[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 14 iota=59[INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-mvn) @ rya.pcj.fluo.demo ---Build was aborted[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 14 iota=59[INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ rya.pcj.fluo.demo ---channel stoppedSetting status of 490869950441b0e0d7aa10f3b95cf9b7691376dc to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/324/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/338/<h2>Build result: FAILURE</span></h2>[...truncated 7.10 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 29:52 min[INFO] Finished at: 2017-08-02T21:56:49+00:00[INFO] Final Memory: 499M/3383M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project geo.geowave: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.geoindexin
g/geo.geowave/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn <goals> -rf :geo.geowavechannel stoppedSetting status of ccc4fea642df499e9f0476277abc686ee797dbd3 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/338/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/346/<h2>Build result: FAILURE</span></h2>[...truncated 6.94 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 28:21 min[INFO] Finished at: 2017-08-03T17:43:07+00:00[INFO] Final Memory: 325M/2928M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project geo.geowave: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.geoindexin
g/geo.geowave/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn <goals> -rf :geo.geowavechannel stoppedSetting status of eecd61458b7b0a2a022b9436bab3ab2210ddab42 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/346/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/333/<h2>Build result: FAILURE</span></h2>[...truncated 6.96 MB...][INFO] Total time: 44:09 min[INFO] Finished at: 2017-08-02T15:51:54+00:00[INFO] Final Memory: 250M/3314M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project rya.geoCommon: Compilation failure[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/accumulo/geo/OptionalConfigUtils.java:[86,33] method getStrings in class org.apache.hadoop.conf.Configuration cannot be applied to given types;[ERROR] required: java.lang.String,java.lang.String[][ERROR] found: java.lang.String,org.apache.rya.indexing.GeoIndexerType[ERROR] reason: varargs mismatch; org.apache.rya.indexing.GeoIndexerType canno
t be converted to java.lang.String[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn <goals> -rf :rya.geoCommonchannel stoppedSetting status of 881f2589a85181901b9a9b539a32e8c68b303d05 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/333/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/449/<h2>Build result: FAILURE</span></h2>[...truncated 3.52 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 28:37 min[INFO] Finished at: 2017-08-24T22:02:12+00:00[INFO] Final Memory: 464M/3011M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project geo.geowave: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.geoindexin
g/geo.geowave/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn <goals> -rf :geo.geowavechannel stoppedSetting status of 651767575de77fb1c7ca11237e3b420f9875ccf8 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/449/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r130991587
--- Diff: extras/rya.geoindexing/geo.mongo/pom.xml ---
@@ -0,0 +1,29 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.rya</groupId>
+ <artifactId>rya.geoindexing</artifactId>
+ <version>3.2.11-incubating-SNAPSHOT</version>
+ </parent>
+ <artifactId>rya.geomongo</artifactId>
+ <name>Geo_indexing_for_mongo</name>
+ <description>Implementation of a geospatial indexing for mongo DB backed Rya</description>
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <geotools.version>16.0</geotools.version>
+ </properties>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.rya</groupId>
+ <artifactId>rya.geoCommon</artifactId>
+ <version>3.2.11-incubating-SNAPSHOT</version>
--- End diff --
and the name is wrong here too. geo.common
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/280/<h2>Build result: FAILURE</span></h2>[...truncated 8.67 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 44:49 min[INFO] Finished at: 2017-07-26T15:55:19+00:00[INFO] Final Memory: 212M/1136M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.geowave: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.geoindexin
g/geo.geowave/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn <goals> -rf :rya.geowavechannel stoppedSetting status of bc80340c55806317c2336dbde7032c8a476c235d to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/280/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r130933831
--- Diff: extras/rya.geoindexing/geo.common/pom.xml ---
@@ -0,0 +1,25 @@
+<?xml version='1.0'?>
+
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to
+ you under the Apache License, Version 2.0 (the "License"); you may not use
+ this file except in compliance with the License. You may obtain a copy of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.rya</groupId>
+ <artifactId>rya.geoindexing</artifactId>
+ <version>3.2.11-incubating-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>rya.geoCommon</artifactId>
+ <name>Apache Rya Geospatial Secondary Indexing (Optional)</name>
--- End diff --
update name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/460/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Nit on artifact names. Please make them consistent with other artifacts:
```
[INFO] Reactor Build Order:
[INFO]
[INFO] Apache Rya Project
[INFO] Apache Rya Common Projects
[INFO] Apache Rya Common API
[INFO] Apache Rya Provenance
[INFO] Apache Rya DAO Projects
[INFO] Apache Rya Accumulo DAO
[INFO] Apache Rya MongoDB DAO
[INFO] Apache Rya Extra Projects
[INFO] Apache Rya Prospector
[INFO] Apache Rya Manual
[INFO] Apache Rya SAIL
[INFO] Apache Rya PCJ Core
[INFO] Apache Rya PCJ Fluo Parent
[INFO] Apache Rya PCJ Fluo App
[INFO] Apache Rya PCJ Fluo API
[INFO] Apache Rya Secondary Indexing
[INFO] Apache Rya Console
[INFO] Apache Rya Secondary Indexing Example
[INFO] Apache Rya MapReduce Tools
[INFO] Apache Rya Reasoning
[INFO] Apache Rya Vagrant VM
[INFO] Apache Rya PCJ Fluo Client
[INFO] Apache Rya PCJ Fluo Integration Tests
[INFO] Apache Rya PCJ Fluo Demo
[INFO] Apache Rya Export Parent
[INFO] Apache Rya Export API
[INFO] Apache Rya Export Accumulo
[INFO] Apache Rya Export Mongo
[INFO] Apache Rya Export Client
[INFO] Apache Rya Export Integration Tests
[INFO] Apache Rya Merge Tool
[INFO] Apache Rya Giraph
[INFO] Apache Rya Benchmarks
[INFO] Geo indexing parent for multiple geo implementations
[INFO] Apache Rya Geospatial Secondary Indexing (Optional)
[INFO] Geo Indexing using GeoMesa
[INFO] Geo indexing using GeoWave
[INFO] Geo indexing for mongo
[INFO] Apache Rya OSGI Bundle
[INFO] Apache Rya ALX
[INFO] Apache Rya ALX Console
[INFO] Apache Rya Camel
[INFO] Apache Rya Pig Projects
[INFO] Apache Rya Accumulo Pig
[INFO] Apache Rya Spark Support
[INFO] Apache Rya Web Projects
[INFO] Apache Rya Web Implementation
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on the issue:
https://github.com/apache/incubator-rya/pull/182
hey @DLotts you have a rat failure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on the issue:
https://github.com/apache/incubator-rya/pull/182
In general, this looks ok -- I agree with Andrew's comments but I'm not sure that that should hold up merging this pr -- introducing a factory could be done as a follow on task if it is documented in jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r135877423
--- Diff: extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/GeoIndexerType.java ---
@@ -31,31 +28,49 @@
/**
* Geo Mesa based indexer.
*/
- GEO_MESA(GeoMesaGeoIndexer.class),
+ GEO_MESA("org.apache.rya.indexing.accumulo.geo.GeoMesaGeoIndexer"),
--- End diff --
JIRA didn't exist. Added RYA-354.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on the issue:
https://github.com/apache/incubator-rya/pull/182
this fixes RYA-324 and RYA-272
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/461/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on the issue:
https://github.com/apache/incubator-rya/pull/182
I know that we planned to commit this PR to master first, but #186 is ready to go.
I looked at this and #186. It turns out that we can commit #186 into master, then commit this PR, and we won't have any merge issues. Since #186 is ready now, I'm going to commit it, and then assist you with any issues you have merging this PR.
--Aaron
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r130934111
--- Diff: extras/rya.geoindexing/geo.mongo/pom.xml ---
@@ -0,0 +1,29 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.rya</groupId>
+ <artifactId>rya.geoindexing</artifactId>
+ <version>3.2.11-incubating-SNAPSHOT</version>
+ </parent>
+ <artifactId>rya.geomongo</artifactId>
+ <name>Geo_indexing_for_mongo</name>
--- End diff --
remove underscores
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/330/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on the issue:
https://github.com/apache/incubator-rya/pull/182
asfbot build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r129453060
--- Diff: extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/accumulo/geo/OptionalConfigUtils.java ---
@@ -81,7 +82,17 @@ public static boolean getUseGeoTemporal(final Configuration conf) {
* {@code null} if it doesn't exist.
*/
public static GeoIndexerType getGeoIndexerType(final Configuration conf) {
- return conf.getEnum(GEO_INDEXER_TYPE, null);
+ String confType[] = conf.getStrings(GEO_INDEXER_TYPE);
--- End diff --
there should be a get() that has a default value so you don't need to do a null check on confType
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r135169942
--- Diff: extras/rya.geoindexing/pom.xml ---
@@ -62,6 +79,11 @@
<groupId>org.apache.rya</groupId>
<artifactId>rya.prospector</artifactId>
</dependency>
+ <dependency>
+ <groupId>net.sf.jopt-simple</groupId>
+ <artifactId>jopt-simple</artifactId>
--- End diff --
I didn't dig in to see where this is getting used, but can we swap this dependency for JCommander? I'd prefer to standardize on a single CLI Parsing framework, and JCommander is used throughout Rya.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/459/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r130990825
--- Diff: extras/rya.geoindexing/geo.common/pom.xml ---
@@ -0,0 +1,25 @@
+<?xml version='1.0'?>
+
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to
+ you under the Apache License, Version 2.0 (the "License"); you may not use
+ this file except in compliance with the License. You may obtain a copy of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.rya</groupId>
+ <artifactId>rya.geoindexing</artifactId>
+ <version>3.2.11-incubating-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>rya.geoCommon</artifactId>
--- End diff --
Good catch! I changed the name weeks ago, but artifact name was not changed automatically by eclipse.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r135881634
--- Diff: pom.xml ---
@@ -137,6 +137,7 @@ under the License.
<jcip.version>1.0-1</jcip.version>
<findbugs.plugin.version>3.0.4</findbugs.plugin.version>
<kafka.version>0.10.0.1</kafka.version>
+ <jopt-simple.version>4.9</jopt-simple.version>
--- End diff --
remove this line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r129452909
--- Diff: extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/GeoIndexerType.java ---
@@ -31,31 +28,49 @@
/**
* Geo Mesa based indexer.
*/
- GEO_MESA(GeoMesaGeoIndexer.class),
+ GEO_MESA("org.apache.rya.indexing.accumulo.geo.GeoMesaGeoIndexer"),
/**
* Geo Wave based indexer.
*/
- GEO_WAVE(GeoWaveGeoIndexer.class),
+ GEO_WAVE("org.apache.rya.indexing.accumulo.geo.GeoWaveGeoIndexer"),
/**
* MongoDB based indexer.
*/
- MONGO_DB(MongoGeoIndexer.class);
+ MONGO_DB("org.apache.rya.indexing.mongodb.geo.MongoGeoIndexer"),
+
+ MONGO_GEO_TEMPORAL("org.apache.rya.indexing.geotemporal.mongo.MongoGeoTemporalIndexer"),
+ MONGO_GEO_TEMPORAL_OPTIMIZER("org.apache.rya.indexing.geotemporal.GeoTemporalOptimizer");
- private Class<? extends GeoIndexer> geoIndexerClass;
+ //private Class<? extends GeoIndexer> geoIndexerClass;
+ private String geoIndexerClassString;
/**
* Creates a new {@link GeoIndexerType}.
* @param geoIndexerClass the {@link GeoIndexer} {@link Class}.
* (not {@code null})
*/
- private GeoIndexerType(final Class<? extends GeoIndexer> geoIndexerClass) {
- this.geoIndexerClass = checkNotNull(geoIndexerClass);
+ private GeoIndexerType(final String geoIndexerClassString) {
+ this.geoIndexerClassString = checkNotNull(geoIndexerClassString);
}
/**
* @return the {@link GeoIndexer} {@link Class}. (not {@code null})
*/
- public Class<? extends GeoIndexer> getGeoIndexerClass() {
- return geoIndexerClass;
- }
+ public String getGeoIndexerClassString() {
+
+ return geoIndexerClassString;
+ }
+
+ /**
+ * @return True if the class exists on the classpath.
+ */
+ public boolean isOnClassPath() {
+ try {
+ Class.forName(geoIndexerClassString, false, this.getClass().getClassLoader());
--- End diff --
I have serious concerns about using this. exception handling shouldn't be used as a conditional checker, and ideally this should be done by another class that uses the config option based on the enum to just instantiate the geo indexer. A factory should be used here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/337/<h2>Build result: FAILURE</span></h2>[...truncated 6.96 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 29:14 min[INFO] Finished at: 2017-08-02T20:55:43+00:00[INFO] Final Memory: 256M/3207M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.geowave: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests@2/extras/rya.geoindex
ing/geo.geowave/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn <goals> -rf :rya.geowavechannel stoppedSetting status of 2df0d571133eea02a9597bbf7caa6cc99c577e2e to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/337/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r130736574
--- Diff: extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/accumulo/geo/OptionalConfigUtils.java ---
@@ -81,7 +82,17 @@ public static boolean getUseGeoTemporal(final Configuration conf) {
* {@code null} if it doesn't exist.
*/
public static GeoIndexerType getGeoIndexerType(final Configuration conf) {
- return conf.getEnum(GEO_INDEXER_TYPE, null);
+ String confType[] = conf.getStrings(GEO_INDEXER_TYPE);
--- End diff --
did not address this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rya/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/336/<h2>Build result: FAILURE</span></h2>[...truncated 7.42 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 58:50 min[INFO] Finished at: 2017-08-02T21:00:40+00:00[INFO] Final Memory: 281M/2629M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.geowave: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.geoindexin
g/geo.geowave/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn <goals> -rf :rya.geowavechannel stoppedSetting status of 6a94e7b59bd4b6d29e9df74f60c1a31493421862 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/336/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on the issue:
https://github.com/apache/incubator-rya/pull/182
hey @DLotts ?can you fix the merge conflict
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r130934538
--- Diff: extras/rya.geoindexing/geo.mongo/pom.xml ---
@@ -0,0 +1,29 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.rya</groupId>
+ <artifactId>rya.geoindexing</artifactId>
+ <version>3.2.11-incubating-SNAPSHOT</version>
+ </parent>
+ <artifactId>rya.geomongo</artifactId>
+ <name>Geo_indexing_for_mongo</name>
+ <description>Implementation of a geospatial indexing for mongo DB backed Rya</description>
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <geotools.version>16.0</geotools.version>
+ </properties>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.rya</groupId>
+ <artifactId>rya.geoCommon</artifactId>
+ <version>3.2.11-incubating-SNAPSHOT</version>
--- End diff --
version should be defined by parent pom dependencyManagement section
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/182
Please rename these Maven artifactIds. This helps to avoid artifact name collisions and eases jar identification.
geo.common ==> rya.geo.common
geo.geomesa ==> rya.geo.geomesa
geo.geowave ==> rya.geo.geowave
geo.mongo ==> rya.geo.mongo
No need to rename anything in the filesystem, just in the poms -- although, you could drop the 'geo.' in the filepath if you really really wanted to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r129998163
--- Diff: web/web.rya/maven-eclipse.xml ---
@@ -0,0 +1,8 @@
+<project default="copy-resources">
+ <target name="init"/>
+ <target name="copy-resources" depends="init">
+ <copy todir="target/classes/home/dlotts2/dev/ryaws/ryal/web/web.rya/target" filtering="true">
--- End diff --
this file probably wasn't supposed to be checked in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on the issue:
https://github.com/apache/incubator-rya/pull/182
asfbot build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---