You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by rbnks <gi...@git.apache.org> on 2014/09/19 22:34:00 UTC
[GitHub] incubator-streams pull request: Streams 179
GitHub user rbnks opened a pull request:
https://github.com/apache/incubator-streams/pull/91
Streams 179
Added an executor to call stop() on a stream when a thread exits due to error.
I have issued a pull request so that local streams will now shutdown if a provider, processor, or writer tasks stops execution due to an unhandled throwable. This should be a step forward in making streams more transparent and reliable on the local level. The Throwable will appear in the logs and it will note which Runnable class threw the error.
This is intended to only be a temporary fix. This will illuminate many streams operations that have bugs, and need better testing. Please create tickets for all exceptions that are caused by bugs and issue pull requests (with appropriate tests and documentions) to fix them.
In the future we can relaunch threads that exit due to error, and reprocess the failed datum. Until we implemented better datum tacking this is not possible, but it is on the road map.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rbnks/incubator-streams STREAMS-179
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit 507e67962e97e5e6b4c1de0bc0789c25804cd6af
Author: Ryan Ebanks <ry...@raveldata.com>
Date: 2014-09-19T16:03:37Z
Merge pull request #4 from apache/master
Merge Apache Master
commit e091c6ccc4f6ca849a638402ce8de5a7d73a8df0
Author: Ryan Ebanks <re...@informations-macbook-pro-3.local>
Date: 2014-09-19T20:22:32Z
STREAMS-179 | Added new thread pool executor to shutdown streams
commit 2397f4b480448ebd3e1a3c4efa4d9dc5ef64750a
Author: Ryan Ebanks <re...@informations-macbook-pro-3.local>
Date: 2014-09-19T20:24:22Z
STREAMS-179 | Added javdoc comments.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 179
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on the pull request:
https://github.com/apache/incubator-streams/pull/91#issuecomment-56399993
There are other catches in the tasks. This is just a final failsafe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 179
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on the pull request:
https://github.com/apache/incubator-streams/pull/91#issuecomment-56390818
:+1: I can
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 179
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 179
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/incubator-streams/pull/91#issuecomment-56391289
Thanks Matt!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 179
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/incubator-streams/pull/91#issuecomment-56282012
So could anybody merge this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 179
Posted by smashew <gi...@git.apache.org>.
Github user smashew commented on the pull request:
https://github.com/apache/incubator-streams/pull/91#issuecomment-56391525
Why aren't there exceptions that can be thrown during processing? Seems odd that there is no way to report or trap any exceptions (other than termination) during execution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---