You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2012/06/14 00:14:47 UTC

[Bug 53412] New: [PATCH] o.a.f.fo.properties.CondLengthProperty.equals() uses object identity

https://issues.apache.org/bugzilla/show_bug.cgi?id=53412

          Priority: P2
            Bug ID: 53412
          Assignee: fop-dev@xmlgraphics.apache.org
           Summary: [PATCH]
                    o.a.f.fo.properties.CondLengthProperty.equals() uses
                    object identity
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: alex.giotis@gmail.com
          Hardware: All
            Status: NEW
           Version: 1.1dev
         Component: fo tree
           Product: Fop

Created attachment 28935
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28935&action=edit
Test FO

Due to the usage of object identity to compare two objects for equality, the
org.apache.fop.fo.properties.PropertyCache is not working effectively. This
applies to instances of CondLengthProperty and CommonBorderPaddingBackground
instances that use it.

The test case was provided by Ron Vandenbranden, see
http://markmail.org/message/vvr2k4cii3273fos

Before applying the patch, transforming the attached FO to PDF logs the
messages:
INFO: 10 hashCode() collisions for
org.apache.fop.fo.properties.CondLengthProperty
Jun 14, 2012 1:12:27 AM org.apache.fop.fo.properties.PropertyCache fetch
INFO: 10 hashCode() collisions for
org.apache.fop.fo.properties.CommonBorderPaddingBackground

After applying the patch, there should be no log messages related to hashCode()
collisions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53412] [PATCH] o.a.f.fo.properties.CondLengthProperty.equals() uses object identity

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53412

--- Comment #1 from Alex Giotis <al...@gmail.com> ---
Created attachment 28936
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28936&action=edit
Patch fixing the equals() implementation of CondLengthProperty

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53412] [PATCH] o.a.f.fo.properties.CondLengthProperty.equals() uses object identity

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53412

--- Comment #2 from Glenn Adams <ga...@apache.org> ---
patch applied at http://svn.apache.org/viewvc?rev=1350379&view=rev

thanks Alex! please review and close if satisfied

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53412] [PATCH] o.a.f.fo.properties.CondLengthProperty.equals() uses object identity

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53412

Glenn Adams <ga...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53412] [PATCH] o.a.f.fo.properties.CondLengthProperty.equals() uses object identity

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53412

Alex Giotis <al...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.