You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2020/03/03 22:29:52 UTC

[maven-dependency-plugin] branch ex3 updated: remove unused fields

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch ex3
in repository https://gitbox.apache.org/repos/asf/maven-dependency-plugin.git


The following commit(s) were added to refs/heads/ex3 by this push:
     new 38a3cce  remove unused fields
38a3cce is described below

commit 38a3cce771a716b1719f77a543f60138106f51b8
Author: Elliotte Rusty Harold <el...@google.com>
AuthorDate: Tue Mar 3 17:29:40 2020 -0500

    remove unused fields
---
 .../utils/translators/TestClassifierTypeTranslator.java       | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/src/test/java/org/apache/maven/plugins/dependency/utils/translators/TestClassifierTypeTranslator.java b/src/test/java/org/apache/maven/plugins/dependency/utils/translators/TestClassifierTypeTranslator.java
index 02f2bb8..5c202a6 100644
--- a/src/test/java/org/apache/maven/plugins/dependency/utils/translators/TestClassifierTypeTranslator.java
+++ b/src/test/java/org/apache/maven/plugins/dependency/utils/translators/TestClassifierTypeTranslator.java
@@ -37,9 +37,7 @@ import org.apache.maven.plugin.testing.stubs.MavenProjectStub;
 import org.apache.maven.plugin.testing.stubs.StubArtifactRepository;
 import org.apache.maven.plugins.dependency.AbstractDependencyMojoTestCase;
 import org.apache.maven.plugins.dependency.testUtils.DependencyArtifactStubFactory;
-import org.apache.maven.project.ProjectBuildingRequest;
 import org.apache.maven.shared.transfer.artifact.ArtifactCoordinate;
-import org.apache.maven.shared.transfer.repository.RepositoryManager;
 import org.sonatype.aether.impl.internal.SimpleLocalRepositoryManager;
 import org.sonatype.aether.util.DefaultRepositorySystemSession;
 
@@ -57,12 +55,10 @@ public class TestClassifierTypeTranslator
 
     Log log = new SilentLog();
 
-    private RepositoryManager repoManager;
-
-    private ProjectBuildingRequest buildingRequest;
 
     private ArtifactHandlerManager artifactHandlerManager;
 
+    @Override
     protected void setUp()
         throws Exception
     {
@@ -79,10 +75,8 @@ public class TestClassifierTypeTranslator
         DependencyArtifactStubFactory factory = new DependencyArtifactStubFactory( null, false );
         artifacts = factory.getMixedArtifacts();
 
-        repoManager = lookup( RepositoryManager.class );
 
         MavenSession session = newMavenSession( new MavenProjectStub() );
-        buildingRequest = session.getProjectBuildingRequest();
 
         DefaultRepositorySystemSession repoSession = (DefaultRepositorySystemSession) session.getRepositorySession();
         repoSession.setLocalRepositoryManager( new SimpleLocalRepositoryManager( stubFactory.getWorkingDir() ) );
@@ -184,8 +178,7 @@ public class TestClassifierTypeTranslator
             {
                 ArtifactCoordinate translatedArtifact = resultIter.next();
                 if ( artifact.getArtifactId() == translatedArtifact.getArtifactId()
-                    && artifact.getGroupId() == translatedArtifact.getGroupId()
-                /* && artifact.getScope() == translatedArtifact.getScope() */ )
+                    && artifact.getGroupId() == translatedArtifact.getGroupId() )
                 {
                     assertEquals( translatedArtifact.getClassifier(), classifier );
                     assertEquals( translatedArtifact.getExtension(), type );