[jira] [Commented] (SOLR-9303) Refactor CloudSolrClient for extensibility

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823301#comment-15823301 ] 

ASF GitHub Bot commented on SOLR-9303:
--------------------------------------

Github user paulo-raca commented on the issue:

    https://github.com/apache/lucene-solr/pull/51
  
    Nobody cares, closing it


> Refactor CloudSolrClient for extensibility
> ------------------------------------------
>
>                 Key: SOLR-9303
>                 URL: https://issues.apache.org/jira/browse/SOLR-9303
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrJ
>    Affects Versions: 5.4, 6.0
>            Reporter: Paulo Costa
>            Priority: Minor
>              Labels: SolrCloud, solrj
>             Fix For: 6.1
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> I'm using a custom Solr plugins which adds extra constraints on which nodes I can access.
> To respect these constraints, I needed to use a customized version of CloudSolrClient.
> Unfortunately, CloudSolrClient.sendRequest() is currently written as one big chunk of code, breaking OO's SOLID principle and making it is impossible for me to customize it on a subclass.
> I suggest we refactor this method in 3 steps: 
> - Finding the usable URLs
> - Checking if a node can be used for this request
> - Executing the request



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org