[GitHub] [flink] dawidwys commented on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet

[GitBox <gi...@apache.org>]

dawidwys commented on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-591442453
 
 
   Hi @cpugputpu.
   I agree with @StephanEwen that we should rather adjust the `DeeplyEqualsChecker`. I wonder though if it would make more sense to actually remove the branches for `Iterable` and  `Row`.
   It might have been a mistake to add those very specific cases into the general equality checker.
   I think it was unnecessary to unify that deep equality check for all `Iterables` cause as far as I can tell we do not test serializing lists of arrays.
   
   I tried removing those and run the tests and all the tests seem to pass.
   
   I think we should rather assume that objects have properly implemented `equals` methods. If they do not, a more complex equality check can happen in that particular test. Therefore I think it still make sense to have the generic way of ingesting the `equalityChecker`, but we should not unify too many checkers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services