You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/09/20 21:20:44 UTC
[GitHub] tinkerpop pull request #429: TINKERPOP-1457 Fixed Lambda serialization in by...
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/429
TINKERPOP-1457 Fixed Lambda serialization in bytecode for java/groovy.
https://issues.apache.org/jira/browse/TINKERPOP-1457
Standard tests using lambdas are ignored which is why we didn't catch this in the process tests. I added a single test to `GremlinServerIntegrationTest` to just validate that lambdas could be sent, so we at least have a basic smoke test for that functionality.
Also opened up a few tests by removing some `OptOut` entries on `RemoteGraph`.
All tests pass with:
```text
$ mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false
```
Going to kick off a full docker build tonight too.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1457
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/429.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #429
----
commit 6b03f61723837809c61951a516d5a8207d8d18f1
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-20T20:24:34Z
Fixed Lambda serialization in bytecode for java/groovy.
Standard tests using lambdas are ignored which is why we didn't catch this in the process tests. I added a single test to GremlinServerIntegrationTest to just validate that lambdas could be sent, so we at least have a basic smoke test for that functionality.
commit f5ef7c13bce8f9f2b0a057c6c2c26d26a32c1e09
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-20T21:18:18Z
Removed some OptOuts on RemoteGraph.
More tests seem to be working now after the GraphSON 2.0 implementation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #429: TINKERPOP-1457 Fixed Lambda serialization in bytecode ...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/429
`docker/build.sh -t -i -n` succeeded.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #429: TINKERPOP-1457 Fixed Lambda serialization in by...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/429
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #429: TINKERPOP-1457 Fixed Lambda serialization in bytecode ...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/429
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---