[jira] [Comment Edited] (WICKET-5573) FilterToolbar generics broken

["Andrea Del Bene (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997606#comment-13997606 ] 

Andrea Del Bene edited comment on WICKET-5573 at 5/14/14 2:54 PM:
------------------------------------------------------------------

Sorry, my fault. There is no problem with  clirr-maven-plugin. I think this change is perfectly safe


was (Author: bitstorm):
Sorry, my fault. There is no problem with  clirr-maven-plugin. 

> FilterToolbar generics broken
> -----------------------------
>
>                 Key: WICKET-5573
>                 URL: https://issues.apache.org/jira/browse/WICKET-5573
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 6.15.0
>            Reporter: Leszek Gawron
>
> Once you were able to create DataTable<User> wrapped inside of
> FilterForm<UserFilterDto>
> currently FilterToolbar requires you for those two types to be identical:
> {code}
> public <T, S> FilterToolbar(final DataTable<T, S> table, final
> FilterForm<T> form,
> final IFilterStateLocator<T> stateLocator)
> {code}
> It looks like commit 9b3f9ca1df064fe9c6fde64ccc37fecc504b09a6
> introduced a bug long time ago and it carried on:
> {code}
> -       public <T> FilterToolbar(final DataTable<?> table, final
> FilterForm<T> form,
> +       public <T> FilterToolbar(final DataTable<T> table, final
> FilterForm<T> form,
> {code}
> FilterToolbar constructor should state:
> {code}
> public <T, F, S> FilterToolbar(final DataTable<T, S> table, final
> FilterForm<F> form,
> final IFilterStateLocator<F> stateLocator)
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)